Skip to content

Emit cutover metrics#50

Merged
grodowski merged 4 commits into
masterfrom
grodowski/issue-5457-cutover-metrics
Jun 8, 2026
Merged

Emit cutover metrics#50
grodowski merged 4 commits into
masterfrom
grodowski/issue-5457-cutover-metrics

Conversation

@grodowski

@grodowski grodowski commented Jun 8, 2026

Copy link
Copy Markdown
Member

Copy of #45 which I merged to the wrong base by accident 🤦

grodowski added 2 commits June 8, 2026 16:40
   Add cutover metric helpers and instrument cutover attempts, phase
   durations, and terminal duration.

   Metrics emitted:
   - cut_over.attempts_total tagged with outcome
   - cut_over.phase_duration_milliseconds tagged with phase and outcome
   - cut_over.total_duration_milliseconds tagged with outcome

   Phase coverage includes the magic lock, original table lock, magic rename,
   and unlock paths. Durations are reported in milliseconds to preserve
   sub-second granularity.

   Add unit coverage for the cutover metric helper.
@grodowski grodowski force-pushed the grodowski/issue-5457-cutover-metrics branch from bd2f9a0 to e5021e1 Compare June 8, 2026 14:49
@grodowski grodowski added #gsd:50633 Data Storage: gh-ost Observability Instrumentation to-upstream labels Jun 8, 2026
@grodowski grodowski requested a review from forge33 June 8, 2026 14:52
@grodowski grodowski merged commit 438851e into master Jun 8, 2026
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

#gsd:50633 Data Storage: gh-ost Observability Instrumentation to-upstream

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants