Skip to content

perf: cache RuboCop team and filter cop registry to enabled cops #454

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ryanquanz wants to merge 1 commit into
base: main
Choose a base branch
from
Open

perf: cache RuboCop team and filter cop registry to enabled cops #454

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 21 additions & 11 deletions lib/erb_lint/linters/rubocop.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,11 @@ def initialize(file_loader, config)
custom_config = config_from_path(@config.config_file_path) if @config.config_file_path
custom_config ||= config_from_hash(@config.rubocop_config)
@rubocop_config = ::RuboCop::ConfigLoader.merge_with_default(custom_config, "")
@rubocop_target_ruby_version = @rubocop_config.target_ruby_version
@rubocop_version_gte_138 = ::RuboCop::Version::STRING.to_f >= 1.38
@rubocop_global_registry = RuboCop::Cop::Registry.global if @rubocop_version_gte_138
@cop_classes = build_cop_classes
@team = build_team
end

def run(processed_source)
Expand Down Expand Up @@ -65,7 +70,7 @@ def inspect_content(processed_source, erb_node)
source = rubocop_processed_source(aligned_source, processed_source.filename)
return unless source.valid_syntax?

activate_team(processed_source, source, offset, code_node, build_team)
activate_team(processed_source, source, offset, code_node, @team)
end

def activate_team(processed_source, source, offset, code_node, team)
Expand Down Expand Up @@ -95,29 +100,34 @@ def tempfile_from(filename, content)
def rubocop_processed_source(content, filename)
source = ::RuboCop::ProcessedSource.new(
content,
@rubocop_config.target_ruby_version,
@rubocop_target_ruby_version,
filename,
)
if ::RuboCop::Version::STRING.to_f >= 1.38
registry = RuboCop::Cop::Registry.global
source.registry = registry
if @rubocop_version_gte_138
source.registry = @rubocop_global_registry
source.config = @rubocop_config
end
source
end

def cop_classes
if @only_cops.present?
selected_cops = ::RuboCop::Cop::Registry.all.select { |cop| cop.match?(@only_cops) }
::RuboCop::Cop::Registry.new(selected_cops)
def build_cop_classes
all_cops = if @only_cops.present?
::RuboCop::Cop::Registry.all.select { |cop| cop.match?(@only_cops) }
else
::RuboCop::Cop::Registry.new(::RuboCop::Cop::Registry.all)
::RuboCop::Cop::Registry.all
end

# Filter to only cops that are enabled in the merged config
enabled_cops = all_cops.select do |cop|
@rubocop_config.for_cop(cop).fetch("Enabled") { true } != false
end

::RuboCop::Cop::Registry.new(enabled_cops)
end

def build_team
::RuboCop::Cop::Team.mobilize(
cop_classes,
@cop_classes,
@rubocop_config,
extra_details: true,
display_cop_names: true,
Expand Down
Loading