From 6cf655903b6b05b9da63208b4e643567e774fbea Mon Sep 17 00:00:00 2001 From: gonzaloriestra <14979109+gonzaloriestra@users.noreply.github.com> Date: Mon, 18 May 2026 00:40:48 +0000 Subject: [PATCH 1/2] [Refactor] Extract NAME_FAMILIES constant from getRandomName Extracted the static mapping object in `getRandomName` to a module-level constant to avoid redundant object creation and improve readability. --- .jules/refactor.md | 0 packages/cli-kit/src/public/common/string.ts | 23 ++++++++++---------- 2 files changed, 12 insertions(+), 11 deletions(-) create mode 100644 .jules/refactor.md diff --git a/.jules/refactor.md b/.jules/refactor.md new file mode 100644 index 00000000000..e69de29bb2d diff --git a/packages/cli-kit/src/public/common/string.ts b/packages/cli-kit/src/public/common/string.ts index 8ead23e1437..5ba4427ddf1 100644 --- a/packages/cli-kit/src/public/common/string.ts +++ b/packages/cli-kit/src/public/common/string.ts @@ -161,6 +161,17 @@ const SAFE_RANDOM_CREATIVE_NOUNS = [ export type RandomNameFamily = 'business' | 'creative' +const NAME_FAMILIES = { + business: { + adjectives: SAFE_RANDOM_BUSINESS_ADJECTIVES, + nouns: SAFE_RANDOM_BUSINESS_NOUNS, + }, + creative: { + adjectives: SAFE_RANDOM_CREATIVE_ADJECTIVES, + nouns: SAFE_RANDOM_CREATIVE_NOUNS, + }, +} + /** * Generates a random name by combining an adjective and noun. * @@ -168,17 +179,7 @@ export type RandomNameFamily = 'business' | 'creative' * @returns A random name generated by combining an adjective and noun. */ export function getRandomName(family: RandomNameFamily = 'business'): string { - const mapping = { - business: { - adjectives: SAFE_RANDOM_BUSINESS_ADJECTIVES, - nouns: SAFE_RANDOM_BUSINESS_NOUNS, - }, - creative: { - adjectives: SAFE_RANDOM_CREATIVE_ADJECTIVES, - nouns: SAFE_RANDOM_CREATIVE_NOUNS, - }, - } - return `${takeRandomFromArray(mapping[family].adjectives)}-${takeRandomFromArray(mapping[family].nouns)}` + return `${takeRandomFromArray(NAME_FAMILIES[family].adjectives)}-${takeRandomFromArray(NAME_FAMILIES[family].nouns)}` } /** From e5dab223d221787cfa2619786e2acffa960808df Mon Sep 17 00:00:00 2001 From: Gonzalo Riestra Date: Wed, 20 May 2026 12:27:44 +0200 Subject: [PATCH 2/2] Improve typing --- packages/cli-kit/src/public/common/string.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/cli-kit/src/public/common/string.ts b/packages/cli-kit/src/public/common/string.ts index 5ba4427ddf1..9daa97d6101 100644 --- a/packages/cli-kit/src/public/common/string.ts +++ b/packages/cli-kit/src/public/common/string.ts @@ -161,7 +161,7 @@ const SAFE_RANDOM_CREATIVE_NOUNS = [ export type RandomNameFamily = 'business' | 'creative' -const NAME_FAMILIES = { +const NAME_FAMILIES: Record = { business: { adjectives: SAFE_RANDOM_BUSINESS_ADJECTIVES, nouns: SAFE_RANDOM_BUSINESS_NOUNS,