Skip to content

Commit a378cfc

Browse files
refactor: remove env_auto_upgrade_package_manager metric
Package manager is already tracked via env_package_manager in the analytics layer. No need to duplicate it in auto-upgrade metrics.
1 parent 9162684 commit a378cfc

3 files changed

Lines changed: 1 addition & 24 deletions

File tree

packages/cli-kit/src/public/node/hooks/postrun.test.ts

Lines changed: 0 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -113,23 +113,6 @@ describe('autoUpgradeIfNeeded', () => {
113113
expect(outputMock.warn()).toMatch(installReminder)
114114
})
115115

116-
test('records package_manager metric for minor/patch upgrade', async () => {
117-
vi.mocked(versionToAutoUpgrade).mockReturnValue('3.100.0')
118-
vi.mocked(isMajorVersionChange).mockReturnValue(false)
119-
vi.mocked(inferPackageManagerForGlobalCLI).mockReturnValue('npm')
120-
vi.mocked(runCLIUpgrade).mockResolvedValue(undefined)
121-
122-
await autoUpgradeIfNeeded()
123-
124-
expect(addPublicMetadata).toHaveBeenCalledWith(expect.any(Function))
125-
const calls = vi.mocked(addPublicMetadata).mock.calls.map((call) => call[0]())
126-
expect(calls).toContainEqual(
127-
expect.objectContaining({
128-
env_auto_upgrade_package_manager: 'npm',
129-
}),
130-
)
131-
})
132-
133116
test('records skipped_reason for major version bump', async () => {
134117
vi.mocked(versionToAutoUpgrade).mockReturnValue('4.0.0')
135118
vi.mocked(isMajorVersionChange).mockReturnValue(true)

packages/cli-kit/src/public/node/hooks/postrun.ts

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -69,11 +69,6 @@ async function performAutoUpgrade(newerVersion: string): Promise<void> {
6969
return
7070
}
7171

72-
const packageManager = inferPackageManagerForGlobalCLI()
73-
await metadata.addPublicMetadata(() => ({
74-
env_auto_upgrade_package_manager: packageManager,
75-
}))
76-
7772
try {
7873
await runCLIUpgrade()
7974
await metadata.addPublicMetadata(() => ({env_auto_upgrade_success: true}))

packages/cli-kit/src/public/node/monorail.ts

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ const url = 'https://monorail-edge.shopifysvc.com/v1/produce'
1010
type Optional<T> = T | null
1111

1212
// This is the topic name of the main event we log to Monorail, the command tracker
13-
export const MONORAIL_COMMAND_TOPIC = 'app_cli3_command/1.20'
13+
export const MONORAIL_COMMAND_TOPIC = 'app_cli3_command/1.21'
1414

1515
export interface Schemas {
1616
[MONORAIL_COMMAND_TOPIC]: {
@@ -66,7 +66,6 @@ export interface Schemas {
6666
// Auto-upgrade
6767
env_auto_upgrade_enabled?: Optional<boolean>
6868
env_auto_upgrade_accepted?: Optional<boolean>
69-
env_auto_upgrade_package_manager?: Optional<string>
7069
env_auto_upgrade_skipped_reason?: Optional<string>
7170
env_auto_upgrade_success?: Optional<boolean>
7271

0 commit comments

Comments
 (0)