Update build workflow and project warnings

Removed unnecessary NuGet setup and GITHUB_ACTIONS property from the build workflow. Adjusted NoWarn properties in the project file to suppress additional NuGet warnings and reorganized property groups. Fixed type in SocketBasedTests to use IDummyAdbSocket for AdbSocketFactory.

Author: wherewhere

.github/workflows/build-and-test.yml

@@ -67,11 +67,8 @@ jobs:
         with:
           msbuild-architecture: x64
 
-      - name: Setup NuGet.exe
-        uses: NuGet/setup-nuget@v2
-        
       - name: Install Dependencies
-        run: msbuild $env:Solution_Name /t:Restore /p:FullTargets=true /p:GITHUB_ACTIONS=false
+        run: msbuild $env:Solution_Name /t:Restore /p:FullTargets=true
 
       - name: Pack
         run: msbuild $env:Solution_Name /t:Pack /p:FullTargets=true /p:Configuration=Release /p:PackageOutputPath=../nugets /p:VersionSuffix=build.${{ github.run_number }}.${{ github.run_attempt }}

AdvancedSharpAdbClient.Tests/SocketBasedTests.cs

@@ -12,7 +12,7 @@ public class SocketBasedTests
     {
         protected SocketBasedTests(bool integrationTest, bool doDispose)
         {
-            Func<EndPoint, IAdbSocket> AdbSocketFactory;
+            Func<EndPoint, IDummyAdbSocket> AdbSocketFactory;
 
             // this.EndPoint = AdbClient.Instance.EndPoint;
 #if DEBUG
@@ -37,7 +37,7 @@ protected SocketBasedTests(bool integrationTest, bool doDispose)
             AdbSocketFactory = endPoint => socket;
             IntegrationTest = false;
 #endif
-            Socket = (IDummyAdbSocket)AdbSocketFactory(EndPoint);
+            Socket = AdbSocketFactory(EndPoint);
 
             TestClient = new AdbClient(AdbSocketFactory);
         }

AdvancedSharpAdbClient/AdvancedSharpAdbClient.csproj

@@ -1,7 +1,6 @@
 <Project Sdk="Microsoft.NET.Sdk">
 
   <PropertyGroup>
-    <CheckNotRecommendedTargetFramework>False</CheckNotRecommendedTargetFramework>
     <FullTargets>True</FullTargets>
     <ImportAsync>True</ImportAsync>
     <Nullable>Enable</Nullable>
@@ -11,13 +10,14 @@
   </PropertyGroup>
 
   <PropertyGroup>
-    <NoWarn>$(NoWarn);NU1903</NoWarn>
+    <CheckNotRecommendedTargetFramework>False</CheckNotRecommendedTargetFramework>
+    <NoWarn>$(NoWarn);NU1902;NU1903</NoWarn>
     <TargetFrameworks>net8.0;net10.0;netstandard1.3;netstandard2.0;netstandard2.1</TargetFrameworks>
     <TargetFrameworks Condition="'$(IsWindows)' == 'True'">$(TargetFrameworks);net2.0;net3.5-client;net4.5;net4.8;net8.0-windows10.0.17763.0;net10.0-windows10.0.17763.0</TargetFrameworks>
   </PropertyGroup>
 
   <PropertyGroup Condition="'$(FullTargets)' == 'True'">
-    <NoWarn>$(NoWarn);NU1603;NU1605;NU1902</NoWarn>
+    <NoWarn>$(NoWarn);NU1603;NU1605</NoWarn>
     <TargetFrameworks>$(TargetFrameworks);net6.0;netcoreapp2.1;netcoreapp3.1</TargetFrameworks>
     <TargetFrameworks Condition="'$(IsWindows)' == 'True'">$(TargetFrameworks);net4.0-client;net4.6.1</TargetFrameworks>
     <TargetFrameworks Condition="'$(GITHUB_ACTIONS)' != 'True' and '$(IsWindows)' == 'True'">$(TargetFrameworks);netcore5.0;uap10.0;uap10.0.15138.0</TargetFrameworks>