Convert remaining code to use newer CreateGetter/CreateSetter APIs

Author: mythz

src/ServiceStack.Text/Common/WriteType.cs

@@ -16,7 +16,6 @@
 using System.IO;
 using System.Linq;
 using System.Reflection;
-using ServiceStack.Reflection;
 using ServiceStack.Text.Json;
 using ServiceStack.Text.Jsv;
 

src/ServiceStack.Text/CsvReader.cs

@@ -1,7 +1,6 @@
 using System;
 using System.Collections.Generic;
 using System.Linq;
-using ServiceStack.Reflection;
 using ServiceStack.Text.Common;
 using ServiceStack.Text.Jsv;
 

src/ServiceStack.Text/CsvSerializer.cs

@@ -1,15 +1,12 @@
 using System;
 using System.Collections.Generic;
-using System.Globalization;
 using System.IO;
 using System.Linq;
 using System.Reflection;
 using System.Text;
 using System.Threading;
-using ServiceStack.Reflection;
 using ServiceStack.Text.Common;
 using ServiceStack.Text.Jsv;
-using ServiceStack.Text.Pools;
 
 namespace ServiceStack.Text
 {
@@ -241,7 +238,7 @@ public static WriteObjectDelegate WriteFn()
 
         private const string IgnoreResponseStatus = "ResponseStatus";
 
-        private static Func<object, object> valueGetter = null;
+        private static GetMemberDelegate valueGetter = null;
         private static WriteObjectDelegate writeElementFn = null;
 
         private static WriteObjectDelegate GetWriteFn()
@@ -305,15 +302,15 @@ private static WriteObjectDelegate GetWriteFn()
             //If is DTO and has an enumerable property serialize that
             if (bestCandidateEnumerableType != null)
             {
-                valueGetter = bestCandidate.GetValueGetter(typeof(T));
+                valueGetter = bestCandidate.CreateGetter();
                 var elementType = bestCandidateEnumerableType.GenericTypeArguments()[0];
                 writeElementFn = CreateWriteFn(elementType);
 
                 return WriteEnumerableProperty;
             }
 
             //If is DTO and has non-enumerable, reference type property serialize that
-            valueGetter = firstCandidate.GetValueGetter(typeof(T));
+            valueGetter = firstCandidate.CreateGetter();
             writeElementFn = CreateWriteRowFn(firstCandidate.PropertyType);
 
             return WriteNonEnumerableType;
@@ -396,7 +393,7 @@ public static ParseStringDelegate ReadFn()
             return ReadCacheFn;
         }
 
-        private static Action<object, object> valueSetter = null;
+        private static SetMemberDelegate valueSetter = null;
         private static ParseStringDelegate readElementFn = null;
 
         private static ParseStringDelegate GetReadFn()
@@ -460,15 +457,15 @@ private static ParseStringDelegate GetReadFn()
             //If is DTO and has an enumerable property serialize that
             if (bestCandidateEnumerableType != null)
             {
-                valueSetter = bestCandidate.GetValueSetter(typeof(T));
+                valueSetter = bestCandidate.CreateSetter();
                 var elementType = bestCandidateEnumerableType.GenericTypeArguments()[0];
                 readElementFn = CreateReadFn(elementType);
 
                 return ReadEnumerableProperty;
             }
 
             //If is DTO and has non-enumerable, reference type property serialize that
-            valueSetter = firstCandidate.GetValueSetter(typeof(T));
+            valueSetter = firstCandidate.CreateSetter();
             readElementFn = CreateReadRowFn(firstCandidate.PropertyType);
 
             return ReadNonEnumerableType;

src/ServiceStack.Text/CsvWriter.cs

@@ -2,7 +2,6 @@
 using System.Collections.Generic;
 using System.IO;
 using System.Linq;
-using ServiceStack.Reflection;
 using ServiceStack.Text.Common;
 
 namespace ServiceStack.Text

src/ServiceStack.Text/TypeFields.cs

@@ -2,7 +2,6 @@
 using System.Collections.Generic;
 using System.Reflection;
 using System.Threading;
-using ServiceStack.Reflection;
 using ServiceStack.Text;
 
 using System.Linq.Expressions;

tests/ServiceStack.Text.Tests/StaticAccessorTests.cs

@@ -1,5 +1,4 @@
 using NUnit.Framework;
-using ServiceStack.Reflection;
 
 namespace ServiceStack.Text.Tests
 {
@@ -30,26 +29,26 @@ public void Can_get_accessor_in_declared_and_base_class()
             var baseProperty = typeof(AccessorBase).GetProperty("Base");
             var declaredProperty = typeof(Accessor).GetProperty("Declared");
 
-            var baseSetter = baseProperty.GetValueSetter<AccessorBase>();
+            var baseSetter = baseProperty.CreateGetter<AccessorBase>();
             Assert.That(baseSetter, Is.Not.Null);
 
-            var declaredSetter = declaredProperty.GetValueSetter<Accessor>();
+            var declaredSetter = declaredProperty.CreateSetter<Accessor>();
             Assert.That(declaredSetter, Is.Not.Null);
         }
 
         [Test]
         public void Can_get_property_accessor_from_sub_and_super_types()
         {
             var sub = new SubAccessor();
-            var subGet = StaticAccessors.GetValueGetter<SubAccessor>(typeof(SubAccessor).GetProperty("Sub"));
-            var subSet = StaticAccessors.GetValueSetter<SubAccessor>(typeof(SubAccessor).GetProperty("Sub"));
+            var subGet = typeof(SubAccessor).GetProperty("Sub").CreateGetter<SubAccessor>();
+            var subSet = typeof(SubAccessor).GetProperty("Sub").CreateSetter<SubAccessor>();
 
             subSet(sub, "sub");
             Assert.That(subGet(sub), Is.EqualTo("sub"));
 
             var sup = new AccessorBase();
-            var supGet = StaticAccessors.GetValueGetter<AccessorBase>(typeof(AccessorBase).GetProperty("Base"));
-            var supSet = StaticAccessors.GetValueSetter<AccessorBase>(typeof(AccessorBase).GetProperty("Base"));
+            var supGet = typeof(AccessorBase).GetProperty("Base").CreateGetter<AccessorBase>();
+            var supSet = typeof(AccessorBase).GetProperty("Base").CreateSetter<AccessorBase>();
 
             supSet(sup, "base");
             Assert.That(supGet(sup), Is.EqualTo("base"));
@@ -61,15 +60,15 @@ public void Can_get_property_accessor_from_sub_and_super_types()
         public void Can_get_field_accessor_from_sub_and_super_types()
         {
             var sub = new SubAccessor();
-            var subGet = StaticAccessors.GetValueGetter<SubAccessor>(typeof(SubAccessor).GetFieldInfo("SubField"));
-            var subSet = StaticAccessors.GetValueSetter<SubAccessor>(typeof(SubAccessor).GetFieldInfo("SubField"));
+            var subGet = typeof(SubAccessor).GetFieldInfo("SubField").CreateGetter<SubAccessor>();
+            var subSet = typeof(SubAccessor).GetFieldInfo("SubField").CreateSetter<SubAccessor>();
 
             subSet(sub, "sub");
             Assert.That(subGet(sub), Is.EqualTo("sub"));
 
             var sup = new AccessorBase();
-            var supGet = StaticAccessors.GetValueGetter<AccessorBase>(typeof(AccessorBase).GetFieldInfo("BaseField"));
-            var supSet = StaticAccessors.GetValueSetter<AccessorBase>(typeof(AccessorBase).GetFieldInfo("BaseField"));
+            var supGet = typeof(AccessorBase).GetFieldInfo("BaseField").CreateGetter<AccessorBase>();
+            var supSet = typeof(AccessorBase).GetFieldInfo("BaseField").CreateSetter<AccessorBase>();
 
             supSet(sup, "base");
             Assert.That(supGet(sup), Is.EqualTo("base"));