Fixed NRE caused by inherited non-public data members. (#506)

Author: chriswebb

src/ServiceStack.Text/Common/DeserializeType.cs

@@ -285,7 +285,7 @@ internal static ParseStringSegmentDelegate GetPropertyMethod(ITypeSerializer ser
         private static SetMemberDelegate GetSetPropertyMethod(TypeConfig typeConfig, PropertyInfo propertyInfo)
         {
             if (typeConfig.Type != propertyInfo.DeclaringType)
-                propertyInfo = propertyInfo.DeclaringType.GetProperty(propertyInfo.Name);
+                propertyInfo = propertyInfo.DeclaringType.GetProperty(propertyInfo.Name, BindingFlags.Instance | BindingFlags.Public | BindingFlags.NonPublic);
 
             if (!propertyInfo.CanWrite && !typeConfig.EnableAnonymousFieldSetters) return null;
 
@@ -326,7 +326,7 @@ public static TypeAccessor Create(ITypeSerializer serializer, TypeConfig typeCon
         private static SetMemberDelegate GetSetFieldMethod(TypeConfig typeConfig, FieldInfo fieldInfo)
         {
             if (typeConfig.Type != fieldInfo.DeclaringType)
-                fieldInfo = fieldInfo.DeclaringType.GetField(fieldInfo.Name);
+                fieldInfo = fieldInfo.DeclaringType.GetField(fieldInfo.Name, BindingFlags.Instance | BindingFlags.Public | BindingFlags.NonPublic);
 
             return PclExport.Instance.CreateSetter(fieldInfo);
         }

tests/ServiceStack.Text.Tests/ReportedIssues.cs

@@ -330,6 +330,68 @@ public void Deserialize_Correctly_When_Last_Item_Is_Null_in_Int_array_prop()
             var deserialized = TypeSerializer.DeserializeFromString<TestMappedList>(serialized);
             Assert.That(deserialized.IntArrayProp, Is.EqualTo(type.IntArrayProp));
         }
+
+
+        [Test]
+        public void Null_Reference_Exception_On_Inherited_Field_With_No_Setter()
+        {
+            string testString = null;
+            InheritedFieldErrorTest parentClass = new InheritedFieldErrorTest(), parentClassResult = null;
+            InheritedFieldErrorTestChild childClass = new InheritedFieldErrorTestChild(), childClassResult = null;
+            Assert.DoesNotThrow(() => { testString = JsonSerializer.SerializeToString(parentClass); });
+            Assert.IsNotNull(testString);
+            Assert.IsNotEmpty(testString);
+            Assert.DoesNotThrow(() => { parentClassResult = JsonSerializer.DeserializeFromString<InheritedFieldErrorTest>(testString); });
+            Assert.IsNotNull(parentClassResult);
+            Assert.DoesNotThrow(() => { testString = JsonSerializer.SerializeToString(childClass); });
+            Assert.IsNotNull(testString);
+            Assert.IsNotEmpty(testString);
+            Assert.DoesNotThrow(() => { childClassResult = JsonSerializer.DeserializeFromString<InheritedFieldErrorTestChild>(testString); });
+            Assert.IsNotNull(childClassResult);
+        }
+
+        [System.Runtime.Serialization.DataContract]
+        public class InheritedFieldErrorTest
+        {
+            [System.Runtime.Serialization.DataMember]
+            protected bool test = false;
+        }
+
+        [System.Runtime.Serialization.DataContract]
+        public class InheritedFieldErrorTestChild : InheritedFieldErrorTest
+        {
+        }
+
+        [Test]
+        public void Null_Reference_Exception_On_Inherited_Property_With_No_Setter()
+        {
+            string testString = null;
+            InheritedPropertyErrorTest parentClass = new InheritedPropertyErrorTest(), parentClassResult = null;
+            InheritedPropertyErrorTestChild childClass = new InheritedPropertyErrorTestChild(), childClassResult = null;
+            Assert.DoesNotThrow(() => { testString = JsonSerializer.SerializeToString(parentClass); });
+            Assert.IsNotNull(testString);
+            Assert.IsNotEmpty(testString);
+            Assert.DoesNotThrow(() => { parentClassResult = JsonSerializer.DeserializeFromString<InheritedPropertyErrorTest>(testString); });
+            Assert.IsNotNull(parentClassResult);
+            Assert.DoesNotThrow(() => { testString = JsonSerializer.SerializeToString(childClass); });
+            Assert.IsNotNull(testString);
+            Assert.IsNotEmpty(testString);
+            Assert.DoesNotThrow(() => { childClassResult = JsonSerializer.DeserializeFromString<InheritedPropertyErrorTestChild>(testString); });
+            Assert.IsNotNull(childClassResult);
+        }
+
+
+        [System.Runtime.Serialization.DataContract]
+        public class InheritedPropertyErrorTest
+        {
+            [System.Runtime.Serialization.DataMember]
+            protected bool Test { get; }
+        }
+
+        [System.Runtime.Serialization.DataContract]
+        public class InheritedPropertyErrorTestChild : InheritedPropertyErrorTest
+        {
+        }
     }
 
     public class TestMappedList