Resolve warnings

Author: mythz

src/ServiceStack.Text/Common/DeserializeType.cs

@@ -362,8 +362,8 @@ private static SetMemberDelegate GetSetPropertyMethod(TypeConfig typeConfig, Pro
             }
 
             return propertyInfo.CanWrite
-                ? PclExport.Instance.CreateSetter(propertyInfo)
-                : PclExport.Instance.CreateSetter(fieldInfo);
+                ? ReflectionOptimizer.Instance.CreateSetter(propertyInfo)
+                : ReflectionOptimizer.Instance.CreateSetter(fieldInfo);
         }
 
         public static TypeAccessor Create(ITypeSerializer serializer, TypeConfig typeConfig, FieldInfo fieldInfo)
@@ -381,7 +381,7 @@ private static SetMemberDelegate GetSetFieldMethod(TypeConfig typeConfig, FieldI
             if (typeConfig.Type != fieldInfo.DeclaringType)
                 fieldInfo = fieldInfo.DeclaringType.GetField(fieldInfo.Name, BindingFlags.Instance | BindingFlags.Public | BindingFlags.NonPublic);
 
-            return PclExport.Instance.CreateSetter(fieldInfo);
+            return ReflectionOptimizer.Instance.CreateSetter(fieldInfo);
         }
     }
 

src/ServiceStack.Text/Json/JsonTypeSerializer.cs

@@ -686,7 +686,7 @@ public ReadOnlySpan<char> EatMapKey(ReadOnlySpan<char> value, ref int i)
                 }
             }
 
-            return value.Subsegment(tokenStartPos, i - tokenStartPos);
+            return value.Slice(tokenStartPos, i - tokenStartPos);
         }
 
         public bool EatMapKeySeperator(string value, ref int i) => EatMapKeySeperator(value.AsSpan(), ref i);

src/ServiceStack.Text/LicenseUtils.cs

@@ -125,10 +125,10 @@ static LicenseUtils()
             PclExport.Instance.RegisterLicenseFromConfig();
         }
 
-        private static bool hasInit;
+        public static bool HasInit { get; private set; }
         public static void Init()
         {
-            hasInit = true; //Dummy method to init static constructor
+            HasInit = true; //Dummy method to init static constructor
         }
 
         public static class ErrorMessages

src/ServiceStack.Text/MemoryProvider.cs

@@ -917,7 +917,6 @@ public static long ParseInt64(ReadOnlySpan<char> value)
     internal static class UnsignedInteger<T> where T : struct, IComparable<T>, IEquatable<T>, IConvertible
     {
         private static readonly TypeCode typeCode;
-        private static readonly ulong minValue;
         private static readonly ulong maxValue;
 
         static UnsignedInteger()
@@ -927,19 +926,15 @@ static UnsignedInteger()
             switch (typeCode)
             {
                 case TypeCode.Byte:
-                    minValue = byte.MinValue;
                     maxValue = byte.MaxValue;
                     break;
                 case TypeCode.UInt16:
-                    minValue = ushort.MinValue;
                     maxValue = ushort.MaxValue;
                     break;
                 case TypeCode.UInt32:
-                    minValue = uint.MinValue;
                     maxValue = uint.MaxValue;
                     break;
                 case TypeCode.UInt64:
-                    minValue = ulong.MinValue;
                     maxValue = ulong.MaxValue;
                     break;
                 default:

src/ServiceStack.Text/StreamExtensions.cs

@@ -320,7 +320,7 @@ public static string ReadToEnd(this MemoryStream ms, Encoding encoding)
                 var ret = encoding.GetString(ms.GetBuffer(), 0, (int) ms.Length);
                 return ret;
             }
-            catch (UnauthorizedAccessException e)
+            catch (UnauthorizedAccessException)
             {
                 Tracer.Instance.WriteWarning("MemoryStream wasn't created with a publiclyVisible:true byte[] bufffer, falling back to slow impl");
 
@@ -337,7 +337,7 @@ public static ReadOnlyMemory<byte> GetBufferAsMemory(this MemoryStream ms)
             {
                 return new ReadOnlyMemory<byte>(ms.GetBuffer(), 0, (int)ms.Length);
             }
-            catch (UnauthorizedAccessException e)
+            catch (UnauthorizedAccessException)
             {
                 Tracer.Instance.WriteWarning("MemoryStream in GetBufferAsSpan() wasn't created with a publiclyVisible:true byte[] bufffer, falling back to slow impl");
                 return new ReadOnlyMemory<byte>(ms.ToArray());
@@ -350,7 +350,7 @@ public static ReadOnlySpan<byte> GetBufferAsSpan(this MemoryStream ms)
             {
                 return new ReadOnlySpan<byte>(ms.GetBuffer(), 0, (int)ms.Length);
             }
-            catch (UnauthorizedAccessException e)
+            catch (UnauthorizedAccessException)
             {
                 Tracer.Instance.WriteWarning("MemoryStream in GetBufferAsSpan() wasn't created with a publiclyVisible:true byte[] bufffer, falling back to slow impl");
                 return new ReadOnlySpan<byte>(ms.ToArray());
@@ -363,7 +363,7 @@ public static byte[] GetBufferAsBytes(this MemoryStream ms)
             {
                 return ms.GetBuffer();
             }
-            catch (UnauthorizedAccessException e)
+            catch (UnauthorizedAccessException)
             {
                 Tracer.Instance.WriteWarning("MemoryStream in GetBufferAsBytes() wasn't created with a publiclyVisible:true byte[] bufffer, falling back to slow impl");
                 return ms.ToArray();
@@ -379,7 +379,7 @@ public static Task<string> ReadToEndAsync(this MemoryStream ms, Encoding encodin
                 var ret = encoding.GetString(ms.GetBuffer(), 0, (int) ms.Length);
                 return ret.InTask();
             }
-            catch (UnauthorizedAccessException e)
+            catch (UnauthorizedAccessException)
             {
                 Tracer.Instance.WriteWarning("MemoryStream in ReadToEndAsync() wasn't created with a publiclyVisible:true byte[] bufffer, falling back to slow impl");
 
@@ -433,7 +433,7 @@ public static async Task WriteToAsync(this MemoryStream stream, Stream output, E
             {
                 await output.WriteAsync(stream.GetBuffer(), 0, (int) stream.Length, token);
             }
-            catch (UnauthorizedAccessException e)
+            catch (UnauthorizedAccessException)
             {
                 Tracer.Instance.WriteWarning("MemoryStream in WriteToAsync() wasn't created with a publiclyVisible:true byte[] bufffer, falling back to slow impl");
 

tests/ServiceStack.Text.Tests/JsonTests/JsonObjectTests.cs

@@ -503,7 +503,7 @@ public void Can_deserialize_custom_JsonObject_with_incorrect_payload()
                 var payload = dto.Event.EventPayLoad.ConvertTo<EventPayLoadPosition>();
                 Assert.Fail("Should throw");
             }
-            catch (FormatException e) {}
+            catch (FormatException) {}
         }