Add perf improvements for JsConfig<T>.OnDeserializedFn / OnSerializingFn

Author: mythz

src/ServiceStack.Text/Common/JsReader.cs

@@ -15,7 +15,8 @@ public ParseStringDelegate GetParseFn<T>()
             var onDeserializedFn = JsConfig<T>.OnDeserializedFn;
             if (onDeserializedFn != null)
             {
-                return value => onDeserializedFn((T)GetCoreParseFn<T>()(value));
+                var parseFn = GetCoreParseFn<T>();
+                return value => onDeserializedFn((T)parseFn(value));
             }
 
             return GetCoreParseFn<T>();

src/ServiceStack.Text/Common/JsWriter.cs

@@ -267,7 +267,8 @@ public WriteObjectDelegate GetWriteFn<T>()
             var onSerializingFn = JsConfig<T>.OnSerializingFn;
             if (onSerializingFn != null)
             {
-                ret = (w, x) => GetCoreWriteFn<T>()(w, onSerializingFn((T)x));
+                var writeFn = GetCoreWriteFn<T>();
+                ret = (w, x) => writeFn(w, onSerializingFn((T)x));
             }
 
             if (JsConfig<T>.HasSerializeFn)

tests/ServiceStack.Text.Tests/SerializationDelegatePerformanceTests.cs

@@ -0,0 +1,134 @@
+using System;
+using System.Collections.Generic;
+using NUnit.Framework;
+using System.Diagnostics;
+
+namespace ServiceStack.Text.Tests
+{
+    [TestFixture]
+    public class SerializationDelegatePerformanceTests
+        : TestBase
+    {
+        [TestFixtureSetUp]
+        public void SetUp()
+        {
+            AddSerializeHooksForType<PerformanceTestHookClass>();
+        }
+
+        [Test]
+        public void TypeSerializer_Deserialize_Performance_WithoutHook()
+        {
+            var data = GenerateData<PerformanceTestClass>();
+
+            var stringvalue = TypeSerializer.SerializeToString(data);
+
+            Stopwatch watch = Stopwatch.StartNew();
+            var deserializedData = TypeSerializer.DeserializeFromString<List<PerformanceTestClass>>(stringvalue);
+            watch.Stop();
+
+            Debug.WriteLine("Elapsed time: {0}ms", watch.ElapsedMilliseconds);
+
+            // should be at least less than 200ms
+            Assert.LessOrEqual(watch.ElapsedMilliseconds, 200);
+        }
+
+        [Test]
+        public void TypeSerializer_Deserialize_Performance_WithHook()
+        {
+            var data = GenerateData<PerformanceTestHookClass>();
+
+            var stringvalue = TypeSerializer.SerializeToString(data);
+
+            Stopwatch watch = Stopwatch.StartNew();
+            var deserializedData = TypeSerializer.DeserializeFromString<List<PerformanceTestHookClass>>(stringvalue);
+            watch.Stop();
+
+            Debug.WriteLine("Elapsed time: {0}ms", watch.ElapsedMilliseconds);
+
+            // should be at least less than 600ms
+            Assert.LessOrEqual(watch.ElapsedMilliseconds, 600);
+        }
+
+        [Test]
+        public void TypeSerializer_Serialize_Performance_WithoutHook()
+        {
+            var data = GenerateData<PerformanceTestClass>();
+
+            Stopwatch watch = Stopwatch.StartNew();
+            var stringvalue = TypeSerializer.SerializeToString(data);
+            watch.Stop();
+
+            Debug.WriteLine("Elapsed time: {0}ms", watch.ElapsedMilliseconds);
+
+            // should be at least less than 100ms
+            Assert.LessOrEqual(watch.ElapsedMilliseconds, 100);
+        }
+
+        [Test]
+        public void TypeSerializer_Serialize_Performance_WithHook()
+        {
+            var data = GenerateData<PerformanceTestHookClass>();
+
+            Stopwatch watch = Stopwatch.StartNew();
+            var stringvalue = TypeSerializer.SerializeToString(data);
+            watch.Stop();
+
+            Debug.WriteLine("Elapsed time: {0}ms", watch.ElapsedMilliseconds);
+
+            // should be at least less than 100ms
+            Assert.LessOrEqual(watch.ElapsedMilliseconds, 100);
+        }
+
+        private List<T> GenerateData<T>() where T : PerformanceTestClass, new()
+        {
+            List<T> result = new List<T>();
+
+            for (int i = 0; i < 5000; i++)
+            {
+                T user = new T();
+                user.FirstName = "Performance" + i;
+                user.LastName = "Test";
+                user.ID = i;
+                user.Email = String.Format("mail{0}@test.com", i);
+                user.UserName = "Test" + i;
+                user.AddressID = i * 32;
+
+                result.Add(user);
+            }
+
+            return result;
+        }
+
+        public static void AddSerializeHooksForType<T>()
+        {
+
+            JsConfig<T>.OnSerializingFn = s =>
+            {
+                return s;
+            };
+
+            JsConfig<T>.OnSerializedFn = s =>
+            {
+
+            };
+
+            JsConfig<T>.OnDeserializedFn = s =>
+            {
+                return s;
+            };
+
+        }
+
+        class PerformanceTestClass : SerializationHookTests.HookTestSubClass
+        {
+            public string FirstName { get; set; }
+            public string LastName { get; set; }
+            public int ID { get; set; }
+            public string Email { get; set; }
+            public string UserName { get; set; }
+            public int AddressID { get; set; }
+        }
+
+        class PerformanceTestHookClass : PerformanceTestClass { }
+    }
+}

tests/ServiceStack.Text.Tests/SerializationHookTests.cs

@@ -141,7 +141,7 @@ private void AddSerializeHooksForType<T>()
             }
         }
 
-        class HookTestClass
+        public class HookTestClass
         {
             public bool OnDeserializingTouched { get; set; }
             public bool OnDeserializedTouched { get; set; }
@@ -189,7 +189,7 @@ protected void OnSerialized(StreamingContext ctx)
             }
         }
 
-        class HookTestSubClass : HookTestClass
+        public class HookTestSubClass : HookTestClass
         {
         }
     }

tests/ServiceStack.Text.Tests/ServiceStack.Text.Tests.csproj

@@ -176,6 +176,7 @@
     </Reference>
   </ItemGroup>
   <ItemGroup>
+    <Compile Include="SerializationDelegatePerformanceTests.cs" />
     <Compile Include="SerializationHookTests.cs" />
     <Compile Include="StaticAccessorTests.cs" />
     <Compile Include="AdhocModelTests.cs" />