Implement GetMethodInfo with Type[] params for .NET Core

Author: xplicit

.vscode/launch.json

@@ -6,8 +6,9 @@
             "type": "coreclr",
             "request": "launch",
             "preLaunchTask": "build",
-            "program": "${workspaceRoot}/tests/ServiceStack.Text.Tests/bin/Debug/netcoreapp1.0/ServiceStack.Text.Tests.dll",
-            //"args": ["--test=ServiceStack.Text.Tests.AutoMappingTests.Can_create_Dictionary_default_value"],
+            "program": "${workspaceRoot}/tests/ServiceStack.Text.Tests/bin/Debug/netcoreapp1.1/ServiceStack.Text.Tests.dll",
+            //"args": ["--test=ServiceStack.Text.Tests.ReflectionExtensionTests", "--labels=All"],
+            "args": ["--labels=All"],
             "cwd": "${workspaceRoot}",
             "stopAtEntry": false,
             "externalConsole": false

src/ServiceStack.Text/PlatformExtensions.cs

@@ -795,7 +795,19 @@ public static MethodInfo GetStaticMethod(this Type type, string methodName, Type
         public static MethodInfo GetMethodInfo(this Type type, string methodName, Type[] types = null)
         {
 #if (NETFX_CORE || PCL || NETSTANDARD1_1)
-            return type.GetRuntimeMethods().FirstOrDefault(p => p.Name.Equals(methodName));
+            if (types == null) 
+                return type.GetRuntimeMethods().FirstOrDefault(p => p.Name.Equals(methodName));
+
+            foreach(var mi in type.GetRuntimeMethods().Where(p => p.Name.Equals(methodName)))
+            {
+                var methodParams = mi.GetParameters().Select(p => p.ParameterType);
+                if (methodParams.SequenceEqual(types))
+                {
+                    return mi;
+                }
+            }
+
+            return null;
 #else
             return types == null
                 ? type.GetMethod(methodName)

tests/ServiceStack.Text.Tests/ReflectionExtensionTests.cs

@@ -3,6 +3,7 @@
 using System.Linq;
 using System.Text;
 using NUnit.Framework;
+using ServiceStack;
 
 namespace ServiceStack.Text.Tests
 {
@@ -37,6 +38,21 @@ public int IntMethod()
         }
     }
 
+    public class MethodsForReflection
+    {
+        public string Result = String.Empty;
+
+        public void HelloVoid()
+        {
+            Result = "Hello";
+        }
+
+        public void Hello(bool a, int b)
+        {
+            Result = String.Format($"Hello {a} {b}");
+        }
+    }
+
 	[TestFixture]
 	public class ReflectionExtensionTests
 		: TestBase
@@ -84,6 +100,26 @@ public void Can_create_intances_of_recursive_generic_type()
         {
             //Assert.That(typeof(GenericType<>).MakeGenericType(new[] { typeof(GenericType<>) }).CreateInstance(), Is.Not.Null);
         }
+
+        [Test]
+        public void Can_get_method_from_type()
+        {
+            var testInstance = new MethodsForReflection();
+
+            var helloVoidMethod = typeof(MethodsForReflection).GetMethodInfo(nameof(MethodsForReflection.HelloVoid));
+            Assert.That(helloVoidMethod, Is.Not.Null);
+            var helloVoidDelegate = (Action<MethodsForReflection>)helloVoidMethod.MakeDelegate(typeof(Action<MethodsForReflection>));
+            Assert.That(helloVoidDelegate, Is.Not.Null);
+            helloVoidDelegate(testInstance);
+            Assert.That(testInstance.Result, Is.EqualTo("Hello"));
+
+            var helloVoidBoolIntMethod = typeof(MethodsForReflection).GetMethodInfo(nameof(MethodsForReflection.Hello), new Type[] { typeof(bool), typeof(int)});
+            Assert.That(helloVoidBoolIntMethod, Is.Not.Null);
+            var helloVoidBoolIntDelegate = (Action<MethodsForReflection, bool, int>)helloVoidBoolIntMethod.MakeDelegate(typeof(Action<MethodsForReflection, bool, int>));
+            Assert.That(helloVoidBoolIntDelegate, Is.Not.Null);
+            helloVoidBoolIntDelegate(testInstance, true, 5);
+            Assert.That(testInstance.Result, Is.EqualTo("Hello True 5"));
+        }
     }
 
     public class GenericType<T> { }