Change to use TypeConstants when possible

Author: mythz

lib/ServiceStack.Client.dll

@@ -2,6 +2,7 @@
 using System.Collections.Generic;
 using System.Linq;
 using ServiceStack.Logging;
+using ServiceStack.Text;
 
 namespace ServiceStack.Redis
 {
@@ -57,7 +58,7 @@ public virtual void ResetSlaves(IEnumerable<string> hosts)
 
         public virtual void ResetSlaves(List<RedisEndpoint> newSlaves)
         {
-            slaves = (newSlaves ?? new List<RedisEndpoint>()).ToArray();
+            slaves = (newSlaves ?? TypeConstants<RedisEndpoint>.EmptyList).ToArray();
             ReadOnlyHostsCount = slaves.Length;
 
             if (log.IsDebugEnabled)

lib/ServiceStack.Common.dll

@@ -50,10 +50,10 @@ public partial class PooledRedisClientManager
         public IRedisResolver RedisResolver { get; set; }
         public List<Action<IRedisClientsManager>> OnFailover { get; private set; }
 
-        private RedisClient[] writeClients = new RedisClient[0];
+        private RedisClient[] writeClients = TypeConstants<RedisClient>.EmptyArray;
         protected int WritePoolIndex;
 
-        private RedisClient[] readClients = new RedisClient[0];
+        private RedisClient[] readClients = TypeConstants<RedisClient>.EmptyArray;
         protected int ReadPoolIndex;
 
         protected int RedisClientCounter = 0;
@@ -120,8 +120,8 @@ public PooledRedisClientManager(
                 ? config.DefaultDb ?? initalDb
                 : initalDb;
 
-            var masters = (readWriteHosts ?? new string[0]).ToArray();
-            var slaves = (readOnlyHosts ?? new string[0]).ToArray();
+            var masters = (readWriteHosts ?? TypeConstants.EmptyStringArray).ToArray();
+            var slaves = (readOnlyHosts ?? TypeConstants.EmptyStringArray).ToArray();
 
             RedisResolver = new RedisResolver(masters, slaves);
 

lib/ServiceStack.Interfaces.dll

@@ -16,15 +16,16 @@
 using System.Linq;
 using System.Net.Sockets;
 using ServiceStack.Model;
+using ServiceStack.Text;
 
 namespace ServiceStack.Redis
 {
     public static class RedisExtensions
     {
         public static List<RedisEndpoint> ToRedisEndPoints(this IEnumerable<string> hosts)
         {
-            return hosts == null 
-                ? new List<RedisEndpoint>() 
+            return hosts == null
+                ? new List<RedisEndpoint>()
                 : hosts.Select(x => ToRedisEndpoint(x)).ToList();
         }
 
@@ -64,7 +65,7 @@ public static RedisEndpoint ToRedisEndpoint(this string connectionString, int? d
                     var value = entry.Length > 1 ? entry[1].UrlDecode() : null;
                     if (value == null) continue;
 
-                    var name = entry[0].ToLower(); 
+                    var name = entry[0].ToLower();
                     switch (name)
                     {
                         case "db":
@@ -149,7 +150,7 @@ public static List<string> ToStringList(this byte[][] multiDataList)
         public static string[] ToStringArray(this byte[][] multiDataList)
         {
             if (multiDataList == null)
-                return new string[0];
+                return TypeConstants.EmptyStringArray;
 
             var to = new string[multiDataList.Length];
             for (int i = 0; i < multiDataList.Length; i++)
@@ -162,7 +163,7 @@ public static string[] ToStringArray(this byte[][] multiDataList)
         public static Dictionary<string, string> ToStringDictionary(this byte[][] multiDataList)
         {
             if (multiDataList == null)
-                return new Dictionary<string, string>();
+                return TypeConstants.EmptyStringDictionary;
 
             var map = new Dictionary<string, string>();
 
@@ -190,20 +191,20 @@ private static byte[] FastToUtf8Bytes(string strVal)
         {
             var bytes = new byte[strVal.Length];
             for (var i = 0; i < strVal.Length; i++)
-                bytes[i] = (byte) strVal[i];
+                bytes[i] = (byte)strVal[i];
 
             return bytes;
         }
 
-		public static byte[][] ToMultiByteArray(this string[] args)
-    	{
-    		var byteArgs = new byte[args.Length][];
-    		for (var i = 0; i < args.Length; ++i)
-    			byteArgs[i] = args[i].ToUtf8Bytes();
-    		return byteArgs;
-    	}
+        public static byte[][] ToMultiByteArray(this string[] args)
+        {
+            var byteArgs = new byte[args.Length][];
+            for (var i = 0; i < args.Length; ++i)
+                byteArgs[i] = args[i].ToUtf8Bytes();
+            return byteArgs;
+        }
 
-        public static  byte[][] PrependByteArray(this byte[][] args, byte[] valueToPrepend)
+        public static byte[][] PrependByteArray(this byte[][] args, byte[] valueToPrepend)
         {
             var newArgs = new byte[args.Length + 1][];
             newArgs[0] = valueToPrepend;
@@ -213,7 +214,7 @@ public static  byte[][] PrependByteArray(this byte[][] args, byte[] valueToPrepe
 
             return newArgs;
         }
-        public static  byte[][] PrependInt(this byte[][] args, int valueToPrepend)
+        public static byte[][] PrependInt(this byte[][] args, int valueToPrepend)
         {
             return args.PrependByteArray(valueToPrepend.ToUtf8Bytes());
         }