Remove all warnings + deprecated usages

Author: mythz

src/ServiceStack.Redis/Generic/RedisTypedPipeline.cs

@@ -53,13 +53,12 @@ protected void Execute()
         {
             foreach (var queuedCommand in QueuedCommands)
             {
-                var cmd = queuedCommand as QueuedRedisTypedCommand<T>;
-                if (cmd != null)
+                if (queuedCommand is QueuedRedisTypedCommand<T> cmd)
                     cmd.Execute(RedisClient);
             }
         }
 
-        public bool Replay()
+        public virtual bool Replay()
         {
             RedisClient.Pipeline = this;
             Execute();
@@ -72,7 +71,7 @@ protected void ClosePipeline()
             RedisClient.EndPipeline();
         }
 
-        public void Dispose()
+        public virtual void Dispose()
         {
             ClosePipeline();
         }

src/ServiceStack.Redis/Generic/RedisTypedTransaction.cs

@@ -120,10 +120,9 @@ public bool Commit()
         private void handleMultiDataResultCount(int count)
         {
             if (count != _numCommands)
-                throw new InvalidOperationException(string.Format(
-                    "Invalid results received from 'EXEC', expected '{0}' received '{1}'"
-                    + "\nWarning: Transaction was committed",
-                    _numCommands, count));
+                throw new InvalidOperationException(
+                    $"Invalid results received from 'EXEC', expected '{_numCommands}' received '{count}'" +
+                    "\nWarning: Transaction was committed");
         }
 
         public void Rollback()
@@ -135,7 +134,7 @@ public void Rollback()
             RedisClient.ClearTypeIdsRegisteredDuringPipeline();
         }
 
-        public bool Replay()
+        public override bool Replay()
         {
             bool rc = true;
             try
@@ -163,7 +162,7 @@ public bool Replay()
             return rc;
         }
 
-        public void Dispose()
+        public override void Dispose()
         {
             base.Dispose();
             if (RedisClient.Transaction == null) return;

src/ServiceStack.Redis/Pipeline/RedisAllPurposePipeline.cs

@@ -67,7 +67,7 @@ protected void Execute()
             }
         }
 
-        public bool Replay()
+        public virtual bool Replay()
         {
             Init();
             Execute();
@@ -80,7 +80,7 @@ protected void ClosePipeline()
             RedisClient.EndPipeline();
         }
 
-        public void Dispose()
+        public virtual void Dispose()
         {
             ClosePipeline();
         }

src/ServiceStack.Redis/RedisClient.cs

@@ -539,7 +539,7 @@ public Dictionary<string, T> GetValuesMap<T>(List<string> keys)
             return results;
         }
 
-        public IRedisSubscription CreateSubscription()
+        public override IRedisSubscription CreateSubscription()
         {
             return new RedisSubscription(this);
         }

src/ServiceStack.Redis/RedisNativeClient.cs

@@ -2133,7 +2133,7 @@ public byte[][] ReceiveMessages()
             return ReadMultiData();
         }
 
-        public IRedisSubscription CreateSubscription()
+        public virtual IRedisSubscription CreateSubscription()
         {
             return new RedisSubscription(this);
         }

src/ServiceStack.Redis/RedisNativeClient_Utils.cs

@@ -127,7 +127,7 @@ private void Connect()
                             userCertificateSelectionCallback: RedisConfig.CertificateSelectionCallback,
                             encryptionPolicy: EncryptionPolicy.RequireEncryption);
 #else
-                        var ctor = typeof(SslStream).GetAllConstructors()
+                        var ctor = typeof(SslStream).GetConstructors()
                             .First(x => x.GetParameters().Length == 5);
 
                         var policyType = AssemblyUtils.FindType("System.Net.Security.EncryptionPolicy");

src/ServiceStack.Redis/Support/OrderedDictionary.cs

@@ -16,7 +16,7 @@ public class OrderedDictionary<TKey, TValue> : IOrderedDictionary<TKey, TValue>
 
 		private static readonly string KeyTypeName = typeof(TKey).FullName;
 		private static readonly string ValueTypeName = typeof(TValue).FullName;
-		private static readonly bool ValueTypeIsReferenceType =	!typeof(ValueType).AssignableFrom(typeof(TValue));
+		private static readonly bool ValueTypeIsReferenceType =	!typeof(ValueType).IsAssignableFrom(typeof(TValue));
 		private Dictionary<TKey, TValue> dictionary;
 		private List<KeyValuePair<TKey, TValue>> list;
 		private readonly IEqualityComparer<TKey> comparer;

src/ServiceStack.Redis/Transaction/RedisTransaction.cs

@@ -128,7 +128,7 @@ public void Rollback()
             RedisClient.ClearTypeIdsRegisteredDuringPipeline();
         }
 
-        public bool Replay()
+        public override bool Replay()
         {
             bool rc = true;
             try
@@ -141,7 +141,7 @@ public bool Replay()
                     queuedCommand.ProcessResult();
                 }
             }
-            catch (RedisTransactionFailedException e)
+            catch (RedisTransactionFailedException)
             {
                 rc = false;
             }
@@ -154,7 +154,7 @@ public bool Replay()
             return rc;
         }
 
-        public void Dispose()
+        public override void Dispose()
         {
             base.Dispose();
             if (RedisClient.Transaction == null) return;

tests/Console.Tests/HashCollectionStressTests.cs

@@ -272,7 +272,7 @@ private TOut RetryAction<TOut>(Func<IRedisClient, TOut> action)
                         return result;
                     }
                 }
-                catch (Exception ex)
+                catch (Exception)
                 {
 
                     if (i++ < 3)

tests/Console.Tests/HashStressTest.cs

@@ -27,6 +27,11 @@ public override bool Equals(object obj)
             if (obj.GetType() != this.GetType()) return false;
             return Equals((DeviceInfo) obj);
         }
+
+        public override int GetHashCode()
+        {
+            return base.GetHashCode();
+        }
     }
 
     public class HashStressTest