fix: accept fileContents from bot directly — eliminate GITHUB_TOKEN dependency

Author: Phoenix1808

src/routes/bot.ts

@@ -1,14 +1,21 @@
 import type { FastifyInstance, FastifyRequest } from 'fastify';
-import { Octokit } from '@octokit/rest';
 import { analyzeCode } from '../services/analyzer/index.js';
 
+// ── Bot payload — bot now sends file content directly ────────────────────────
+interface FileContent {
+  filename:    string;
+  status:      string;
+  headContent: string;
+  baseContent: string;
+}
+
 interface BotPayload {
-  owner: string;
-  repo: string;
-  prNumber: number;
-  baseSha: string;
-  headSha: string;
-  files: { filename: string; status: string }[];
+  owner:        string;
+  repo:         string;
+  prNumber:     number;
+  baseSha:      string;
+  headSha:      string;
+  fileContents: FileContent[];
 }
 
 function getLanguageFromFilename(filename: string): 'typescript' | 'javascript' | null {
@@ -17,46 +24,45 @@ function getLanguageFromFilename(filename: string): 'typescript' | 'javascript'
   return null;
 }
 
-// ── Inline pricing (no Redis dependency) ─────────────────────────────────────
+// ── Inline pricing (no Redis / no HTTP dependency) ───────────────────────────
 const OPENAI_PRICING: Record<string, { input: number; output: number }> = {
-  'gpt-4o':              { input: 0.005,   output: 0.015  },
-  'gpt-4o-mini':         { input: 0.00015, output: 0.0006 },
-  'gpt-4-turbo':         { input: 0.01,    output: 0.03   },
-  'gpt-4':               { input: 0.03,    output: 0.06   },
-  'gpt-3.5-turbo':       { input: 0.0005,  output: 0.0015 },
+  'gpt-4o':          { input: 0.005,   output: 0.015  },
+  'gpt-4o-mini':     { input: 0.00015, output: 0.0006 },
+  'gpt-4-turbo':     { input: 0.01,    output: 0.03   },
+  'gpt-4':           { input: 0.03,    output: 0.06   },
+  'gpt-3.5-turbo':   { input: 0.0005,  output: 0.0015 },
 };
 
 const ANTHROPIC_PRICING: Record<string, { input: number; output: number }> = {
-  'claude-3-5-sonnet':   { input: 0.003,   output: 0.015  },
-  'claude-3-opus':       { input: 0.015,   output: 0.075  },
-  'claude-3-sonnet':     { input: 0.003,   output: 0.015  },
-  'claude-3-haiku':      { input: 0.00025, output: 0.00125 },
-  'claude-2':            { input: 0.008,   output: 0.024  },
+  'claude-3-5-sonnet': { input: 0.003,   output: 0.015   },
+  'claude-3-opus':     { input: 0.015,   output: 0.075   },
+  'claude-3-sonnet':   { input: 0.003,   output: 0.015   },
+  'claude-3-haiku':    { input: 0.00025, output: 0.00125 },
+  'claude-2':          { input: 0.008,   output: 0.024   },
 };
 
-function estimateCentsInline(service: string, model: string | undefined, callsPerMonth: number,
-                              inputTokens: number, outputTokens: number,
-                              storageGB?: number, operation?: string): number {
+function estimateCents(
+  service: string, model: string | undefined,
+  callsPerMonth: number, inputTokens: number, outputTokens: number,
+  storageGB?: number, operation?: string,
+): number {
   if (service === 'openai' && model) {
     const p = OPENAI_PRICING[model] ?? OPENAI_PRICING['gpt-4o'];
     return Math.round(
-      ((inputTokens  / 1_000) * p.input  * callsPerMonth * 100) +
-      ((outputTokens / 1_000) * p.output * callsPerMonth * 100)
+      (inputTokens  / 1_000) * p.input  * callsPerMonth * 100 +
+      (outputTokens / 1_000) * p.output * callsPerMonth * 100,
     );
   }
   if (service === 'anthropic' && model) {
     const p = ANTHROPIC_PRICING[model] ?? ANTHROPIC_PRICING['claude-3-5-sonnet'];
     return Math.round(
-      ((inputTokens  / 1_000) * p.input  * callsPerMonth * 100) +
-      ((outputTokens / 1_000) * p.output * callsPerMonth * 100)
+      (inputTokens  / 1_000) * p.input  * callsPerMonth * 100 +
+      (outputTokens / 1_000) * p.output * callsPerMonth * 100,
     );
   }
   if (service === 'aws-lambda') {
-    const calls   = callsPerMonth;
-    const memMB   = 128;
-    const durMs   = 200;
-    const gbSecs  = (memMB / 1_024) * (durMs / 1_000) * calls;
-    const billableReqs   = Math.max(0, calls - 1_000_000);
+    const gbSecs         = (128 / 1_024) * (200 / 1_000) * callsPerMonth;
+    const billableReqs   = Math.max(0, callsPerMonth - 1_000_000);
     const billableGbSecs = Math.max(0, gbSecs - 400_000);
     return Math.round(billableReqs * 0.0000002 * 100 + billableGbSecs * 0.0000166667 * 100);
   }
@@ -65,35 +71,31 @@ function estimateCentsInline(service: string, model: string | undefined, callsPe
     const isWrite  = operation === 'put';
     const storage  = Math.round(gb * 0.023 * 100);
     const requests = isWrite
-      ? Math.round((callsPerMonth / 1_000) * 0.005 * 100)
+      ? Math.round((callsPerMonth / 1_000) * 0.005  * 100)
       : Math.round((callsPerMonth / 1_000) * 0.0004 * 100);
     return storage + requests;
   }
   if (service === 'dynamodb') {
     const perUnit = operation === 'write' ? 0.00000125 : 0.00000025;
     return Math.round(callsPerMonth * perUnit * 100);
   }
-  if (service === 'api-gateway') {
-    return Math.round((callsPerMonth / 1_000_000) * 3.5 * 100);
-  }
-  if (service === 'redis') return 1_224; // cache.t3.micro baseline
+  if (service === 'api-gateway') return Math.round((callsPerMonth / 1_000_000) * 3.5 * 100);
+  if (service === 'redis')       return 1_224;
   return 0;
 }
 
-// ── Route ─────────────────────────────────────────────────────────────────────
+// ── Route ────────────────────────────────────────────────────────────────────
 export async function botRoutes(app: FastifyInstance) {
-  app.post('/api/bot/analyze-pr', async (request: FastifyRequest<{ Body: BotPayload }>, reply) => {
-    const { owner, repo, baseSha, headSha, files } = request.body;
-
-    const token  = process.env.GITHUB_TOKEN || '';
-    const octokit = new Octokit({ auth: token });
+  app.post('/api/bot/analyze-pr', async (
+    request: FastifyRequest<{ Body: BotPayload }>,
+    reply,
+  ) => {
+    const { fileContents = [] } = request.body;
 
     let totalHeadCents = 0;
     let totalBaseCents = 0;
     let inLoop         = 0;
     let handler        = 0;
-    const fetchErrors: string[] = [];
-    const debugLines:  string[] = [];
 
     interface DetectionRow {
       service:    string;
@@ -104,131 +106,109 @@ export async function botRoutes(app: FastifyInstance) {
       inLoop:     boolean;
     }
     const detectionRows: DetectionRow[] = [];
+    const debugLines:    string[]       = [];
 
-    for (const file of files) {
-      if (file.status === 'removed') continue;
+    for (const file of fileContents) {
       const language = getLanguageFromFilename(file.filename);
       if (!language) {
         debugLines.push(`skip (not JS/TS): ${file.filename}`);
         continue;
       }
 
-      // ── Fetch HEAD ─────────────────────────────────────────────────────────
-      let headContent = '';
-      try {
-        const { data } = await octokit.rest.repos.getContent({
-          owner, repo, path: file.filename, ref: headSha,
-        });
-        if ('content' in (data as any) && !Array.isArray(data)) {
-          headContent = Buffer.from((data as any).content, 'base64').toString('utf-8');
-        }
-      } catch (e: any) {
-        fetchErrors.push(`HEAD fetch failed for ${file.filename}: ${e.message}`);
-        debugLines.push(`HEAD fetch error ${file.filename}: ${e.message}`);
-        continue;
-      }
+      const headContent = file.headContent ?? '';
+      const baseContent = file.baseContent ?? '';
 
       if (!headContent.trim()) {
-        debugLines.push(`HEAD content empty for ${file.filename}`);
+        debugLines.push(`empty head content: ${file.filename}`);
         continue;
       }
 
-      // ── Fetch BASE ─────────────────────────────────────────────────────────
-      let baseContent = '';
-      if (file.status !== 'added') {
-        try {
-          const { data } = await octokit.rest.repos.getContent({
-            owner, repo, path: file.filename, ref: baseSha,
-          });
-          if ('content' in (data as any) && !Array.isArray(data)) {
-            baseContent = Buffer.from((data as any).content, 'base64').toString('utf-8');
-          }
-        } catch { /* treat as new file */ }
-      }
-
-      debugLines.push(`analyzing ${file.filename} (${headContent.length} chars, lang=${language})`);
+      debugLines.push(`analyzing: ${file.filename} (${headContent.length} chars, ${language})`);
 
-      // ── AST analysis ───────────────────────────────────────────────────────
-      const headAnalysis = analyzeCode(headContent, language);
-      const baseAnalysis = analyzeCode(baseContent || '', language);
+      // ── AST analysis ────────────────────────────────────────────────────
+      const headA = analyzeCode(headContent, language);
+      const baseA = analyzeCode(baseContent, language);
 
-      debugLines.push(`  head detections: ${headAnalysis.detections.length}`);
-      if (headAnalysis.errors.length) debugLines.push(`  AST errors: ${headAnalysis.errors.join('; ')}`);
+      debugLines.push(`  detections head=${headA.detections.length} base=${baseA.detections.length}`);
+      if (headA.errors.length) debugLines.push(`  AST errors: ${headA.errors.join('; ')}`);
 
-      if (headAnalysis.detections.length === 0) continue;
+      if (headA.detections.length === 0) continue;
 
       const fileHasLoop = /for\s*\(|while\s*\(|\.forEach\s*\(|\.map\s*\(/.test(headContent);
       if (fileHasLoop) inLoop += 1;
       handler += 1;
 
-      // ── Compute costs inline (no Redis) ────────────────────────────────────
+      // ── Cost calculation ─────────────────────────────────────────────────
       let fileHeadCents = 0;
       let fileBaseCents = 0;
 
-      for (const d of headAnalysis.detections) {
-        const cents = estimateCentsInline(
-          d.service, d.model, d.callsPerMonth ?? 10_000,
-          d.inputTokens ?? 500, d.outputTokens ?? 1_000,
+      for (const d of headA.detections) {
+        const cents = estimateCents(
+          d.service, d.model,
+          d.callsPerMonth ?? 10_000,
+          d.inputTokens   ?? 500,
+          d.outputTokens  ?? 1_000,
           d.storageGB, d.operation,
         );
         fileHeadCents += cents;
-
         detectionRows.push({
-          service:   d.service,
-          model:     d.model,
-          snippet:   d.snippet,
-          headCents: cents,
-          deltaCents: 0, // filled in below
-          inLoop:    fileHasLoop,
+          service:    d.service,
+          model:      d.model,
+          snippet:    d.snippet,
+          headCents:  cents,
+          deltaCents: 0,          // filled below
+          inLoop:     fileHasLoop,
         });
       }
 
-      for (const d of baseAnalysis.detections) {
-        fileBaseCents += estimateCentsInline(
-          d.service, d.model, d.callsPerMonth ?? 10_000,
-          d.inputTokens ?? 500, d.outputTokens ?? 1_000,
+      for (const d of baseA.detections) {
+        fileBaseCents += estimateCents(
+          d.service, d.model,
+          d.callsPerMonth ?? 10_000,
+          d.inputTokens   ?? 500,
+          d.outputTokens  ?? 1_000,
           d.storageGB, d.operation,
         );
       }
 
       totalHeadCents += fileHeadCents;
       totalBaseCents += fileBaseCents;
 
-      // Distribute delta proportionally across detections in this file
+      // Distribute file delta proportionally across detections
       const fileDelta = fileHeadCents - fileBaseCents;
-      const startIdx  = detectionRows.length - headAnalysis.detections.length;
+      const startIdx  = detectionRows.length - headA.detections.length;
       for (let i = startIdx; i < detectionRows.length; i++) {
         const share = fileHeadCents > 0 ? detectionRows[i].headCents / fileHeadCents : 0;
         detectionRows[i].deltaCents = Math.round(fileDelta * share);
       }
     }
 
     // ── Build markdown ────────────────────────────────────────────────────────
-    const totalDelta   = totalHeadCents - totalBaseCents;
-    const fmt          = (c: number) => `$${(Math.abs(c) / 100).toLocaleString('en-US', { minimumFractionDigits: 2 })}`;
-    const sign         = (c: number) => c > 0 ? '+' : c < 0 ? '-' : '';
+    const totalDelta     = totalHeadCents - totalBaseCents;
+    const fmt            = (c: number) => `$${(Math.abs(c) / 100).toLocaleString('en-US', { minimumFractionDigits: 2 })}`;
+    const sign           = (c: number) => c > 0 ? '+' : c < 0 ? '-' : '';
     const uniqueServices = [...new Set(detectionRows.map(r => r.service))];
 
-    let criticalityBadge = '🟢 **Criticality: Low**';
-    let qualityStatement = '';
+    let critBadge   = '🟢 **Criticality: Low**';
+    let qualityNote = '';
     if (inLoop > 0) {
-      criticalityBadge = '🔴 **Criticality: Major**';
-      qualityStatement = '\n> ⚠️ **CRITICAL:** Cloud API calls detected inside a loop. Costs scale with every iteration — consider batching.\n';
+      critBadge   = '🔴 **Criticality: Major**';
+      qualityNote = '\n> ⚠️ **CRITICAL:** Cloud API calls inside a loop — costs scale with every iteration. Consider batching.\n';
     } else if (totalHeadCents > 5_000) {
-      criticalityBadge = '🟡 **Criticality: Minor**';
-      qualityStatement = '\n> 💡 Significant cloud costs detected. Ensure these align with your budget.\n';
+      critBadge   = '🟡 **Criticality: Minor**';
+      qualityNote = '\n> 💡 Significant cloud costs detected. Verify these align with your budget.\n';
     }
 
     let md = `## 📊 CloudGauge Cost Impact Analysis\n\n`;
-    md += `### 💰 ESTIMATED MONTHLY COST DELTA\n`;
-    md += `# **${sign(totalDelta)}${fmt(totalDelta)}/mo**\n`;
-    md += `${criticalityBadge}\n\n`;
-    md += `> Total cloud cost **in changed files**: **${fmt(totalHeadCents)}/mo**`;
+    md    += `### 💰 ESTIMATED MONTHLY COST DELTA\n`;
+    md    += `# **${sign(totalDelta)}${fmt(totalDelta)}/mo**\n`;
+    md    += `${critBadge}\n\n`;
+    md    += `> Total cloud cost **in changed files**: **${fmt(totalHeadCents)}/mo**`;
     if (totalBaseCents > 0) md += ` *(was ${fmt(totalBaseCents)}/mo before this PR)*`;
-    md += `\n\n`;
-    md += `*Detected **${detectionRows.length}** cloud API call(s) across **${uniqueServices.length}** service(s).*\n`;
-    md += qualityStatement + '\n';
-    md += `---\n\n`;
+    md    += `\n\n`;
+    md    += `*Detected **${detectionRows.length}** cloud API call(s) across **${uniqueServices.length}** service(s).*\n`;
+    md    += qualityNote + '\n';
+    md    += `---\n\n`;
 
     md += `### ⚙️ EXECUTION CONTEXT IMPACT\n`;
     md += `| 🔄 In Loop | 🌐 Handler | ⏱️ Scheduled | 📦 Batch | 📌 Direct |\n`;
@@ -243,18 +223,14 @@ export async function botRoutes(app: FastifyInstance) {
       for (const row of detectionRows) {
         const label = row.model ? `**${row.service}** \`${row.model}\`` : `**${row.service}**`;
         const badge = row.inLoop ? ' 🔄' : '';
-        const delta = row.deltaCents !== 0 ? `**${sign(row.deltaCents)}${fmt(row.deltaCents)}/mo**` : `*(existing)*`;
+        const delta = row.deltaCents !== 0
+          ? `**${sign(row.deltaCents)}${fmt(row.deltaCents)}/mo**`
+          : `*(existing)*`;
         md += `| ${label}${badge} | \`${row.snippet.slice(0, 70)}\` | **${fmt(row.headCents)}/mo** | ${delta} |\n`;
       }
     } else {
       md += `*No cloud API calls detected in the changed files.*\n`;
-      if (fetchErrors.length > 0) {
-        md += `\n> ⚠️ **File fetch errors** (check GITHUB\\_TOKEN permissions):\n`;
-        for (const e of fetchErrors) md += `> - \`${e}\`\n`;
-      }
-      if (debugLines.length > 0) {
-        md += `\n<details><summary>🔍 Debug Info</summary>\n\n\`\`\`\n${debugLines.join('\n')}\n\`\`\`\n</details>\n`;
-      }
+      md += `\n<details><summary>🔍 Debug Info</summary>\n\n\`\`\`\n${debugLines.join('\n')}\n\`\`\`\n</details>\n`;
     }
 
     md += `\n\n> *Powered by SentinelEngine CodeReview Bot.*`;