updated tests to match new PhpUnit v12 standards

Author: Sengorius

tests/Fixtures/DummyEntityRepository.php

@@ -0,0 +1,24 @@
+<?php
+
+namespace SkriptManufaktur\SimpleRestBundle\Tests\Fixtures;
+
+use Doctrine\Bundle\DoctrineBundle\Repository\ServiceEntityRepository;
+use Doctrine\Persistence\ManagerRegistry;
+
+class DummyEntityRepository extends ServiceEntityRepository
+{
+    public function __construct(ManagerRegistry $registry)
+    {
+        parent::__construct($registry, EmbeddedDummyEntity::class);
+    }
+
+    public function getOneFromId(int $id): EmbeddedDummyEntity
+    {
+        return new EmbeddedDummyEntity()->setId($id);
+    }
+
+    public function getOneFromUuid(string $uuid): EmbeddedUuidDummyEntity
+    {
+        return new EmbeddedUuidDummyEntity()->setId($uuid);
+    }
+}

tests/Middleware/ApiBusWrapperTest.php

@@ -282,7 +282,7 @@ public function testCheckMessageResultWithProxyClassNotAllowed(): void
     private function createApiBusWrapper(object $message, array $stamps = []): ApiBusWrapper
     {
         $envelope = Envelope::wrap($message, $stamps);
-        $messageBus = $this->createMock(MessageBusInterface::class);
+        $messageBus = $this->createStub(MessageBusInterface::class);
         $messageBus->method('dispatch')
             ->with($message, $stamps)
             ->willReturn($envelope)

tests/Normalizer/EntityIdNormalizerTest.php

@@ -23,22 +23,22 @@ protected function setUp(): void
         parent::setUp();
 
         $this->embeddeds = [
-            (new EmbeddedDummyEntity())
+            new EmbeddedDummyEntity()
                 ->setId(3)
                 ->setType('t1')
                 ->setActive(true)
             ,
-            (new EmbeddedDummyEntity())
+            new EmbeddedDummyEntity()
                 ->setId(4)
                 ->setType('t2')
                 ->setActive(true)
             ,
-            (new EmbeddedDummyEntity())
+            new EmbeddedDummyEntity()
                 ->setId(5)
                 ->setType('t3')
                 ->setActive(true)
             ,
-            (new EmbeddedDummyEntity())
+            new EmbeddedDummyEntity()
                 ->setId(6)
                 ->setType('t1')
                 ->setActive(false)
@@ -160,8 +160,8 @@ public function testWithDifferentClassMapMethod(): void
             'created' => '2022-08-20 14:20:54',
         ];
 
-        $result = $this->createIdSerializer('getOne')->denormalize($data, DummyEntity::class, null, [
-            EntityIdDenormalizer::CLASS_MAP => [EmbeddedDummyEntity::class => 'getOne'],
+        $result = $this->createIdSerializer('getOneFromId')->denormalize($data, DummyEntity::class, null, [
+            EntityIdDenormalizer::CLASS_MAP => [EmbeddedDummyEntity::class => 'getOneFromId'],
         ]);
 
         static::assertInstanceOf(DummyEntity::class, $result);

tests/Normalizer/EntityUuidNormalizerTest.php

@@ -23,22 +23,22 @@ protected function setUp(): void
         parent::setUp();
 
         $this->embeddeds = [
-            (new EmbeddedUuidDummyEntity())
+            new EmbeddedUuidDummyEntity()
                 ->setId('56c190d2-c864-43c5-8c2a-61092b2474c6')
                 ->setType('t1')
                 ->setActive(true)
             ,
-            (new EmbeddedUuidDummyEntity())
+            new EmbeddedUuidDummyEntity()
                 ->setId('a92fb3c0-5132-4ed7-96e3-b917dbabf681')
                 ->setType('t2')
                 ->setActive(true)
             ,
-            (new EmbeddedUuidDummyEntity())
+            new EmbeddedUuidDummyEntity()
                 ->setId('6e6e7d62-f2f3-4414-9da9-01e1768da6ea')
                 ->setType('t3')
                 ->setActive(true)
             ,
-            (new EmbeddedUuidDummyEntity())
+            new EmbeddedUuidDummyEntity()
                 ->setId('f079b6da-3f5c-4655-850c-abd7ab22d65d')
                 ->setType('t1')
                 ->setActive(false)
@@ -164,8 +164,8 @@ public function testWithDifferentClassMapMethod(): void
             'created' => '2022-08-20 14:20:54',
         ];
 
-        $result = $this->createUuidSerializer('getOne')->denormalize($data, DummyEntity::class, null, [
-            EntityUuidDenormalizer::CLASS_MAP => [EmbeddedUuidDummyEntity::class => 'getOne'],
+        $result = $this->createUuidSerializer('getOneFromUuid')->denormalize($data, DummyEntity::class, null, [
+            EntityUuidDenormalizer::CLASS_MAP => [EmbeddedUuidDummyEntity::class => 'getOneFromUuid'],
         ]);
 
         static::assertInstanceOf(DummyEntity::class, $result);

tests/Normalizer/SerializerMockingTrait.php

@@ -2,11 +2,11 @@
 
 namespace SkriptManufaktur\SimpleRestBundle\Tests\Normalizer;
 
-use Doctrine\ORM\EntityRepository;
 use Doctrine\Persistence\ManagerRegistry;
 use Doctrine\Persistence\ObjectManager;
 use SkriptManufaktur\SimpleRestBundle\Component\EntityIdDenormalizer;
 use SkriptManufaktur\SimpleRestBundle\Component\EntityUuidDenormalizer;
+use SkriptManufaktur\SimpleRestBundle\Tests\Fixtures\DummyEntityRepository;
 use SkriptManufaktur\SimpleRestBundle\Tests\Fixtures\EmbeddedDummyEntity;
 use SkriptManufaktur\SimpleRestBundle\Tests\Fixtures\EmbeddedUuidDummyEntity;
 use Symfony\Component\PropertyInfo\Extractor\ReflectionExtractor;
@@ -65,28 +65,26 @@ private function createUuidSerializer(string $hydrationMethod): Serializer
 
     private function createManagerRegistry(string $hydratingMethod, string $className, callable $repoCallback): ManagerRegistry
     {
-        $repository = $this->getMockBuilder(EntityRepository::class)
+        $repository = $this->getStubBuilder(DummyEntityRepository::class)
             ->disableOriginalConstructor()
             ->disableOriginalClone()
-            ->disableArgumentCloning()
-            ->onlyMethods(['find', 'findAll'])
-            ->addMethods(['getOne'])
-            ->getMock()
+            ->onlyMethods(['find', 'findAll', 'getOneFromId', 'getOneFromUuid'])
+            ->getStub()
         ;
 
         $repository
             ->method($hydratingMethod)
             ->willReturnCallback($repoCallback)
         ;
 
-        $objManager = $this->createMock(ObjectManager::class);
+        $objManager = $this->createStub(ObjectManager::class);
         $objManager
             ->method('getRepository')
             ->with($className)
             ->willReturn($repository)
         ;
 
-        $registry = $this->createMock(ManagerRegistry::class);
+        $registry = $this->createStub(ManagerRegistry::class);
         $registry
             ->method('getManagerForClass')
             ->with($className)

tests/Unit/EntityFactoryTest.php

@@ -338,7 +338,7 @@ public function testAddInvalidBoolSearch(): void
 
     private function createQueryBuilder(): QueryBuilder
     {
-        $emMock = self::createMock(EntityManagerInterface::class);
+        $emMock = $this->createStub(EntityManagerInterface::class);
 
         $qb = new QueryBuilder($emMock);
         $qb->select('t')->from('DummyUser', 't');
@@ -348,7 +348,7 @@ private function createQueryBuilder(): QueryBuilder
 
     private function createFactoryWrapper(): ServiceEntityFactory
     {
-        $mrMock = self::createMock(ManagerRegistry::class);
+        $mrMock = $this->createStub(ManagerRegistry::class);
 
         return new class($mrMock, DummyEntity::class) extends ServiceEntityFactory
         {

tests/Unit/ValidationPreparationTest.php

@@ -3,6 +3,7 @@
 namespace SkriptManufaktur\SimpleRestBundle\Tests\Unit;
 
 use Generator;
+use PHPUnit\Framework\Attributes\DataProvider;
 use PHPUnit\Framework\TestCase;
 use SkriptManufaktur\SimpleRestBundle\Validation\ValidationPreparationTrait;
 
@@ -11,13 +12,7 @@ class ValidationPreparationTest extends TestCase
     use ValidationPreparationTrait;
 
 
-    /**
-     * @dataProvider validationProvider
-     *
-     * @param string $propertyPath
-     * @param string $finishedPropertyPath
-     * @param array  $result
-     */
+    #[DataProvider('validationProvider')]
     public function testCreation(string $propertyPath, string $finishedPropertyPath, array $result): void
     {
         $violations = [];

tests/Voter/DefaultVoterTest.php

@@ -3,6 +3,7 @@
 namespace SkriptManufaktur\SimpleRestBundle\Tests\Voter;
 
 use Exception;
+use PHPUnit\Framework\Attributes\CoversClass;
 use PHPUnit\Framework\TestCase;
 use SkriptManufaktur\SimpleRestBundle\Tests\Fixtures\DefaultVoter;
 use SkriptManufaktur\SimpleRestBundle\Tests\Fixtures\DummyMessage;
@@ -12,6 +13,7 @@
 use Symfony\Component\Security\Core\Authentication\Token\TokenInterface;
 use Symfony\Component\Security\Core\Authorization\AccessDecisionManager;
 
+#[CoversClass(GrantingStamp::class)]
 class DefaultVoterTest extends TestCase
 {
     private TokenInterface $token;
@@ -22,7 +24,7 @@ protected function setUp(): void
     {
         parent::setUp();
 
-        $this->token = $this->createMock(TokenInterface::class);
+        $this->token = $this->createStub(TokenInterface::class);
         $this->manager = new AccessDecisionManager([new DefaultVoter(), new DummyVoter()]);
     }
 

tests/Voter/GrantingVoterTest.php

@@ -2,6 +2,7 @@
 
 namespace SkriptManufaktur\SimpleRestBundle\Tests\Voter;
 
+use PHPUnit\Framework\Attributes\CoversClass;
 use PHPUnit\Framework\TestCase;
 use SkriptManufaktur\SimpleRestBundle\Tests\Fixtures\DefaultVoter;
 use SkriptManufaktur\SimpleRestBundle\Tests\Fixtures\DummyMessage;
@@ -12,6 +13,7 @@
 use Symfony\Component\Security\Core\Authorization\AccessDecisionManager;
 use Symfony\Component\Security\Core\Authorization\Voter\VoterInterface;
 
+#[CoversClass(GrantingStamp::class)]
 class GrantingVoterTest extends TestCase
 {
     private TokenInterface $token;
@@ -23,7 +25,7 @@ protected function setUp(): void
     {
         parent::setUp();
 
-        $this->token = $this->createMock(TokenInterface::class);
+        $this->token = $this->createStub(TokenInterface::class);
         $this->grantingVoter = new DummyVoter();
         $this->manager = new AccessDecisionManager([$this->grantingVoter, new DefaultVoter()]);
     }