Skip to content

Commit 44c214c

Browse files
authored
fix hwToGpuKey missing -dgxc-slurm suffix — silently dropped DGXC Slurm benchmark rows (#55)
1 parent a23d0c7 commit 44c214c

3 files changed

Lines changed: 8 additions & 1 deletion

File tree

docs/adding-entities.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -89,7 +89,7 @@ Present what you inferred and ask about anything not visible in artifacts:
8989
4. What are the **cost rates** in $/GPU/hr? (hyperscaler, neocloud, 3-year rental)
9090
5. Which **framework variants** will run on it? (e.g. `sglang`, `trt`, `dynamo-trt`, `vllm`, with/without `mtp`)
9191
6. Where should it **sort** relative to existing GPUs in legends?
92-
7. Are there any **new artifact suffixes** for this GPU beyond the existing ones (`-trt`, `-nv`, `-amds`, `-amd`, `-nvd`, `-nvs`, `-disagg`, `-multinode-slurm`, `-dgxc`, `-nb`)?
92+
7. Are there any **new artifact suffixes** for this GPU beyond the existing ones (`-trt`, `-nv`, `-amds`, `-amd`, `-nvd`, `-nvs`, `-disagg`, `-multinode-slurm`, `-dgxc-slurm`, `-dgxc`, `-nb`)?
9393
8. Do you have the **full hardware specs** for the GPU Specs tab? (memory GB, memory bandwidth TB/s, FP4/FP8/BF16 TFLOPS, interconnect tech, scale-up bandwidth, NIC model, scale-out topology)
9494

9595
### Then apply

packages/db/src/etl/normalizers.test.ts

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -58,6 +58,12 @@ describe('hwToGpuKey', () => {
5858
expect(hwToGpuKey('gb200-dgxc')).toBe('gb200');
5959
});
6060

61+
it('strips -dgxc-slurm suffix', () => {
62+
expect(hwToGpuKey('b200-dgxc-slurm')).toBe('b200');
63+
expect(hwToGpuKey('h200-dgxc-slurm')).toBe('h200');
64+
expect(hwToGpuKey('h100-dgxc-slurm')).toBe('h100');
65+
});
66+
6167
it('strips -nb suffix', () => {
6268
expect(hwToGpuKey('b300-nb')).toBe('b300');
6369
});

packages/db/src/etl/normalizers.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -31,6 +31,7 @@ export function hwToGpuKey(hw: string): string | null {
3131
.replace(/-amds$/, '')
3232
.replace(/-amd$/, '')
3333
.replace(/-nvd$/, '')
34+
.replace(/-dgxc-slurm$/, '')
3435
.replace(/-dgxc$/, '')
3536
.replace(/-nb$/, '')
3637
.replace(/-nv$/, '');

0 commit comments

Comments
 (0)