Skip to content

Commit 12bc234

Browse files
committed
fix(release): use CI environment for R2 secrets and add --remote flag
- Add environment: CI to release job to access Cloudflare secrets - Add --remote flag to wrangler commands to fail explicitly if credentials missing (previously silently uploaded to local emulator when secrets were empty)
1 parent 8a5ad11 commit 12bc234

1 file changed

Lines changed: 4 additions & 3 deletions

File tree

.github/workflows/release.yml

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -122,6 +122,7 @@ jobs:
122122
name: Create Release & Upload to R2
123123
needs: build
124124
runs-on: ubuntu-latest
125+
environment: CI
125126
steps:
126127
- uses: actions/checkout@v4
127128

@@ -170,7 +171,7 @@ jobs:
170171
for file in release/*; do
171172
filename=$(basename "$file")
172173
echo "Uploading $filename to releases/$VERSION/$filename"
173-
wrangler r2 object put "semfora-releases/$VERSION/$filename" --file="$file"
174+
wrangler r2 object put "semfora-releases/$VERSION/$filename" --file="$file" --remote
174175
done
175176
176177
- name: Update latest symlink on R2
@@ -182,7 +183,7 @@ jobs:
182183
183184
# Upload version.txt to latest/
184185
echo "$VERSION" > latest-version.txt
185-
wrangler r2 object put "semfora-releases/latest/version.txt" --file="latest-version.txt"
186+
wrangler r2 object put "semfora-releases/latest/version.txt" --file="latest-version.txt" --remote
186187
187188
# Copy all release files to latest/ directory
188189
for file in release/*.tar.gz release/*.zip release/*.sha256; do
@@ -192,7 +193,7 @@ jobs:
192193
# e.g., semfora-engine-1.0.0-linux-x86_64.tar.gz -> semfora-engine-linux-x86_64.tar.gz
193194
latest_filename=$(echo "$filename" | sed "s/-$VERSION//")
194195
echo "Uploading to latest/$latest_filename"
195-
wrangler r2 object put "semfora-releases/latest/$latest_filename" --file="$file"
196+
wrangler r2 object put "semfora-releases/latest/$latest_filename" --file="$file" --remote
196197
fi
197198
done
198199

0 commit comments

Comments
 (0)