Merge pull request #253 from Seluj78/removed-todos

Removed all TODOs (Moved to issues)

Author: Seluj78

.travis.yml

@@ -11,8 +11,6 @@ services:
   - mysql
   - redis
 
-# TODO: Reformat file as it is ugly. separatee jobs in yml, and lint as the last job to run
-
 jobs:
   include:
     - stage: build

backend/PyMatcha/routes/api/auth/password.py

@@ -38,8 +38,6 @@
 
 auth_password_bp = Blueprint("auth_password", __name__)
 
-# TODO: Test to reset password in postman
-
 
 @auth_password_bp.route("/auth/password/forgot", methods=["POST"])
 @validate_params(REQUIRED_KEYS_PASSWORD_FORGOT)

backend/PyMatcha/routes/api/like.py

@@ -36,7 +36,6 @@ def like_profile(uid):
         superlike_counter = int(redis.get(f"superlikes:{current_user.id}"))
         if superlike_counter <= 0:
             set_user_superlikes.apply_async(current_user.id, amount=5, eta=86400)
-            # TODO: Test this in postman
             raise BadRequestError("No more superlikes today !", "Try later")
         else:
             redis.decr(f"superlikes:{current_user.id}")

backend/PyMatcha/routes/api/messages.py

@@ -77,7 +77,6 @@ def send_message():
 @messages_bp.route("/conversations/<with_uid>", methods=["GET"])
 @jwt_required
 def get_conversation_messsages(with_uid):
-    # TODO: Limit to 200 messages and if need be get more
     try:
         with_user = get_user(with_uid)
     except NotFoundError:

backend/PyMatcha/utils/orm/_model.py

@@ -216,8 +216,6 @@ def delete(self):
             logging.fatal("{} Not in table {}".format(self.id, self.table_name))
             raise Exception("{} Not in table {}".format(self.id, self.table_name))
 
-    # TODO: Consolidate get, get_multi and get_multis in one function !
-
     @classmethod
     def get(cls, **kwargs):
         """
@@ -301,7 +299,6 @@ def get_multi(cls, **kwargs):
         if data:
             return cls(data)
         else:
-            # TODO: All db gets return None instead of valuerror
             raise ValueError("Not found.")
 
     @classmethod

backend/PyMatcha/utils/populate_database.py

@@ -89,7 +89,6 @@ def populate_users(amount=150, drop_user_table=False):
                 Tag.create(name=tag, user_id=u.id)
         except ConflictError:
             pass  # Pass on the conflict error, this user wont be created because the username is taken. Who cares ?
-    # TODO: Add images
 
 
 if __name__ == "__main__":

backend/PyMatcha/utils/tables.py

@@ -150,7 +150,6 @@ def _create_matches_table(db):
         ) CHARACTER SET utf8mb4 COLLATE utf8mb4_0900_ai_ci ;
         """
         )
-        # TODO: Is conversation started boolean ?
         c.execute(ENABLE_SQL_NOTES)
         c.close()
 

backend/PyMatcha/utils/tasks.py

@@ -37,11 +37,9 @@ def update_heat_scores():
             score += 100
         score += likes_received * 2
         score += matches * 4
-        # TODO: Superlike received = 5 pts
         score -= reports_received * 10
         score += views
         score += ceil(messages / 5)
-        # TODO: remove 10 pts per week of inactivity
         user.heat_score = score
         user.save()
         return f"Updated heat score for user {user.id}: {user.heat_score}."
@@ -68,7 +66,6 @@ def update_offline_users():
                 # Edge case where the user has been deleted from DB while he was still online
                 pass
             else:
-                # TODO: array of id and one DB call to update the db as offline
                 u.date_lastseen = datetime.datetime.fromtimestamp(date_lastseen)
                 u.is_online = False
                 u.save()
@@ -110,7 +107,6 @@ def update_user_recommendations():
     for user_to_update in User.select_all():
         count += 1
         user_to_update_recommendations = []
-        # TODO: Find a way to bypass that
         if not user_to_update.birthdate:
             continue
         if not user_to_update.geohash:

backend/schemas/swagger.yaml

@@ -10,10 +10,6 @@ info:
     name: GNU GPL 3
     url: https://github.com/Seluj78/PyMatcha/blob/dev/LICENSE
 
-# TODO: Email and password once rewritten with new frontend
-# TODO: https://swagger.io/docs/specification/links/
-# TODO: https://stackoverflow.com/questions/47447403/how-to-define-different-responses-for-same-http-status-code-in-openapi-swagger
-
 tags:
   - name: Authentication
     description: Login and register routes
@@ -1302,7 +1298,6 @@ components:
         details:
           type: string
           example: He spammed me of dick pics
-    # TODO: Add descriptions
     User:
       type: object
       properties:
@@ -1616,7 +1611,6 @@ components:
           type: string
           example: 1
           description: The user id who received the message
-    # TODO: Add descriptions
     Recommendation:
       type: object
       properties: