Skip to content

Commit 245b2f4

Browse files
committed
run Gradle tests on GA as well
until now, we executed only Maven tests. As a result, build.gradle was outdated.
1 parent 15f86d8 commit 245b2f4

2 files changed

Lines changed: 7 additions & 2 deletions

File tree

.github/workflows/java-examples.yml

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -65,6 +65,7 @@ jobs:
6565
command: |
6666
cd examples/java
6767
mvn -B test -D"jdk.internal.httpclient.disableHostnameVerification=true"
68+
./gradlew test --tests 'dev.selenium.*UsingSeleniumTest'
6869
- name: Run Tests Nightly Linux/macOS
6970
if: matrix.release == 'nightly' && matrix.os != 'windows'
7071
uses: nick-invision/retry@v3.0.2
@@ -84,6 +85,7 @@ jobs:
8485
echo "Using selenium.version $new_version for tests"
8586
cd examples/java
8687
mvn -B -U test -D"jdk.internal.httpclient.disableHostnameVerification=true" -Dselenium.version=$new_version
88+
./gradlew "-Dselenium.version=$new_version" test --tests 'dev.selenium.*UsingSeleniumTest'
8789
fi
8890
- name: Run Tests Nightly Windows
8991
if: matrix.release == 'nightly' && matrix.os == 'windows'
@@ -104,6 +106,7 @@ jobs:
104106
Write-Output "Using selenium.version $new_version for tests"
105107
cd examples/java
106108
mvn -B -U test "-Djdk.internal.httpclient.disableHostnameVerification=true" "-Dselenium.version=$new_version"
109+
./gradlew "-Dselenium.version=$new_version" test --tests 'dev.selenium.*UsingSeleniumTest'
107110
}
108111
- name: Upload test report
109112
uses: actions/upload-artifact@v6

examples/java/build.gradle

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -9,9 +9,11 @@ repositories {
99
mavenCentral()
1010
}
1111

12+
ext['seleniumVersion'] = System.getProperty('selenium.version', '4.40.0')
13+
1214
dependencies {
13-
testImplementation 'org.seleniumhq.selenium:selenium-java:4.40.0'
14-
testImplementation 'org.seleniumhq.selenium:selenium-grid:4.40.0'
15+
testImplementation "org.seleniumhq.selenium:selenium-java:${seleniumVersion}"
16+
testImplementation "org.seleniumhq.selenium:selenium-grid:${seleniumVersion}"
1517
testImplementation platform("org.junit:junit-bom:6.0.2")
1618
testImplementation 'org.junit.jupiter:junit-jupiter-engine'
1719
testRuntimeOnly 'org.junit.platform:junit-platform-launcher'

0 commit comments

Comments
 (0)