Skip to content

SPI.begin() call in mcp2518fd::begin causes problems for other platforms #158

@NPoole

Description

@NPoole

I'm compiling this library for ESP32 and it seems to work great, but only once the call to SPI.begin() at line 59 in mcp2518fd_can.cpp is removed. This is because on my platform, I need to call SPI.begin() before passing the SPIClass to your library (so that I can assign the pins on the ESP32's GPIO matrix) and when I then call mcp2518fd::begin, the duplicate "SPI.begin()" call blows away my config.

I understand this library doesn't explicitly support my application, but adding the ability to pass optional SPI pin assignments to mcp2518fd::begin would make this excellent library useful to a lot of people. In the meantime, I'm happy to use my fork.

Thank you!

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type
    No fields configured for issues without a type.

    Projects

    Status

    No status

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions