Skip to content

Commit 470d86b

Browse files
authored
update.version.sh: remove broken reference, skip most CI on PRs that only modify update-version.sh (rapidsai#875)
While reviewing rapidsai#805, I found an issue with this project's `update-version.sh`... it refers to a script `examples/cmake/thirdparty/fetch_rapids.cmake` which no long exists (removed in rapidsai#824). This proposes the following: * removing that reference from `update-version.sh` * skipping most CI on PRs that only modify `update-version.sh` ## Notes for Reviewers `ci/release/update-version.sh` is standardized (same filepath, same usage) across almost all RAPIDS repos. I cannot think of a situation where a PR that only changes that file would need to have any CI re-run (other than linting, e.g. for `shellcheck`). If folks agree, I'll roll out a change like that more broadly across RAPIDS. Authors: - James Lamb (https://github.com/jameslamb) - Ben Frederickson (https://github.com/benfred) Approvers: - Ben Frederickson (https://github.com/benfred) - Corey J. Nolet (https://github.com/cjnolet) - Gil Forsyth (https://github.com/gforsyth) URL: rapidsai#875
1 parent 3c303a0 commit 470d86b

2 files changed

Lines changed: 3 additions & 2 deletions

File tree

.github/workflows/pr.yaml

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -67,6 +67,7 @@ jobs:
6767
- '!.devcontainer/**'
6868
- '!.pre-commit-config.yaml'
6969
- '!README.md'
70+
- '!ci/release/update-version.sh'
7071
- '!docs/**'
7172
- '!img/**'
7273
- '!notebooks/**'
@@ -90,6 +91,7 @@ jobs:
9091
- '**'
9192
- '!.devcontainer/**'
9293
- '!.pre-commit-config.yaml'
94+
- '!ci/release/update-version.sh'
9395
- '!README.md'
9496
- '!rust/**'
9597
- '!go/**'
@@ -98,6 +100,7 @@ jobs:
98100
- '**'
99101
- '!.devcontainer/**'
100102
- '!.pre-commit-config.yaml'
103+
- '!ci/release/update-version.sh'
101104
- '!README.md'
102105
- '!docs/**'
103106
- '!img/**'

ci/release/update-version.sh

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -36,8 +36,6 @@ function sed_runner() {
3636
sed -i.bak ''"$1"'' "$2" && rm -f "${2}".bak
3737
}
3838

39-
sed_runner "s/set(RAPIDS_VERSION .*)/set(RAPIDS_VERSION \"${NEXT_SHORT_TAG}\")/g" examples/cmake/thirdparty/fetch_rapids.cmake
40-
4139
# Centralized version file update
4240
echo "${NEXT_FULL_TAG}" > VERSION
4341

0 commit comments

Comments
 (0)