Commit 470d86b
authored
update.version.sh: remove broken reference, skip most CI on PRs that only modify update-version.sh (rapidsai#875)
While reviewing rapidsai#805, I found an issue with this project's `update-version.sh`... it refers to a script `examples/cmake/thirdparty/fetch_rapids.cmake` which no long exists (removed in rapidsai#824).
This proposes the following:
* removing that reference from `update-version.sh`
* skipping most CI on PRs that only modify `update-version.sh`
## Notes for Reviewers
`ci/release/update-version.sh` is standardized (same filepath, same usage) across almost all RAPIDS repos. I cannot think of a situation where a PR that only changes that file would need to have any CI re-run (other than linting, e.g. for `shellcheck`).
If folks agree, I'll roll out a change like that more broadly across RAPIDS.
Authors:
- James Lamb (https://github.com/jameslamb)
- Ben Frederickson (https://github.com/benfred)
Approvers:
- Ben Frederickson (https://github.com/benfred)
- Corey J. Nolet (https://github.com/cjnolet)
- Gil Forsyth (https://github.com/gforsyth)
URL: rapidsai#8751 parent 3c303a0 commit 470d86b
2 files changed
Lines changed: 3 additions & 2 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
67 | 67 | | |
68 | 68 | | |
69 | 69 | | |
| 70 | + | |
70 | 71 | | |
71 | 72 | | |
72 | 73 | | |
| |||
90 | 91 | | |
91 | 92 | | |
92 | 93 | | |
| 94 | + | |
93 | 95 | | |
94 | 96 | | |
95 | 97 | | |
| |||
98 | 100 | | |
99 | 101 | | |
100 | 102 | | |
| 103 | + | |
101 | 104 | | |
102 | 105 | | |
103 | 106 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
36 | 36 | | |
37 | 37 | | |
38 | 38 | | |
39 | | - | |
40 | | - | |
41 | 39 | | |
42 | 40 | | |
43 | 41 | | |
| |||
0 commit comments