Default values for custom properties do not apply

[TheEidj]

Unity 6.2
Tiled 1.11.2
ST2U 2.4.0

Hi Seanba !
Something that used to work doesn't seem to work anymore.
I tried on a fresh new instance to be sure and yet not chance :

On Tiled, I create this class "HiddenZone" with default values in its properties

Back into Unity, I refresh the properties and everything seems ok

But then, when importing the TiledMap, none of those properties seems to apply

What is really odd is that old classes having default properties as well import normally with every SuperCustomProperties set with default value.

I am quite confused about this issue and I would gladly have your opinion on this !
Thanks !

[TheEidj]

Ok, I think I get it.
Since it's only with Tiled tile layers, I went and checked the code.
Unlike SuperObjectLayer, the notion of class (m_Type) is not present in SuperTileLayer. So when importing a tile layer, we do not retrieve its class and AddSuperCustomProperties is called once in TmxAssetImporter.TileLayer without any type, adding only the properties overriden in Tiled.

Is this behaviour on purpose ? Or classes were not implemented on tile layers back then ?

[TheEidj]

Adding this
layer.m_Type = Xml.GetAttributeAs("class", "");
in the SuperLayerLoader.cs
And using it here
AddSuperCustomProperties(layerComponent.gameObject, xLayer.Element("properties"), layerComponent.m_Type);
in the TmxAssetImporter.TileLayer.cs
seems to do the job

[seanb-22ct]

Thanks, @TheEidj. This is probably the right fix and should also should be applied to other layer types (Object Layer and Image Layer). I'll make this a part of the next release.