Instances of TargetStateAndStatusV2Msg and TargetStateAndStatusV1Msg are only distinguishable by using instanceof, but not by their type (ModeSDownlinkMsg#getType()).
In #39, V1 was introduced and the existing class was renamed to V2.
However, both classes use type ADSB_TARGET_STATE_AND_STATUS and their version is indistinguishable using this method of dispatching.
This is against the convention, e.g. for surface position messages there is a V0, V1 and V2 constant.
This is a breaking change, because
- it will remove
ADSB_TARGET_STATE_AND_STATUS
- it will add new constants, that must be properly handled
Instances of
TargetStateAndStatusV2MsgandTargetStateAndStatusV1Msgare only distinguishable by usinginstanceof, but not by their type (ModeSDownlinkMsg#getType()).In #39, V1 was introduced and the existing class was renamed to V2.
However, both classes use type
ADSB_TARGET_STATE_AND_STATUSand their version is indistinguishable using this method of dispatching.This is against the convention, e.g. for surface position messages there is a
V0,V1andV2constant.This is a breaking change, because
ADSB_TARGET_STATE_AND_STATUS