Skip to content

Commit 807e8a9

Browse files
Merge pull request #61 from ChrisRackauckas-Claude/explicit-imports-20251229-195241
Improve explicit imports hygiene
2 parents 4b24f6a + 6c3b4d8 commit 807e8a9

3 files changed

Lines changed: 10 additions & 3 deletions

File tree

Project.toml

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,7 @@ Random = "9a3f8284-a2c9-5f02-9a11-845980a1fd5c"
99
[compat]
1010
Aqua = "0.8"
1111
Distributions = "0.25"
12+
ExplicitImports = "1.14.0"
1213
JET = "0.9, 0.10, 0.11"
1314
LogExpFunctions = "0.3"
1415
Random = "1.10"
@@ -19,9 +20,10 @@ julia = "1.10"
1920
[extras]
2021
Aqua = "4c88cf16-eb10-579e-8560-4a9242c79595"
2122
Distributions = "31c24e10-a181-5473-b8eb-7969acd0382f"
23+
ExplicitImports = "7d51a73a-1435-4ff3-83d9-f097790105c7"
2224
JET = "c3a54625-cd67-489e-a8e7-0a5a0ff4e31b"
2325
Statistics = "10745b16-79ce-11e8-11f9-7d13ad32a3b2"
2426
Test = "8dfed614-e22c-5e08-85e1-65c5234f0b40"
2527

2628
[targets]
27-
test = ["Aqua", "Statistics", "Test", "Distributions", "JET"]
29+
test = ["Aqua", "Statistics", "Test", "Distributions", "JET", "ExplicitImports"]

src/PoissonRandom.jl

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
module PoissonRandom
22

3-
using Random
3+
using Random: Random, AbstractRNG, randexp
44
using LogExpFunctions: log1pmx
55

66
export pois_rand, PassthroughRNG

test/qa.jl

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
using PoissonRandom, Aqua, JET
1+
using PoissonRandom, Aqua, JET, ExplicitImports
22
using Random
33

44
@testset "Aqua" begin
@@ -26,3 +26,8 @@ end
2626
JET.@test_call target_modules = (PoissonRandom,) pois_rand(PassthroughRNG(), 10.0)
2727
end
2828
end
29+
30+
@testset "ExplicitImports" begin
31+
@test check_no_implicit_imports(PoissonRandom) === nothing
32+
@test check_no_stale_explicit_imports(PoissonRandom) === nothing
33+
end

0 commit comments

Comments
 (0)