You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
After fixing the IfElse precompile bug (#52), the test suite runs on Julia 1.10 but advdiff3 fails (425 passed, 1 failed, 1 broken; deterministic over 2 runs):
Example: advdiff3: Test Failed at test/mol_test.jl:67
Expression: sol.retcode == SciMLBase.ReturnCode.Success
Evaluated: SciMLBase.ReturnCode.Unstable == SciMLBase.ReturnCode.Success
At t=1.137…, dt was forced below floating point epsilon. Aborting.
The test file only adds advdiff3 to BROKEN_EXAMPLES for VERSION >= v"1.13-", so on Julia 1.10 it is expected to pass — it doesn't anymore.
The instability appears with the new solver stack: OrdinaryDiffEq v7.0.0, OrdinaryDiffEqBDF v2.2.0, SciMLBase v3.18.0. FBDF drives dt below epsilon on this dispersive advection-diffusion case.
This blocks re-enabling PDESystemLibrary's downgrade CI (the IfElse fix #52 is independent and lands first). Maintainer decision: either (a) investigate it as an OrdinaryDiffEq v7 stiff/dispersion regression, or (b) if the new behavior is correct, mark advdiff3 broken on ≤1.12 too (not just ≥1.13). I did not loosen the assertion. (Possibly related to the other ODE 7.0.0 issues #3721/#3722.)
After fixing the IfElse precompile bug (#52), the test suite runs on Julia 1.10 but
advdiff3fails (425 passed, 1 failed, 1 broken; deterministic over 2 runs):advdiff3is defined inlib/general_linear_system.jland does not useifelse— unrelated to the fix: use Base ifelse for symbolic conditions (un-break precompile) #52 fix.advdiff3toBROKEN_EXAMPLESforVERSION >= v"1.13-", so on Julia 1.10 it is expected to pass — it doesn't anymore.This blocks re-enabling PDESystemLibrary's downgrade CI (the IfElse fix #52 is independent and lands first). Maintainer decision: either (a) investigate it as an OrdinaryDiffEq v7 stiff/dispersion regression, or (b) if the new behavior is correct, mark
advdiff3broken on ≤1.12 too (not just ≥1.13). I did not loosen the assertion. (Possibly related to the other ODE 7.0.0 issues #3721/#3722.)From the SciML downgrade re-enablement pass.