Add tests for StaticArrays

Author: avik-pal

src/default.jl

@@ -192,7 +192,7 @@ function defaultalg(A, b, assump::OperatorAssumptions)
         DefaultAlgorithmChoice.NormalCholeskyFactorization
     elseif A isa StaticArray
         # Static Array doesn't have QR() \ b defined
-        return DefaultAlgorithmChoice.SVDFactorization
+        DefaultAlgorithmChoice.SVDFactorization
     elseif assump.condition === OperatorCondition.IllConditioned
         if is_underdetermined(A)
             # Underdetermined

src/factorization.jl

@@ -12,6 +12,7 @@ _ldiv!(x, A, b) = ldiv!(x, A, b)
 
 _ldiv!(x, A, b::SVector) = (x .= A \ b)
 _ldiv!(::SVector, A, b::SVector) = (A \ b)
+_ldiv!(::SVector, A, b) = (A \ b)
 
 function _ldiv!(x::Vector, A::Factorization, b::Vector)
     # workaround https://github.com/JuliaLang/julia/issues/43507
@@ -288,7 +289,7 @@ end
 function init_cacheval(alg::CholeskyFactorization, A::SMatrix, b, u, Pl, Pr,
     maxiters::Int, abstol, reltol, verbose::Bool,
     assumptions::OperatorAssumptions)
-    cholesky(A)  # StaticArrays doesn't have the pivot argument. Prevent generic fallback.
+    cholesky(SMatrix{1, 1}(one(eltype(A))))  # StaticArrays doesn't have the pivot argument. Prevent generic fallback.
 end
 
 function init_cacheval(alg::CholeskyFactorization, A, b, u, Pl, Pr,
@@ -1060,7 +1061,8 @@ end
 function init_cacheval(alg::NormalCholeskyFactorization, A, b, u, Pl, Pr,
     maxiters::Int, abstol, reltol, verbose::Bool,
     assumptions::OperatorAssumptions)
-    ArrayInterface.cholesky_instance(convert(AbstractMatrix, A), alg.pivot)
+    A_ = convert(AbstractMatrix, A)
+    ArrayInterface.cholesky_instance(Symmetric((A)' * A, :L), alg.pivot)
 end
 
 function init_cacheval(alg::NormalCholeskyFactorization,

test/runtests.jl

@@ -17,6 +17,7 @@ if GROUP == "All" || GROUP == "Core"
     VERSION >= v"1.9" && @time @safetestset "Enzyme Derivative Rules" include("enzyme.jl")
     @time @safetestset "Traits" include("traits.jl")
     VERSION >= v"1.9" && @time @safetestset "BandedMatrices" include("banded.jl")
+    @time @safetestset "Static Arrays" include("static_arrays.jl")
 end
 
 if GROUP == "LinearSolveCUDA"

test/static_arrays.jl

@@ -0,0 +1,25 @@
+using LinearSolve, StaticArrays, LinearAlgebra
+
+A = SMatrix{5, 5}(Hermitian(rand(5, 5) + I))
+b = SVector{5}(rand(5))
+
+for alg in (nothing, LUFactorization(), SVDFactorization(), CholeskyFactorization(),
+    KrylovJL_GMRES())
+    sol = solve(LinearProblem(A, b), alg)
+    @show norm(A * sol .- b)
+    @test norm(A * sol .- b) < 1e-10
+end
+
+A = SMatrix{7, 5}(rand(7, 5))
+b = SVector{7}(rand(7))
+
+for alg in (nothing, SVDFactorization(), KrylovJL_LSMR())
+    @test_nowarn solve(LinearProblem(A, b), alg)
+end
+
+A = SMatrix{5, 7}(rand(5, 7))
+b = SVector{5}(rand(5))
+
+for alg in (nothing, SVDFactorization(), KrylovJL_LSMR())
+    @test_nowarn solve(LinearProblem(A, b), alg)
+end