In a future adaptation, the GMGPolar solver should only handle solver information and we should think of better separation of responsibilities.
GMGPolar seems to be a very big class, it would be clearer if it just takes care of the solving part. Someting like gmgpolar.solve(lhs, rhs, tol, maxIt). You could also consider a templated class to avoid several switch statements and code repetition inside the class : GMGPolar<SmootherOpLevel0, RestrictionOpLevel0, ProlongationOpLevel0, SmootherOp, RestrictionOp, ProlongationOp, MGCycle> ( just an idea )
Originally posted by @ds-aakash in #65 (comment)
In a future adaptation, the GMGPolar solver should only handle solver information and we should think of better separation of responsibilities.
GMGPolarseems to be a very big class, it would be clearer if it just takes care of the solving part. Someting likegmgpolar.solve(lhs, rhs, tol, maxIt). You could also consider a templated class to avoid several switch statements and code repetition inside the class :GMGPolar<SmootherOpLevel0, RestrictionOpLevel0, ProlongationOpLevel0, SmootherOp, RestrictionOp, ProlongationOp, MGCycle>( just an idea )Originally posted by @ds-aakash in #65 (comment)