Merge pull request #230 from Scc33/addPortfolio

Add portfolio link, update dependencies, fix margin

Author: Scc33

bun.lockb

@@ -31,39 +31,39 @@
     "*": "prettier --ignore-unknown --write"
   },
   "devDependencies": {
-    "@eslint/js": "^9.2.0",
-    "@playwright/test": "^1.44.0",
-    "@sveltejs/adapter-static": "^3.0.1",
-    "@sveltejs/kit": "^2.5.7",
-    "@sveltejs/vite-plugin-svelte": "^3.1.0",
-    "@testing-library/jest-dom": "^6.4.5",
-    "@testing-library/svelte": "^5.1.0",
+    "@eslint/js": "^9.6.0",
+    "@playwright/test": "^1.45.0",
+    "@sveltejs/adapter-static": "^3.0.2",
+    "@sveltejs/kit": "^2.5.18",
+    "@sveltejs/vite-plugin-svelte": "^3.1.1",
+    "@testing-library/jest-dom": "^6.4.6",
+    "@testing-library/svelte": "^5.2.0",
     "@vitest/coverage-v8": "^1.6.0",
     "autoprefixer": "^10.4.19",
     "axe-playwright": "^2.0.1",
-    "eslint": "^9.2.0",
+    "eslint": "^9.6.0",
     "eslint-config-prettier": "^9.1.0",
-    "eslint-plugin-jsdoc": "^48.2.3",
-    "eslint-plugin-playwright": "^1.6.0",
-    "eslint-plugin-svelte": "^2.38.0",
+    "eslint-plugin-jsdoc": "^48.5.0",
+    "eslint-plugin-playwright": "^1.6.2",
+    "eslint-plugin-svelte": "^2.41.0",
     "eslint-plugin-vitest": "^0.5.4",
     "gh-pages": "^6.1.1",
     "husky": "^9.0.11",
-    "jsdom": "^24.0.0",
-    "lighthouse": "^12.0.0",
-    "lint-staged": "^15.2.2",
-    "playwright": "^1.44.0",
+    "jsdom": "^24.1.0",
+    "lighthouse": "^12.1.0",
+    "lint-staged": "^15.2.7",
+    "playwright": "^1.45.0",
     "playwright-lighthouse": "^4.0.0",
-    "postcss": "^8.4.38",
-    "prettier": "3.2.5",
-    "prettier-plugin-svelte": "^3.2.3",
-    "svelte": "^4.2.16",
-    "svelte-check": "^3.7.1",
-    "tailwindcss": "^3.4.3",
-    "typescript": "^5.4.5",
-    "typescript-eslint": "^7.8.0",
-    "vite": "^5.2.11",
-    "vite-plugin-static-copy": "^1.0.4",
+    "postcss": "^8.4.39",
+    "prettier": "3.3.2",
+    "prettier-plugin-svelte": "^3.2.5",
+    "svelte": "^4.2.18",
+    "svelte-check": "^3.8.4",
+    "tailwindcss": "^3.4.4",
+    "typescript": "^5.5.3",
+    "typescript-eslint": "^7.15.0",
+    "vite": "^5.3.2",
+    "vite-plugin-static-copy": "^1.0.5",
     "vitest": "^1.6.0"
   },
   "type": "module"

package.json

@@ -26,6 +26,16 @@ describe("footer Component", () => {
     expect(link.getAttribute("target")).toBe("_blank");
   });
 
+  it("has correct link to Portfolio", () => {
+    expect.assertions(2);
+    const { container } = render(Footer);
+    const link = container.querySelector(
+      'a[href="https://portfolio.seancoughlin.me"]'
+    );
+    expect(link).toBeTruthy();
+    expect(link.getAttribute("target")).toBe("_blank");
+  });
+
   it("has correct link to LinkedIn", () => {
     expect.assertions(2);
     const { container } = render(Footer);

src/components/Footer/Footer.test.ts

@@ -15,15 +15,16 @@ describe("header Component", () => {
   });
 
   it("renders all header text with correct text", () => {
-    expect.assertions(3);
+    expect.assertions(4);
     const { getByText } = render(Header, { y: 0 });
     expect(getByText("LinkedIn")).toBeVisible();
     expect(getByText("GitHub")).toBeVisible();
+    expect(getByText("Portfolio")).toBeVisible();
     expect(getByText("Blog")).toBeVisible();
   });
 
   it("renders all header text with correct links", () => {
-    expect.assertions(3);
+    expect.assertions(4);
     const { getByText } = render(Header, { y: 0 });
     expect(getByText("LinkedIn").closest("a")).toHaveAttribute(
       "href",
@@ -33,6 +34,10 @@ describe("header Component", () => {
       "href",
       "https://github.com/Scc33"
     );
+    expect(getByText("Portfolio").closest("a")).toHaveAttribute(
+      "href",
+      "https://portfolio.seancoughlin.me"
+    );
     expect(getByText("Blog").closest("a")).toHaveAttribute(
       "href",
       "https://blog.seancoughlin.me"

src/components/Header/Header.test.ts

@@ -19,7 +19,7 @@
     class="grid grid-cols-1 lg:grid-cols-2 gap-10 py-8 sm:py-14"
   >
     <div
-      class="flex flex-col lg:justify-center text-center lg:text-left gap-6 md:gap-8 lg:gap-10"
+      class="flex flex-col lg:justify-center text-center lg:text-left gap-6 md:gap-8 lg:gap-10 lg:ml-8"
     >
       <h2 class="font-semibold text-4xl sm:text-5xl md:text-6xl">
         Hi! I'm <span class="poppins text-violet-400">Sean</span>

src/components/Main/Main.svelte

@@ -6,13 +6,17 @@ interface Links {
 const links: Links[] = [
   { name: "Email", url: "mailto:coughlinscc33@gmail.com" },
   {
-    name: " LinkedIn",
+    name: "LinkedIn",
     url: "https://www.linkedin.com/in/sean-m-coughlin"
   },
   {
-    name: " GitHub",
+    name: "GitHub",
     url: "https://github.com/Scc33"
   },
+  {
+    name: "Portfolio",
+    url: "https://portfolio.seancoughlin.me"
+  },
   {
     name: "Blog",
     url: "https://blog.seancoughlin.me"

src/data/Links.ts

@@ -28,6 +28,9 @@ test.describe("home page", () => {
     await expect(
       page.getByRole("banner").getByRole("link", { name: "GitHub" })
     ).toBeVisible();
+    await expect(
+      page.getByRole("banner").getByRole("link", { name: "Portfolio" })
+    ).toBeVisible();
     await expect(
       page.getByRole("banner").getByRole("link", { name: "Blog" })
     ).toBeVisible();
@@ -57,6 +60,9 @@ test.describe("home page", () => {
     await expect(
       page.getByRole("contentinfo").getByRole("link", { name: "GitHub" })
     ).toBeVisible();
+    await expect(
+      page.getByRole("contentinfo").getByRole("link", { name: "Portfolio" })
+    ).toBeVisible();
     await expect(
       page.getByRole("contentinfo").getByRole("link", { name: "Blog" })
     ).toBeVisible();