W-21017986 MCP e2e Tests (#203)

* First draft e2e mcp tests

* Attempt b2c-cli fix

* Fix linting

* Ignore e2e package.json files

* Fix 3pl guard exclusion

* 3pl guard exception

---------

Co-authored-by: yhsieh1 <yhsieh@salesforce.com>

Author: allison-grady

.github/workflows/3pl-guard.yml

@@ -123,9 +123,14 @@ jobs:
               per_page: 100,
             });
 
+            // Exclude package.json under test/fixtures/ (e.g. e2e workspace-detection fixtures)
+            const isUnderTestFixtures = (filename) =>
+              filename.includes('/test/') && filename.includes('/fixtures/');
             const changedPackageJsonFiles = files
               .map((file) => file.filename)
-              .filter((filename) => filename.endsWith('package.json'));
+              .filter((filename) =>
+                filename.endsWith('package.json') && !isUnderTestFixtures(filename),
+              );
 
             const findings = [];
 
@@ -200,4 +205,4 @@ jobs:
             await addLabel(reviewLabel);
             core.setFailed(
               `Net-new third-party dependencies found: ${allNetNewDeps.join(', ')}. Add \`${approvalLabel}\` after review.`,
-            );
+            );

.github/workflows/e2e-tests.yml

@@ -166,3 +166,39 @@ jobs:
             if (context.eventName === 'schedule') {
               github.rest.issues.create(issue);
             }
+
+  mcp-e2e-tests:
+    name: MCP E2E
+    runs-on: ubuntu-latest
+    timeout-minutes: 15
+    steps:
+      - uses: actions/checkout@v4
+      - uses: actions/setup-node@v4
+        with:
+          node-version: '22.x'
+      - name: Setup pnpm
+        uses: pnpm/action-setup@v4
+        with:
+          version: 10.17.1
+      - name: Get pnpm store directory
+        id: pnpm-store
+        shell: bash
+        run: |
+          echo "store_path=$(pnpm store path --silent)" >> $GITHUB_OUTPUT
+      - name: Setup pnpm cache
+        uses: actions/cache@v4
+        with:
+          path: ${{ steps.pnpm-store.outputs.store_path }}
+          key: ${{ runner.os }}-pnpm-store-${{ hashFiles('**/pnpm-lock.yaml') }}
+          restore-keys: |
+            ${{ runner.os }}-pnpm-store-
+      - name: Install dependencies
+        run: pnpm install --frozen-lockfile
+      - name: Build packages
+        run: pnpm -r run build
+      - name: Run MCP E2E tests
+        working-directory: packages/b2c-dx-mcp
+        env:
+          SFCC_DISABLE_TELEMETRY: 'true'
+          NODE_ENV: test
+        run: pnpm run test:e2e:ci

packages/b2c-cli/test/functional/e2e/webdav-operations.test.ts

@@ -368,8 +368,29 @@ describe('WebDAV Operations E2E Tests', function () {
 
   describe('Step 11: Verify Extracted Files', function () {
     it('should find extracted files in directory', async function () {
-      await waitFor(async () => {
-        const result = await runCLI([
+      // Unzip visibility can be delayed on WebDAV; use longer timeout and poll every 1s
+      try {
+        await waitFor(
+          async () => {
+            const result = await runCLI([
+              'webdav',
+              'ls',
+              remoteDirPath,
+              '--server',
+              serverHostname,
+              '--root',
+              'impex',
+              '--json',
+            ]);
+            if (result.exitCode !== 0) return false;
+            const response = JSON.parse(toString(result.stdout));
+            return response.entries?.some((e: any) => entryName(e) === testFileName);
+          },
+          420_000,
+          1000,
+        );
+      } catch (error) {
+        const diag = await runCLI([
           'webdav',
           'ls',
           remoteDirPath,
@@ -378,11 +399,10 @@ describe('WebDAV Operations E2E Tests', function () {
           '--root',
           'impex',
           '--json',
-        ]);
-        if (result.exitCode !== 0) return false;
-        const response = JSON.parse(toString(result.stdout));
-        return response.entries?.some((e: any) => entryName(e) === testFileName);
-      }, 300_000);
+        ]).then((r) => (r.exitCode === 0 ? toString(r.stdout) : `exit ${r.exitCode}: ${toString(r.stderr)}`));
+        const msg = error instanceof Error ? error.message : String(error);
+        throw new Error(`${msg}. Last LIST of ${remoteDirPath}: ${diag.slice(0, 500)}`);
+      }
     });
   });
 });

packages/b2c-dx-mcp/package.json

@@ -84,9 +84,11 @@
     "inspect": "mcp-inspector node bin/run.js --toolsets all --allow-non-ga-tools",
     "inspect:dev": "mcp-inspector node --conditions development bin/dev.js --toolsets all --allow-non-ga-tools",
     "pretest": "tsc --noEmit -p test",
-    "test": "c8 mocha --forbid-only \"test/**/*.test.ts\"",
-    "test:ci": "c8 mocha --forbid-only --reporter json --reporter-option output=test-results.json \"test/**/*.test.ts\"",
-    "test:agent": "mocha --forbid-only --reporter min \"test/**/*.test.ts\"",
+    "test": "c8 mocha --forbid-only --ignore 'test/e2e/**' \"test/**/*.test.ts\"",
+    "test:ci": "c8 mocha --forbid-only --reporter json --reporter-option output=test-results.json --ignore 'test/e2e/**' \"test/**/*.test.ts\"",
+    "test:agent": "mocha --forbid-only --reporter min --ignore 'test/e2e/**' \"test/**/*.test.ts\"",
+    "test:e2e": "mocha --forbid-only \"test/e2e/**/*.test.ts\"",
+    "test:e2e:ci": "mocha --forbid-only --reporter json --reporter-option output=test-results-e2e.json \"test/e2e/**/*.test.ts\"",
     "coverage": "c8 report",
     "posttest": "pnpm run lint",
     "prepack": "oclif manifest",

packages/b2c-dx-mcp/test/e2e/fixtures/cartridge/cartridges/app_custom/.project

@@ -0,0 +1,2 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<project name="app_custom" description="E2E test cartridge"/>

packages/b2c-dx-mcp/test/e2e/fixtures/empty/package.json

@@ -0,0 +1 @@
+{"name": "e2e-empty", "private": true}

packages/b2c-dx-mcp/test/e2e/fixtures/pwav3/package.json

@@ -0,0 +1 @@
+{"name": "e2e-pwav3", "dependencies": {"@salesforce/pwa-kit-react-sdk": "1.0.0"}}

packages/b2c-dx-mcp/test/e2e/fixtures/storefront-next/package.json

@@ -0,0 +1 @@
+{"name": "e2e-storefront-next", "dependencies": {"@salesforce/storefront-next-runtime": "1.0.0"}}