Merge pull request #193 from dozro/sonar-qube/fixes-2026-03-11

[internal] Fix a few maintainability issues raised by SonarQube

Author: 7w1

src/app/components/message/modals/MessageForward.tsx

@@ -87,7 +87,11 @@ type ForwardMeta = {
   original_event_private: boolean;
 };
 
-export function MessageForwardInternal({ room, mEvent, onClose }: MessageForwardInternalProps) {
+export function MessageForwardInternal({
+  room,
+  mEvent,
+  onClose,
+}: Readonly<MessageForwardInternalProps>) {
   const mx = useMatrixClient();
 
   const [isTargetSelected, setIsTargetSelected] = useState(false);
@@ -191,7 +195,7 @@ export function MessageForwardInternal({ room, mEvent, onClose }: MessageForward
       const safeHtml =
         originalFormattedBody !== undefined
           ? sanitizeCustomHtml(originalFormattedBody)
-          : sanitizeCustomHtml(originalBody).replace(/\n/g, '<br>');
+          : sanitizeCustomHtml(originalBody).replaceAll('\n', '<br>');
 
       newBodyHtml =
         `<div data-forward-marker>` +
@@ -243,19 +247,13 @@ export function MessageForwardInternal({ room, mEvent, onClose }: MessageForward
       };
     }
 
-    try {
-      mx.sendEvent(targetRoom.roomId, null, eventType, content as unknown as SendEventContent)
-        .then(() => setIsForwardSuccess(true))
-        .catch(() => {
-          setIsForwarding(false);
-          setIsForwardSuccess(false);
-          setIsForwardError(true);
-        });
-    } catch {
-      setIsForwarding(false);
-      setIsForwardSuccess(false);
-      setIsForwardError(true);
-    }
+    mx.sendEvent(targetRoom.roomId, null, eventType, content as unknown as SendEventContent)
+      .then(() => setIsForwardSuccess(true))
+      .catch(() => {
+        setIsForwarding(false);
+        setIsForwardSuccess(false);
+        setIsForwardError(true);
+      });
   };
 
   return (

src/app/features/room/RoomInput.tsx

@@ -312,18 +312,19 @@ export const RoomInput = forwardRef<HTMLDivElement, RoomInputProps>(
 
     if (htmlBody) {
       const strippedHtml = trimReplyFromFormattedBody(htmlBody)
-        .replace(/<br\s*\/?>/gi, ' ')
-        .replace(/<\/p>\s*<p[^>]*>/gi, ' ')
-        .replace(/<\/?p[^>]*>/gi, '')
-        .replace(/(?:\r\n|\r|\n)/g, ' ');
+        .replaceAll(/<br\s*\/?>/gi, ' ')
+        .replaceAll(/<\/p>\s*<p[^>]*>/gi, ' ')
+        .replaceAll(/<\/?p[^>]*>/gi, '')
+        .replaceAll(/(?:\r\n|\r|\n)/g, ' ')
+        .trim();
       const parserOpts = getReactCustomHtmlParser(mx, roomId, {
         linkifyOpts: LINKIFY_OPTS,
         useAuthentication,
         nicknames,
       });
       replyBodyJSX = parse(strippedHtml, parserOpts);
     } else if (plainBody) {
-      const strippedBody = trimReplyFromBody(plainBody).replace(/(?:\r\n|\r|\n)/g, ' ');
+      const strippedBody = trimReplyFromBody(plainBody).replaceAll(/(?:\r\n|\r|\n)/g, ' ');
       replyBodyJSX = scaleSystemEmoji(strippedBody);
     }
 
@@ -333,11 +334,11 @@ export const RoomInput = forwardRef<HTMLDivElement, RoomInputProps>(
 
     useEffect(
       () => () => {
-        if (!isEmptyEditor(editor)) {
-          const parsedDraft = JSON.parse(JSON.stringify(editor.children));
-          setMsgDraft(parsedDraft);
-        } else {
+        if (isEmptyEditor(editor)) {
           setMsgDraft([]);
+        } else {
+          const parsedDraft = structuredClone(editor.children);
+          setMsgDraft(parsedDraft);
         }
         resetEditor(editor);
         resetEditorHistory(editor);

src/app/features/room/RoomTimeline.tsx

@@ -240,7 +240,7 @@ export const getEventIdAbsoluteIndex = (
   eventTimeline: EventTimeline,
   eventId: string
 ): number | undefined => {
-  const timelineIndex = timelines.findIndex((t) => t === eventTimeline);
+  const timelineIndex = timelines.indexOf(eventTimeline);
   if (timelineIndex === -1) return undefined;
 
   const currentEvents = eventTimeline.getEvents();
@@ -285,17 +285,17 @@ const useEventTimelineLoader = (
     async (eventId: string) => {
       const withTimeout = async <T,>(promise: Promise<T>, timeoutMs: number): Promise<T> =>
         new Promise<T>((resolve, reject) => {
-          const timeoutId = window.setTimeout(() => {
+          const timeoutId = globalThis.setTimeout(() => {
             reject(new Error('Timed out loading event timeline'));
           }, timeoutMs);
 
           promise
             .then((value) => {
-              window.clearTimeout(timeoutId);
+              globalThis.clearTimeout(timeoutId);
               resolve(value);
             })
             .catch((error) => {
-              window.clearTimeout(timeoutId);
+              globalThis.clearTimeout(timeoutId);
               reject(error);
             });
         });
@@ -381,7 +381,7 @@ const useTimelinePagination = (
       const { linkedTimelines: lTimelines } = timelineRef.current;
       const timelinesEventsCount = lTimelines.map(timelineToEventsCount);
 
-      const timelineToPaginate = backwards ? lTimelines[0] : lTimelines[lTimelines.length - 1];
+      const timelineToPaginate = backwards ? lTimelines[0] : lTimelines.at(-1);
       if (!timelineToPaginate) return;
 
       const paginationToken = timelineToPaginate.getPaginationToken(
@@ -688,8 +688,7 @@ export function RoomTimeline({
     eventId ? getEmptyTimeline() : getInitialTimeline(room)
   );
   const eventsLength = getTimelinesEventsCount(timeline.linkedTimelines);
-  const liveTimelineLinked =
-    timeline.linkedTimelines[timeline.linkedTimelines.length - 1] === getLiveTimeline(room);
+  const liveTimelineLinked = timeline.linkedTimelines.at(-1) === getLiveTimeline(room);
   const canPaginateBack =
     typeof timeline.linkedTimelines[0]?.getPaginationToken(Direction.Backward) === 'string';
   const rangeAtStart = timeline.range.start === 0;
@@ -1091,7 +1090,7 @@ export function RoomTimeline({
 
   // scroll to focused message
   useLayoutEffect(() => {
-    if (focusItem && focusItem.scrollTo) {
+    if (focusItem?.scrollTo) {
       scrollToItem(focusItem.index, {
         behavior: 'instant',
         align: 'center',
@@ -1357,7 +1356,7 @@ export function RoomTimeline({
     {
       [MessageEvent.RoomMessage]: (mEventId, mEvent, item, timelineSet, collapse) => {
         const reactionRelations = getEventReactions(timelineSet, mEventId);
-        const reactions = reactionRelations && reactionRelations.getSortedAnnotationsByKey();
+        const reactions = reactionRelations?.getSortedAnnotationsByKey();
         const hasReactions = reactions && reactions.length > 0;
         const { replyEventId, threadRootId } = mEvent;
         const highlighted = focusItem?.index === item && focusItem.highlight;
@@ -1486,7 +1485,7 @@ export function RoomTimeline({
       },
       [MessageEvent.RoomMessageEncrypted]: (mEventId, mEvent, item, timelineSet, collapse) => {
         const reactionRelations = getEventReactions(timelineSet, mEventId);
-        const reactions = reactionRelations && reactionRelations.getSortedAnnotationsByKey();
+        const reactions = reactionRelations?.getSortedAnnotationsByKey();
         const hasReactions = reactions && reactions.length > 0;
         const { replyEventId, threadRootId } = mEvent;
         const highlighted = focusItem?.index === item && focusItem.highlight;
@@ -1626,7 +1625,7 @@ export function RoomTimeline({
       },
       [MessageEvent.Sticker]: (mEventId, mEvent, item, timelineSet, collapse) => {
         const reactionRelations = getEventReactions(timelineSet, mEventId);
-        const reactions = reactionRelations && reactionRelations.getSortedAnnotationsByKey();
+        const reactions = reactionRelations?.getSortedAnnotationsByKey();
         const hasReactions = reactions && reactions.length > 0;
         const { replyEventId, threadRootId } = mEvent;
         const highlighted = focusItem?.index === item && focusItem.highlight;