Skip to content

Commit dde7f45

Browse files
authored
Chore: Improve the missing dates output by wrapping them into square brackets (#3693)
1 parent 2bb8f7f commit dde7f45

File tree

3 files changed

+12
-12
lines changed

3 files changed

+12
-12
lines changed

sqlmesh/core/console.py

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -889,7 +889,7 @@ def _show_missing_dates(self, plan: Plan, default_catalog: t.Optional[str]) -> N
889889
missing_intervals = plan.missing_intervals
890890
if not missing_intervals:
891891
return
892-
backfill = Tree("[bold]Models needing backfill (missing dates):")
892+
backfill = Tree("[bold]Models needing backfill \[missing dates]:")
893893
for missing in missing_intervals:
894894
snapshot = plan.context_diff.snapshots[missing.snapshot_id]
895895
if not snapshot.is_model:
@@ -903,7 +903,7 @@ def _show_missing_dates(self, plan: Plan, default_catalog: t.Optional[str]) -> N
903903
plan.environment_naming_info, default_catalog, dialect=self.dialect
904904
)
905905
backfill.add(
906-
f"{display_name}: {_format_missing_intervals(snapshot, missing)}{preview_modifier}"
906+
f"{display_name}: \[{_format_missing_intervals(snapshot, missing)}]{preview_modifier}"
907907
)
908908

909909
if backfill:
@@ -1723,7 +1723,7 @@ def _show_missing_dates(self, plan: Plan, default_catalog: t.Optional[str]) -> N
17231723
missing_intervals = plan.missing_intervals
17241724
if not missing_intervals:
17251725
return
1726-
self._print("\n**Models needing backfill (missing dates):**")
1726+
self._print("\n**Models needing backfill \[missing dates]:**")
17271727
snapshots = []
17281728
for missing in missing_intervals:
17291729
snapshot = plan.context_diff.snapshots[missing.snapshot_id]
@@ -1738,7 +1738,7 @@ def _show_missing_dates(self, plan: Plan, default_catalog: t.Optional[str]) -> N
17381738
plan.environment_naming_info, default_catalog, dialect=self.dialect
17391739
)
17401740
snapshots.append(
1741-
f"* `{display_name}`: {_format_missing_intervals(snapshot, missing)}{preview_modifier}"
1741+
f"* `{display_name}`: [{_format_missing_intervals(snapshot, missing)}]{preview_modifier}"
17421742
)
17431743

17441744
length = len(snapshots)

tests/cli/test_cli.py

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -294,8 +294,8 @@ def test_plan_dev_start_date(runner, tmp_path):
294294
input="\ny\n",
295295
)
296296
assert_plan_success(result, "dev")
297-
assert "sqlmesh_example__dev.full_model: full refresh" in result.output
298-
assert "sqlmesh_example__dev.incremental_model: 2023-01-01" in result.output
297+
assert "sqlmesh_example__dev.full_model: [full refresh]" in result.output
298+
assert "sqlmesh_example__dev.incremental_model: [2023-01-01" in result.output
299299

300300

301301
def test_plan_dev_end_date(runner, tmp_path):
@@ -308,8 +308,8 @@ def test_plan_dev_end_date(runner, tmp_path):
308308
input="\ny\n",
309309
)
310310
assert_plan_success(result, "dev")
311-
assert "sqlmesh_example__dev.full_model: full refresh" in result.output
312-
assert "sqlmesh_example__dev.incremental_model: 2020-01-01 - 2023-01-01" in result.output
311+
assert "sqlmesh_example__dev.full_model: [full refresh]" in result.output
312+
assert "sqlmesh_example__dev.incremental_model: [2020-01-01 - 2023-01-01]" in result.output
313313

314314

315315
def test_plan_dev_create_from_virtual(runner, tmp_path):

tests/integrations/github/cicd/test_integration.py

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -379,8 +379,8 @@ def test_merge_pr_has_non_breaking_change_diff_start(
379379
- `sushi.top_waiters`
380380
381381
382-
**Models needing backfill (missing dates):**
383-
* `sushi.waiter_revenue_by_day`: 2022-12-25 - 2022-12-28
382+
**Models needing backfill [missing dates]:**
383+
* `sushi.waiter_revenue_by_day`: [2022-12-25 - 2022-12-28]
384384
"""
385385
assert prod_plan_preview_checks_runs[2]["output"]["summary"] == expected_prod_plan
386386

@@ -1066,8 +1066,8 @@ def test_no_merge_since_no_deploy_signal_no_approvers_defined(
10661066
- `sushi.top_waiters`
10671067
10681068
1069-
**Models needing backfill (missing dates):**
1070-
* `sushi.waiter_revenue_by_day`: 2022-12-25 - 2022-12-29
1069+
**Models needing backfill [missing dates]:**
1070+
* `sushi.waiter_revenue_by_day`: [2022-12-25 - 2022-12-29]
10711071
"""
10721072
assert prod_plan_preview_checks_runs[2]["output"]["title"] == "Prod Plan Preview"
10731073
assert prod_plan_preview_checks_runs[2]["output"]["summary"] == expected_prod_plan

0 commit comments

Comments
 (0)