Fix: Make sure that changes to seed models are reflected in the dev-only VDE mode

Author: izeigerman

sqlmesh/core/plan/common.py

@@ -5,7 +5,10 @@
 
 def should_force_rebuild(old: Snapshot, new: Snapshot) -> bool:
     if new.is_view and new.is_indirect_non_breaking and not new.is_forward_only:
-        # View models always need to be rebuilt to reflect updated upstream dependencies.
+        # View models always need to be rebuilt to reflect updated upstream dependencies
+        return True
+    if new.is_seed:
+        # Seed models always need to be rebuilt to reflect changes in the seed file
         return True
     return is_breaking_kind_change(old, new)
 

tests/core/test_integration.py

@@ -2918,6 +2918,37 @@ def test_virtual_environment_mode_dev_only_model_kind_change_manual_categorizati
     ]
 
 
+@time_machine.travel("2023-01-08 15:00:00 UTC")
+def test_virtual_environment_mode_dev_only_seed_model_change(
+    init_and_plan_context: t.Callable,
+):
+    context, plan = init_and_plan_context(
+        "examples/sushi", config="test_config_virtual_environment_mode_dev_only"
+    )
+    context.apply(plan)
+
+    seed_model = context.get_model("sushi.waiter_names")
+    with open(seed_model.seed_path, "a") as fd:
+        fd.write("\n123,New Test Name")
+
+    context.load()
+    seed_model_snapshot = context.get_snapshot("sushi.waiter_names")
+    plan = context.plan_builder("prod").build()
+    assert plan.directly_modified == {seed_model_snapshot.snapshot_id}
+    assert len(plan.missing_intervals) == 1
+    assert plan.missing_intervals[0].snapshot_id == seed_model_snapshot.snapshot_id
+
+    context.apply(plan)
+
+    actual_seed_df = context.fetchdf("SELECT * FROM sushi.waiter_names WHERE id = 123")
+    assert actual_seed_df.to_dict("records") == [
+        {
+            "id": 123,
+            "name": "New Test Name",
+        }
+    ]
+
+
 @time_machine.travel("2023-01-08 15:00:00 UTC")
 def test_restatement_plan_ignores_changes(init_and_plan_context: t.Callable):
     context, plan = init_and_plan_context("examples/sushi")