Fix: Fallback to the breaking change category if the model's query can't be rendered at parse time and the auto categorization mode is set to FULL (#1369)

Author: izeigerman

sqlmesh/core/plan/definition.py

@@ -7,7 +7,11 @@
 from datetime import datetime
 from enum import Enum
 
-from sqlmesh.core.config import CategorizerConfig, EnvironmentSuffixTarget
+from sqlmesh.core.config import (
+    AutoCategorizationMode,
+    CategorizerConfig,
+    EnvironmentSuffixTarget,
+)
 from sqlmesh.core.console import SNAPSHOT_CHANGE_CATEGORY_STR
 from sqlmesh.core.context_diff import ContextDiff
 from sqlmesh.core.environment import Environment, EnvironmentNamingInfo
@@ -570,19 +574,19 @@ def _categorize_snapshots(self) -> None:
                                 model_with_missing_columns = downstream
                                 break
 
+                        new, old = self.context_diff.modified_snapshots[model_name]
                         if model_with_missing_columns is None:
-                            new, old = self.context_diff.modified_snapshots[model_name]
                             change_category = categorize_change(
                                 new, old, config=self.categorizer_config
                             )
                             if change_category is not None:
                                 self.set_choice(new, change_category)
                         else:
-                            logger.warning(
-                                "Changes to model '%s' cannot be automatically categorized due to missing schema for model '%s'",
-                                model_name,
-                                model_with_missing_columns,
+                            mode = self.categorizer_config.dict().get(
+                                new.model.source_type, AutoCategorizationMode.OFF
                             )
+                            if mode == AutoCategorizationMode.FULL:
+                                self.set_choice(new, SnapshotChangeCategory.BREAKING)
 
                 # set to breaking if an indirect child has no directly modified parents
                 # that need a decision. this can happen when a revert to a parent causes

tests/core/test_plan.py

@@ -364,7 +364,7 @@ def test_auto_categorization(make_snapshot, mocker: MockerFixture):
 def test_auto_categorization_missing_schema_downstream(make_snapshot, mocker: MockerFixture):
     snapshot = make_snapshot(SqlModel(name="a", query=parse_one("select 1, ds")))
     snapshot.categorize_as(SnapshotChangeCategory.BREAKING)
-    updated_snapshot = make_snapshot(SqlModel(name="a", query=parse_one("select 2, ds")))
+    updated_snapshot = make_snapshot(SqlModel(name="a", query=parse_one("select 1, 2, ds")))
 
     downstream_snapshot = make_snapshot(
         SqlModel(name="b", query=parse_one("select * from tbl"), depends_on={"a"}),
@@ -389,8 +389,8 @@ def test_auto_categorization_missing_schema_downstream(make_snapshot, mocker: Mo
 
     Plan(context_diff_mock)
 
-    assert updated_snapshot.version is None
-    assert updated_snapshot.change_category is None
+    assert updated_snapshot.version
+    assert updated_snapshot.change_category == SnapshotChangeCategory.BREAKING
 
 
 def test_end_from_missing_instead_of_now(make_snapshot, mocker: MockerFixture):