fix: allow sync_grants_config to be duplicated on when planned w/ create and promote

Author: newtonapple

sqlmesh/core/snapshot/evaluator.py

@@ -873,7 +873,6 @@ def create_snapshot(
                     deployability_index=deployability_index,
                     create_render_kwargs=create_render_kwargs,
                     rendered_physical_properties=rendered_physical_properties,
-                    skip_grants=True,
                     dry_run=True,
                 )
 
@@ -1429,7 +1428,7 @@ def _can_clone(self, snapshot: Snapshot, deployability_index: DeployabilityIndex
             and snapshot.is_materialized
             and bool(snapshot.previous_versions)
             and adapter.SUPPORTS_CLONING
-            # managed models cannot have their schema mutated because theyre based on queries, so clone + alter wont work
+            # managed models cannot have their schema mutated because they're based on queries, so clone + alter won't work
             and not snapshot.is_managed
             # If the deployable table is missing we can't clone it
             and not deployability_index.is_deployable(snapshot)

tests/core/test_context.py

@@ -3185,6 +3185,7 @@ def test_grants_through_plan_apply(sushi_context, mocker):
     from sqlmesh.core.model.meta import GrantsTargetLayer
 
     model = sushi_context.get_model("sushi.waiter_revenue_by_day")
+
     mocker.patch.object(DuckDBEngineAdapter, "SUPPORTS_GRANTS", True)
     sync_grants_mock = mocker.patch.object(DuckDBEngineAdapter, "sync_grants_config")
 
@@ -3206,18 +3207,20 @@ def test_grants_through_plan_apply(sushi_context, mocker):
 
     sync_grants_mock.reset_mock()
 
+    new_grants = ({"select": ["analyst", "reporter", "manager"], "insert": ["etl_user"]},)
     model_updated = model_with_grants.copy(
         update={
             "query": parse_one(model.query.sql() + " LIMIT 1000"),
-            "grants": {"select": ["analyst", "reporter", "manager"], "insert": ["etl_user"]},
+            "grants": new_grants,
             "stamp": "update model and grants",
         }
     )
     sushi_context.upsert_model(model_updated)
 
     sushi_context.plan("dev", no_prompts=True, auto_apply=True)
 
-    assert sync_grants_mock.call_count == 2
-
-    expected_grants = {"select": ["analyst", "reporter", "manager"], "insert": ["etl_user"]}
-    assert all(call[0][1] == expected_grants for call in sync_grants_mock.call_args_list)
+    # Applies grants 3 times:
+    #   2 x physical (duplicated): create, promote (will diff but won't apply since it's the same grants)
+    #   1 x virtual
+    assert sync_grants_mock.call_count == 3
+    assert all(call[0][1] == new_grants for call in sync_grants_mock.call_args_list)