Chore: improve test stability and address some warnings

Author: erindru

pyproject.toml

@@ -265,7 +265,11 @@ markers = [
     "snowflake: test for Snowflake",
     "spark: test for Spark",
     "trino: test for Trino (all connectors)",
-    "risingwave: test for Risingwave"
+    "risingwave: test for Risingwave",
+
+    # Other
+    "set_default_connection",
+    "registry_isolation"
 ]
 addopts = "-n 0 --dist=loadgroup"
 asyncio_default_fixture_loop_scope = "session"

sqlmesh/core/test/context.py

@@ -18,6 +18,8 @@ class TestExecutionContext(ExecutionContext):
         models: All upstream models to use for expansion and mapping of physical locations.
     """
 
+    __test__ = False  # prevent pytest trying to collect this as a test class
+
     def __init__(
         self,
         engine_adapter: EngineAdapter,

sqlmesh/dbt/test.py

@@ -61,6 +61,10 @@ class TestConfig(GeneralConfig):
         error_if: Conditional expression (default "!=0") to detect if error condition met (Not supported).
     """
 
+    __test__ = (
+        False  # prevent pytest trying to collect this as a test class when it's imported in a test
+    )
+
     # SQLMesh fields
     path: Path = Path()
     name: str

tests/conftest.py

@@ -222,10 +222,6 @@ def pytest_runtest_makereport(item: pytest.Item, call: pytest.CallInfo):
     # note: the hook always has to yield
     outcome = yield
 
-    # we only care about tests that used the tmp_path fixture
-    if "tmp_path" not in getattr(item, "fixturenames", []):
-        return
-
     result: pytest.TestReport = outcome.get_result()
 
     if result.when != "teardown":

tests/dbt/test_integration.py

@@ -27,6 +27,8 @@
 
 
 class TestType(str, Enum):
+    __test__ = False  # prevent pytest trying to collect this as a test class
+
     DBT_RUNTIME = "dbt_runtime"
     DBT_ADAPTER = "dbt_adapter"
     SQLMESH = "sqlmesh"
@@ -53,6 +55,8 @@ def is_sqlmesh_runtime(self) -> bool:
 
 
 class TestStrategy(str, Enum):
+    __test__ = False  # prevent pytest trying to collect this as a test class
+
     CHECK = "check"
     TIMESTAMP = "timestamp"
 

tests/engines/spark/test_db_api.py

@@ -4,10 +4,7 @@
 from sqlmesh.engines.spark.db_api import errors
 from sqlmesh.engines.spark.db_api import spark_session as spark_session_db
 
-pytestmark = [
-    pytest.mark.slow,
-    pytest.mark.spark_pyspark,
-]
+pytestmark = [pytest.mark.slow, pytest.mark.spark]
 
 
 def test_spark_session_cursor(spark_session: SparkSession):

tests/integrations/github/cicd/test_github_commands.py

@@ -5,6 +5,8 @@
 from unittest import TestCase, mock
 from unittest.result import TestResult
 
+TestResult.__test__ = False  # prevent pytest trying to collect this as a test class
+
 import pytest
 from pytest_mock.plugin import MockerFixture