@@ -1516,7 +1516,7 @@ def test_mssql_engine_import_validator():
15161516 mock_import .side_effect = ImportError ("No module named 'pyodbc'" )
15171517 MSSQLConnectionConfig (host = "localhost" , driver = "pyodbc" )
15181518
1519- # Test PyODBC driver suggests mssql-python extra when import fails
1519+ # Test MSSQL Python driver suggests mssql-python extra when import fails
15201520 if SUPPORTS_MSSQL_PYTHON_DRIVER :
15211521 with pytest .raises (ConfigError , match = r"pip install \"sqlmesh\[mssql-python\]\"" ):
15221522 with patch ("importlib.import_module" ) as mock_import :
@@ -1736,7 +1736,6 @@ def test_mssql_pyodbc_connection_string_generation():
17361736 assert call_args [1 ]["autocommit" ] is False
17371737
17381738
1739- @pytest .mark .xfail (not SUPPORTS_MSSQL_PYTHON_DRIVER , reason = "mssql-python driver not supported" )
17401739def test_mssql_pyodbc_connection_string_with_odbc_properties ():
17411740 """Test pyodbc connection string includes custom ODBC properties."""
17421741 with patch ("pyodbc.connect" ) as mock_pyodbc_connect :
@@ -1827,7 +1826,7 @@ def test_mssql_mssql_python_connection_string_generation():
18271826 factory_with_kwargs = config ._connection_factory_with_kwargs
18281827 connection = factory_with_kwargs ()
18291828
1830- # Verify pyodbc .connect was called with the correct connection string
1829+ # Verify mssql_python .connect was called with the correct connection string
18311830 mock_mssql_python_connect .assert_called_once ()
18321831 call_args = mock_mssql_python_connect .call_args
18331832
@@ -1875,7 +1874,7 @@ def test_mssql_mssql_python_connection_string_with_odbc_properties():
18751874 factory_with_kwargs = config ._connection_factory_with_kwargs
18761875 connection = factory_with_kwargs ()
18771876
1878- # Verify pyodbc .connect was called
1877+ # Verify mssql_python .connect was called
18791878 mock_mssql_python_connect .assert_called_once ()
18801879 conn_str = mock_mssql_python_connect .call_args [0 ][0 ]
18811880
@@ -2084,7 +2083,7 @@ def test_mssql_mssql_python_connection_datetimeoffset_handling():
20842083 def mock_add_output_converter (sql_type , converter_func ):
20852084 converter_calls .append ((sql_type , converter_func ))
20862085
2087- # Create a mock connection that will be returned by pyodbc .connect
2086+ # Create a mock connection that will be returned by mssql_python .connect
20882087 mock_connection = Mock ()
20892088 mock_connection .add_output_converter = mock_add_output_converter
20902089 mock_mssql_python_connect .return_value = mock_connection
@@ -2340,7 +2339,7 @@ def test_fabric_mssql_python_connection_string_generation():
23402339 factory_with_kwargs = config ._connection_factory_with_kwargs
23412340 connection = factory_with_kwargs ()
23422341
2343- # Verify pyodbc .connect was called with the correct connection string
2342+ # Verify mssql_python .connect was called with the correct connection string
23442343 mock_mssql_python_connect .assert_called_once ()
23452344 call_args = mock_mssql_python_connect .call_args
23462345
0 commit comments