Skip to content

Commit 9116148

Browse files
committed
chore(vscode): enabling more tests
1 parent 245e8c9 commit 9116148

File tree

1 file changed

+21
-44
lines changed

1 file changed

+21
-44
lines changed

vscode/extension/tests/lineage.spec.ts

Lines changed: 21 additions & 44 deletions
Original file line numberDiff line numberDiff line change
@@ -19,8 +19,6 @@ import {
1919
* Helper function to launch VS Code and test lineage with given project path config
2020
*/
2121
async function testLineageWithProjectPath(page: Page): Promise<void> {
22-
await page.waitForLoadState('networkidle')
23-
await page.waitForLoadState('domcontentloaded')
2422
await openLineageView(page)
2523
await waitForLoadedSQLMesh(page)
2624
}
@@ -37,7 +35,7 @@ test('Lineage panel renders correctly - no project path config (default)', async
3735
await testLineageWithProjectPath(page)
3836
})
3937

40-
test.skip('Lineage panel renders correctly - relative project path', async ({
38+
test('Lineage panel renders correctly - relative project path', async ({
4139
page,
4240
sharedCodeServer,
4341
}) => {
@@ -70,52 +68,38 @@ test.skip('Lineage panel renders correctly - relative project path', async ({
7068
}
7169
})
7270

73-
test.skip('Lineage panel renders correctly - absolute project path', async ({
71+
test('Lineage panel renders correctly - absolute project path', async ({
7472
page,
7573
tempDir,
7674
sharedCodeServer,
7775
}) => {
78-
const workspaceDir = await fs.mkdtemp(
79-
path.join(os.tmpdir(), 'vscode-test-workspace-'),
80-
)
81-
const projectDir = path.join(workspaceDir, 'projects', 'sushi')
82-
await fs.ensureDir(path.join(workspaceDir, '.vscode'))
76+
// Copy the sushi project to temporary directory
77+
const projectDir = path.join(tempDir, 'projects', 'sushi')
78+
await fs.ensureDir(path.join(tempDir, '.vscode'))
8379
await fs.copy(SUSHI_SOURCE_PATH, projectDir)
84-
await fs.ensureDir(path.join(workspaceDir, '.vscode'))
85-
const context = await startCodeServer({
86-
tempDir: workspaceDir,
87-
})
80+
await fs.ensureDir(path.join(tempDir, '.vscode'))
8881

8982
const settings = {
9083
'sqlmesh.projectPath': projectDir,
91-
'python.defaultInterpreterPath': context.defaultPythonInterpreter,
84+
'python.defaultInterpreterPath': sharedCodeServer.defaultPythonInterpreter,
9285
}
93-
await fs.writeJson(
94-
path.join(workspaceDir, '.vscode', 'settings.json'),
95-
settings,
96-
{ spaces: 2 },
97-
)
86+
await fs.writeJson(path.join(tempDir, '.vscode', 'settings.json'), settings, {
87+
spaces: 2,
88+
})
9889

99-
try {
100-
await openServerPage(page, tempDir, sharedCodeServer)
101-
await testLineageWithProjectPath(page)
102-
} finally {
103-
await stopCodeServer(context)
104-
}
90+
await openServerPage(page, tempDir, sharedCodeServer)
91+
await testLineageWithProjectPath(page)
10592
})
10693

107-
test.skip('Lineage panel renders correctly - relative project outside of workspace', async ({
94+
test('Lineage panel renders correctly - relative project outside of workspace', async ({
10895
page,
10996
sharedCodeServer,
11097
tempDir,
11198
}) => {
112-
const tempFolder = await fs.mkdtemp(
113-
path.join(os.tmpdir(), 'vscode-test-workspace-'),
114-
)
115-
const projectDir = path.join(tempFolder, 'projects', 'sushi')
99+
const projectDir = path.join(tempDir, 'projects', 'sushi')
116100
await fs.copy(SUSHI_SOURCE_PATH, projectDir)
117101

118-
const workspaceDir = path.join(tempFolder, 'workspace')
102+
const workspaceDir = path.join(tempDir, 'workspace')
119103
await fs.ensureDir(workspaceDir)
120104
const context = await startCodeServer({
121105
tempDir: workspaceDir,
@@ -131,26 +115,19 @@ test.skip('Lineage panel renders correctly - relative project outside of workspa
131115
settings,
132116
{ spaces: 2 },
133117
)
134-
135-
try {
136-
await openServerPage(page, tempDir, sharedCodeServer)
137-
await testLineageWithProjectPath(page)
138-
} finally {
139-
await stopCodeServer(context)
140-
}
118+
await openServerPage(page, workspaceDir, sharedCodeServer)
119+
await testLineageWithProjectPath(page)
141120
})
142121

143-
test.skip('Lineage panel renders correctly - absolute path project outside of workspace', async ({
122+
test('Lineage panel renders correctly - absolute path project outside of workspace', async ({
144123
page,
145124
sharedCodeServer,
125+
tempDir,
146126
}) => {
147-
const tempFolder = await fs.mkdtemp(
148-
path.join(os.tmpdir(), 'vscode-test-workspace-'),
149-
)
150-
const projectDir = path.join(tempFolder, 'projects', 'sushi')
127+
const projectDir = path.join(tempDir, 'projects', 'sushi')
151128
await fs.copy(SUSHI_SOURCE_PATH, projectDir)
152129

153-
const workspaceDir = path.join(tempFolder, 'workspace')
130+
const workspaceDir = path.join(tempDir, 'workspace')
154131
await fs.ensureDir(workspaceDir)
155132

156133
const settings = {

0 commit comments

Comments
 (0)