fix: force seed model to rebuild on grant changes

since seed models don't support migration

Author: newtonapple

sqlmesh/core/model/definition.py

@@ -1844,6 +1844,12 @@ def _data_hash_values_no_sql(self) -> t.List[str]:
         for column_name, column_hash in self.column_hashes.items():
             data.append(column_name)
             data.append(column_hash)
+
+        # Include grants in data hash for seed models to force recreation on grant changes
+        # since seed models don't support migration
+        data.append(json.dumps(self.grants, sort_keys=True) if self.grants else "")
+        data.append(self.grants_target_layer)
+
         return data
 
 

tests/core/engine_adapter/integration/test_integration_postgres.py

@@ -698,13 +698,18 @@ def test_grants_metadata_only_changes(
                 "insert": [roles["admin"]["username"]],
             },
         )
-        context.plan(auto_apply=True, no_prompts=True)
+        second_plan_result = context.plan(auto_apply=True, no_prompts=True)
 
         expected_grants = {
             "SELECT": [roles["writer"]["username"], roles["admin"]["username"]],
             "INSERT": [roles["admin"]["username"]],
         }
 
+        # For seed models, grant changes rebuild the entire table, so it will create a new physical table
+        if model_name == "grants_seed" and second_plan_result.new_snapshots:
+            updated_snapshot = second_plan_result.new_snapshots[0]
+            physical_table_name = updated_snapshot.table_name()
+
         updated_physical_grants = engine_adapter._get_current_grants_config(
             exp.to_table(physical_table_name, dialect=engine_adapter.dialect)
         )

tests/core/test_snapshot.py

@@ -1045,7 +1045,7 @@ def test_fingerprint_seed_model():
     )
 
     expected_fingerprint = SnapshotFingerprint(
-        data_hash="1586624913",
+        data_hash="2112858704",
         metadata_hash="2674364560",
     )
 

tests/core/test_snapshot_evaluator.py

@@ -67,7 +67,6 @@
     IncrementalUnmanagedStrategy,
     MaterializableStrategy,
     SCDType2Strategy,
-    SeedStrategy,
     SnapshotCreationFailedError,
     ViewStrategy,
 )
@@ -5048,9 +5047,13 @@ def test_grants_target_layer(
         assert sync_grants_mock.call_args[0][1] == grants
     sync_grants_mock.reset_mock()
     evaluator.promote([snapshot], EnvironmentNamingInfo(name="prod"))
-    if target_layer == GrantsTargetLayer.ALL:
-        assert sync_grants_mock.call_count == 2
-    else:
+    if target_layer == GrantsTargetLayer.VIRTUAL:
+        assert sync_grants_mock.call_count == 1
+    elif target_layer == GrantsTargetLayer.PHYSICAL:
+        # Physical layer: no grants applied during promotion (already applied during create)
+        assert sync_grants_mock.call_count == 0
+    else:  # target_layer == GrantsTargetLayer.ALL
+        # All layers: only virtual grants applied during promotion (physical already done in create)
         assert sync_grants_mock.call_count == 1
 
 
@@ -5161,7 +5164,7 @@ def test_grants_create_and_evaluate(
         IncrementalUnmanagedStrategy,
         IncrementalByUniqueKeyStrategy,
         SCDType2Strategy,
-        SeedStrategy,
+        # SeedStrategy excluded because seeds do not support migrations
     ],
 )
 def test_grants_materializable_strategy_migrate(