Skip to content

Commit 68def30

Browse files
authored
Fix: Put bigframes back as an optional dependency separate from bigquery (#4549)
1 parent 8a41368 commit 68def30

File tree

2 files changed

+6
-2
lines changed

2 files changed

+6
-2
lines changed

Makefile

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -157,6 +157,7 @@ snowflake-test: guard-SNOWFLAKE_ACCOUNT guard-SNOWFLAKE_WAREHOUSE guard-SNOWFLAK
157157
pytest -n auto -m "snowflake" --retries 3 --junitxml=test-results/junit-snowflake.xml
158158

159159
bigquery-test: guard-BIGQUERY_KEYFILE engine-bigquery-install
160+
pip install -e ".[bigframes]"
160161
pytest -n auto -m "bigquery" --retries 3 --junitxml=test-results/junit-bigquery.xml
161162

162163
databricks-test: guard-DATABRICKS_CATALOG guard-DATABRICKS_SERVER_HOSTNAME guard-DATABRICKS_HTTP_PATH guard-DATABRICKS_ACCESS_TOKEN guard-DATABRICKS_CONNECT_VERSION engine-databricks-install

pyproject.toml

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -41,9 +41,12 @@ athena = ["PyAthena[Pandas]"]
4141
azuresql = ["pymssql"]
4242
bigquery = [
4343
"google-cloud-bigquery[pandas]",
44-
"google-cloud-bigquery-storage",
45-
"bigframes"
44+
"google-cloud-bigquery-storage"
4645
]
46+
# bigframes has to be separate to support environments with an older google-cloud-bigquery pin
47+
# this is because that pin pulls in an older bigframes and the bigframes team
48+
# pinned an older SQLGlot which is incompatible with SQLMesh
49+
bigframes = ["bigframes>=1.32.0"]
4750
clickhouse = ["clickhouse-connect"]
4851
databricks = ["databricks-sql-connector[pyarrow]"]
4952
dev = [

0 commit comments

Comments
 (0)