Skip to content

Commit 60e1a16

Browse files
committed
Support auto_restatement_cron in python models
1 parent e46caec commit 60e1a16

File tree

2 files changed

+13
-2
lines changed

2 files changed

+13
-2
lines changed

sqlmesh/core/model/definition.py

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2866,6 +2866,9 @@ def render_field_value(value: t.Any) -> t.Any:
28662866
for key, value in field_value.items():
28672867
if key in RUNTIME_RENDERED_MODEL_FIELDS:
28682868
rendered_dict[key] = parse_strings_with_macro_refs(value, dialect)
2869+
elif key == "auto_restatement_cron":
2870+
# Don't parse auto_restatement_cron="@..." kwarg (e.g. @daily) into MacroVar
2871+
rendered_dict[key] = value
28692872
elif (rendered := render_field_value(value)) is not None:
28702873
rendered_dict[key] = rendered
28712874

tests/core/test_model.py

Lines changed: 10 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2898,7 +2898,15 @@ def my_model_2(context):
28982898
# no warning with valid kind dict
28992899
with patch.object(get_console(), "log_warning") as mock_logger:
29002900

2901-
@model("kind_valid_dict", kind=dict(name=ModelKindName.FULL), columns={'"COL"': "int"})
2901+
@model(
2902+
"kind_valid_dict",
2903+
kind=dict(
2904+
name=ModelKindName.INCREMENTAL_BY_TIME_RANGE,
2905+
time_column="ds",
2906+
auto_restatement_cron="@hourly",
2907+
),
2908+
columns={'"ds"': "date", '"COL"': "int"},
2909+
)
29022910
def my_model(context):
29032911
pass
29042912

@@ -2907,7 +2915,7 @@ def my_model(context):
29072915
path=Path("."),
29082916
)
29092917

2910-
assert isinstance(python_model.kind, FullKind)
2918+
assert isinstance(python_model.kind, IncrementalByTimeRangeKind)
29112919

29122920
assert not mock_logger.call_args
29132921

0 commit comments

Comments
 (0)