recreate is not needed for views in case of metadata changes + comments not supported

Author: xardasos

sqlmesh/core/snapshot/evaluator.py

@@ -477,6 +477,7 @@ def migrate(
         allow_destructive_snapshots: t.Optional[t.Set[str]] = None,
         allow_additive_snapshots: t.Optional[t.Set[str]] = None,
         deployability_index: t.Optional[DeployabilityIndex] = None,
+        directly_or_indirectly_modified_snapshots_ids: t.Set[SnapshotId] = None,
     ) -> None:
         """Alters a physical snapshot table to match its snapshot's schema for the given collection of snapshots.
 
@@ -486,6 +487,7 @@ def migrate(
             allow_destructive_snapshots: Set of snapshots that are allowed to have destructive schema changes.
             allow_additive_snapshots: Set of snapshots that are allowed to have additive schema changes.
             deployability_index: Determines snapshots that are deployable in the context of this evaluation.
+            directly_or_indirectly_modified_snapshots_ids: Set of SnapshotIds with direct or indirect changes.
         """
         deployability_index = deployability_index or DeployabilityIndex.all_deployable()
         target_data_objects = self._get_physical_data_objects(target_snapshots, deployability_index)
@@ -510,6 +512,10 @@ def migrate(
                     allow_additive_snapshots,
                     self.get_adapter(s.model_gateway),
                     deployability_index,
+                    only_metadata_changes=s.snapshot_id
+                    not in directly_or_indirectly_modified_snapshots_ids
+                    if directly_or_indirectly_modified_snapshots_ids is not None
+                    else False,
                 ),
                 self.ddl_concurrent_tasks,
             )
@@ -1111,6 +1117,7 @@ def _migrate_snapshot(
         allow_additive_snapshots: t.Set[str],
         adapter: EngineAdapter,
         deployability_index: DeployabilityIndex,
+        only_metadata_changes: bool,
     ) -> None:
         if not snapshot.is_model or snapshot.is_symbolic:
             return
@@ -1154,6 +1161,7 @@ def _migrate_snapshot(
                     allow_destructive_snapshots=allow_destructive_snapshots,
                     allow_additive_snapshots=allow_additive_snapshots,
                     run_pre_post_statements=True,
+                    only_metadata_changes=only_metadata_changes,
                 )
             else:
                 self._execute_create(
@@ -1190,6 +1198,7 @@ def _migrate_target_table(
         allow_destructive_snapshots: t.Set[str],
         allow_additive_snapshots: t.Set[str],
         run_pre_post_statements: bool = False,
+        only_metadata_changes: bool = None,
     ) -> None:
         adapter = self.get_adapter(snapshot.model.gateway)
 
@@ -1226,6 +1235,7 @@ def _migrate_target_table(
                 ignore_destructive=snapshot.model.on_destructive_change.is_ignore,
                 ignore_additive=snapshot.model.on_additive_change.is_ignore,
                 deployability_index=deployability_index,
+                only_metadata_changes=only_metadata_changes,
             )
         finally:
             if snapshot.is_materialized:
@@ -2760,20 +2770,23 @@ def migrate(
         **kwargs: t.Any,
     ) -> None:
         logger.info("Migrating view '%s'", target_table_name)
-        model = snapshot.model
-        render_kwargs = dict(
-            execution_time=now(), snapshots=kwargs["snapshots"], engine_adapter=self.adapter
-        )
+        if not (
+            kwargs["only_metadata_changes"] and self.adapter.COMMENT_CREATION_VIEW.is_unsupported
+        ):
+            model = snapshot.model
+            render_kwargs = dict(
+                execution_time=now(), snapshots=kwargs["snapshots"], engine_adapter=self.adapter
+            )
 
-        self.adapter.create_view(
-            target_table_name,
-            model.render_query_or_raise(**render_kwargs),
-            model.columns_to_types,
-            materialized=self._is_materialized_view(model),
-            view_properties=model.render_physical_properties(**render_kwargs),
-            table_description=model.description,
-            column_descriptions=model.column_descriptions,
-        )
+            self.adapter.create_view(
+                target_table_name,
+                model.render_query_or_raise(**render_kwargs),
+                model.columns_to_types,
+                materialized=self._is_materialized_view(model),
+                view_properties=model.render_physical_properties(**render_kwargs),
+                table_description=model.description,
+                column_descriptions=model.column_descriptions,
+            )
 
         # Apply grants after view migration
         deployability_index = kwargs.get("deployability_index")