Skip to content

Commit 5e12255

Browse files
committed
fix scrollbar styling
1 parent 72104a8 commit 5e12255

File tree

3 files changed

+10
-11
lines changed

3 files changed

+10
-11
lines changed

web/common/src/components/ModelName/ModelName.stories.tsx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -76,7 +76,7 @@ export const Grayscale: Story = {
7676
export const Link: Story = {
7777
args: {
7878
name: 'catalog.schema.model',
79-
link: 'https://www.google.com',
79+
renderLink: modelName => <a href="https://www.google.com">{modelName}</a>,
8080
grayscale: false,
8181
showCopy: true,
8282
},
@@ -85,7 +85,7 @@ export const Link: Story = {
8585
export const LinkGrayscale: Story = {
8686
args: {
8787
name: 'catalog.schema.model',
88-
link: 'https://www.google.com',
88+
renderLink: modelName => <a href="https://www.google.com">{modelName}</a>,
8989
grayscale: true,
9090
showCopy: true,
9191
},

web/common/src/components/ModelName/ModelName.tsx

Lines changed: 7 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@ export interface ModelNameProps extends React.HTMLAttributes<HTMLDivElement> {
1919
truncateLimitBefore?: number
2020
truncateLimitAfter?: number
2121
grayscale?: boolean
22-
link?: string
22+
renderLink?: (modelName: React.ReactNode) => React.ReactNode
2323
className?: string
2424
}
2525

@@ -39,7 +39,7 @@ export const ModelName = React.forwardRef<HTMLDivElement, ModelNameProps>(
3939
truncateLimitBefore = 5,
4040
truncateLimitAfter = 7,
4141
grayscale = false,
42-
link,
42+
renderLink,
4343
className,
4444
...props
4545
},
@@ -94,7 +94,7 @@ export const ModelName = React.forwardRef<HTMLDivElement, ModelNameProps>(
9494
grayscale
9595
? 'text-model-name-grayscale-model'
9696
: 'text-model-name-model',
97-
link && '-mt-[4px]',
97+
renderLink && '-mt-[4px]',
9898
)}
9999
/>
100100
)
@@ -174,18 +174,17 @@ export const ModelName = React.forwardRef<HTMLDivElement, ModelNameProps>(
174174
{...props}
175175
>
176176
{!hideIcon && renderIcon()}
177-
{link ? (
178-
<a
179-
href={link}
177+
{renderLink ? (
178+
<span
180179
className={cn(
181180
'flex cursor-pointer border-b -mt-0.5 text-inherit',
182181
grayscale
183182
? 'border-model-name-grayscale-link-underline hover:border-model-name-grayscale-link-underline-hover'
184183
: 'border-model-name-link-underline hover:border-model-name-link-underline-hover',
185184
)}
186185
>
187-
{renderNameWithTooltip()}
188-
</a>
186+
{renderLink(renderNameWithTooltip())}
187+
</span>
189188
) : (
190189
renderNameWithTooltip()
191190
)}
Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
11
:root {
22
--scrollbar-thumb: var(--color-neutral-300);
3-
--scrollbar-track: var(--color-neutral-100);
3+
--scrollbar-track: var(--color-transparent);
44
}

0 commit comments

Comments
 (0)