Improvements

Author: crericha

sqlmesh/dbt/model.py

@@ -2,6 +2,7 @@
 
 import datetime
 import typing as t
+import logging
 
 from sqlglot import exp
 from sqlglot.errors import SqlglotError
@@ -35,6 +36,9 @@
     from sqlmesh.dbt.context import DbtContext
 
 
+logger = logging.getLogger(__name__)
+
+
 INCREMENTAL_BY_TIME_STRATEGIES = set(["delete+insert", "insert_overwrite", "microbatch"])
 INCREMENTAL_BY_UNIQUE_KEY_STRATEGIES = set(["merge"])
 
@@ -517,8 +521,13 @@ def to_sqlmesh(
                         raise ConfigError(
                             f"Failed to parse model '{self.canonical_name(context)}' partition_by field '{p}' in '{self.path}': {e}"
                         ) from e
-            elif isinstance(self.partition_by, dict) and context.target.dialect == "bigquery":
-                partitioned_by.append(self._big_query_partition_by_expr(context))
+            elif isinstance(self.partition_by, dict):
+                if context.target.dialect == "bigquery":
+                    partitioned_by.append(self._big_query_partition_by_expr(context))
+                else:
+                    logger.warning(
+                        f"Ignoring partition_by config for model '{self.name}' targeting {context.target.dialect}; it is only supported for bigquery."
+                    )
 
             if partitioned_by:
                 optional_kwargs["partitioned_by"] = partitioned_by

tests/dbt/test_transformation.py

@@ -1469,6 +1469,9 @@ def test_partition_by(sushi_test_project: Project):
     model_config.partition_by = {"field": "ds", "data_type": "date", "granularity": "day"}
     assert model_config.to_sqlmesh(context).partitioned_by == [exp.to_column("ds", quoted=True)]
 
+    context.target = DuckDbConfig(name="target", schema="foo")
+    assert model_config.to_sqlmesh(context).partitioned_by == []
+
 
 @pytest.mark.xdist_group("dbt_manifest")
 def test_partition_by_none(sushi_test_project: Project):