Feat: provide useful error for invalid model kind (#3581)

Author: treysp

sqlmesh/core/dialect.py

@@ -577,7 +577,12 @@ def parse(self: Parser) -> t.Optional[exp.Expression]:
                 if not field or isinstance(field, (MacroVar, MacroFunc)):
                     value = field
                 else:
-                    kind = ModelKindName[field.name.upper()]
+                    try:
+                        kind = ModelKindName[field.name.upper()]
+                    except KeyError:
+                        raise SQLMeshError(
+                            f"Model kind specified as '{field.name}', but that is not a valid model kind.\n\nPlease specify one of {', '.join(ModelKindName)}."
+                        )
 
                     if kind in (
                         ModelKindName.INCREMENTAL_BY_TIME_RANGE,

tests/core/test_model.py

@@ -5910,6 +5910,22 @@ def test_model_kind_to_expression():
     )
 
 
+def test_bad_model_kind():
+    with pytest.raises(
+        SQLMeshError,
+        match=f"Model kind specified as 'BAD_KIND', but that is not a valid model kind.\n\nPlease specify one of {', '.join(ModelKindName)}.",
+    ):
+        d.parse(
+            """
+        MODEL (
+            name db.table,
+            kind BAD_KIND
+        );
+        SELECT a, b
+        """
+        )
+
+
 def test_merge_filter():
     expressions = d.parse(
         """
@@ -5945,7 +5961,7 @@ def test_merge_filter():
             merge_filter (
                 source.ds > (SELECT MAX(ds) FROM db.test) AND
                 source.ds > @start_ds AND
-                source._operation <> 1 AND 
+                source._operation <> 1 AND
                 target.start_date > dateadd(day, -7, current_date)
             )
           )