Skip to content

Commit 2a4f549

Browse files
authored
feat(lsp): log errors instead of notifications (#4659)
1 parent 8cb48d2 commit 2a4f549

File tree

1 file changed

+12
-7
lines changed

1 file changed

+12
-7
lines changed

sqlmesh/lsp/main.py

Lines changed: 12 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -103,12 +103,13 @@ def initialize(ls: LanguageServer, params: types.InitializeParams) -> None:
103103
loaded_sqlmesh_message(ls, folder_path)
104104
return # Exit after successfully loading any config
105105
except Exception as e:
106-
ls.show_message(
106+
ls.log_trace(
107107
f"Error loading context from {config_path}: {e}",
108-
types.MessageType.Warning,
109108
)
110109
except Exception as e:
111-
ls.show_message(f"Error initializing SQLMesh context: {e}", types.MessageType.Error)
110+
ls.log_trace(
111+
f"Error initializing SQLMesh context: {e}",
112+
)
112113

113114
@self.server.feature(ALL_MODELS_FEATURE)
114115
def all_models(ls: LanguageServer, params: AllModelsRequest) -> AllModelsResponse:
@@ -321,7 +322,9 @@ def hover(ls: LanguageServer, params: types.HoverParams) -> t.Optional[types.Hov
321322
)
322323

323324
except Exception as e:
324-
ls.show_message(f"Error getting hover information: {e}", types.MessageType.Error)
325+
ls.log_trace(
326+
f"Error getting hover information: {e}",
327+
)
325328
return None
326329

327330
@self.server.feature(types.TEXT_DOCUMENT_DEFINITION)
@@ -389,7 +392,9 @@ def diagnostic(
389392
result_id=str(result_id),
390393
)
391394
except Exception as e:
392-
ls.show_message(f"Error getting diagnostics: {e}", types.MessageType.Error)
395+
ls.log_trace(
396+
f"Error getting diagnostics: {e}",
397+
)
393398
return types.RelatedFullDocumentDiagnosticReport(
394399
kind=types.DocumentDiagnosticReportKind.Full,
395400
items=[],
@@ -452,8 +457,8 @@ def workspace_diagnostic(
452457
return types.WorkspaceDiagnosticReport(items=items)
453458

454459
except Exception as e:
455-
ls.show_message(
456-
f"Error getting workspace diagnostics: {e}", types.MessageType.Error
460+
ls.log_trace(
461+
f"Error getting workspace diagnostics: {e}",
457462
)
458463
return types.WorkspaceDiagnosticReport(items=[])
459464

0 commit comments

Comments
 (0)