Fix: Recreate views even if the change was categorized as indirect non-breaking to update table references (#4414)

Author: izeigerman

sqlmesh/core/snapshot/evaluator.py

@@ -902,7 +902,7 @@ def _migrate_snapshot(
         if (
             not snapshot.is_paused
             or not snapshot.is_model
-            or deployability_index.is_representative(snapshot)
+            or (deployability_index.is_representative(snapshot) and not snapshot.is_view)
         ):
             return
 

tests/core/test_integration.py

@@ -4279,6 +4279,28 @@ def test_full_model_change_with_plan_start_not_matching_model_start(
     assert row_num > 0
 
 
+@time_machine.travel("2023-01-08 15:00:00 UTC")
+def test_indirect_non_breaking_view_is_updated_with_new_table_references(
+    init_and_plan_context: t.Callable,
+):
+    context, plan = init_and_plan_context("examples/sushi")
+    context.apply(plan)
+
+    # Add a new projection to the base model
+    model = context.get_model("sushi.waiter_revenue_by_day")
+    context.upsert_model(add_projection_to_model(t.cast(SqlModel, model)))
+
+    context.plan("prod", auto_apply=True, no_prompts=True, skip_tests=True)
+
+    # Run the janitor to delete the old snapshot record
+    context.run_janitor(ignore_ttl=True)
+
+    # Check the downstream view and make sure it's still queryable
+    assert context.get_model("sushi.top_waiters").kind.is_view
+    row_num = context.engine_adapter.fetchone(f"SELECT COUNT(*) FROM sushi.top_waiters")[0]
+    assert row_num > 0
+
+
 @time_machine.travel("2023-01-08 15:00:00 UTC")
 def test_dbt_requirements(sushi_dbt_context: Context):
     assert set(sushi_dbt_context.requirements) == {"dbt-core", "dbt-duckdb"}