Skip to content

Commit 14e5d8a

Browse files
authored
Fix encode model names for lineage and wrong layer order for errors popup (#1806)
1 parent 9741a1b commit 14e5d8a

File tree

6 files changed

+6
-6
lines changed

6 files changed

+6
-6
lines changed

web/client/src/library/components/graph/Graph.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -924,7 +924,7 @@ function ModelColumnLineage({
924924
return (
925925
<div className={clsx('px-1 w-full h-full relative', className)}>
926926
{isBuildingLayout && (
927-
<div className="absolute top-0 left-0 z-[1000] bg-theme flex justify-center items-center w-full h-full">
927+
<div className="absolute top-0 left-0 z-50 bg-theme flex justify-center items-center w-full h-full">
928928
<Loading className="inline-block">
929929
<Spinner className="w-3 h-3 border border-neutral-10 mr-4" />
930930
<h3 className="text-md">Building Lineage...</h3>

web/client/src/library/components/graph/help.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -315,7 +315,7 @@ function mergeLineageWithModels(
315315
key = encodeURI(key)
316316

317317
acc[key] = {
318-
models,
318+
models: models.map(encodeURI),
319319
columns: currentLineage?.[key]?.columns ?? undefined,
320320
}
321321

web/client/src/library/components/modal/Modal.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@ export default function Modal({
2222
>
2323
<Dialog
2424
as="div"
25-
className="relative z-[100]"
25+
className="relative z-50"
2626
onClose={onClose}
2727
>
2828
<Transition.Child

web/client/src/library/components/modal/ModalDrawer.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@ export default function ModalDrawer({
2121
>
2222
<Dialog
2323
as="div"
24-
className="relative z-[100] w-full h-full "
24+
className="relative z-50 w-full h-full "
2525
onClose={onClose}
2626
tabIndex={1}
2727
>

web/client/src/library/components/report/ReportErrors.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -57,7 +57,7 @@ export default function ReportErrors(): JSX.Element {
5757
>
5858
<Popover.Panel
5959
className={clsx(
60-
'absolute top-20 right-2 z-[1000] rounded-md bg-light transform overflow-hidden text-danger-700 shadow-2xl',
60+
'absolute top-20 right-2 z-50 rounded-md bg-light transform overflow-hidden text-danger-700 shadow-2xl',
6161
'w-[90vw] max-h-[80vh]',
6262
)}
6363
>

web/client/src/library/pages/editor/Editor.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,7 @@ export default function PageEditor(): JSX.Element {
4040
sizes={[20, 80]}
4141
minSize={[8, 8]}
4242
snapOffset={0}
43-
className="flex w-full h-full overflow-hidden"
43+
className="flex w-full h-full overflow-hidden z-10"
4444
>
4545
<div className="h-full">
4646
<Suspense

0 commit comments

Comments
 (0)