Feat: enable duckdb>=0.10 comment registration (#2660)

Author: treysp

docs/concepts/models/overview.md

@@ -126,19 +126,20 @@ In the latter method, separate commands are required for every comment. This may
 
 This table lists each engine's support for `TABLE` and `VIEW` object comments:
 
-| Engine       | `TABLE` comments | `VIEW` comments |
-| ------------ | ---------------- | --------------- |
-| BigQuery     | Y                | Y               |
-| Databricks   | Y                | Y               |
-| DuckDB       | N                | N               |
-| MySQL        | Y                | Y               |
-| MSSQL        | N                | N               |
-| Postgres     | Y                | Y               |
-| GCP Postgres | Y                | Y               |
-| Redshift     | Y                | N               |
-| Snowflake    | Y                | Y               |
-| Spark        | Y                | Y               |
-| Trino        | Y                | Y               |
+| Engine        | `TABLE` comments | `VIEW` comments |
+| ------------- | ---------------- | --------------- |
+| BigQuery      | Y                | Y               |
+| Databricks    | Y                | Y               |
+| DuckDB <=0.9  | N                | N               |
+| DuckDB >=0.10 | Y                | Y               |
+| MySQL         | Y                | Y               |
+| MSSQL         | N                | N               |
+| Postgres      | Y                | Y               |
+| GCP Postgres  | Y                | Y               |
+| Redshift      | Y                | N               |
+| Snowflake     | Y                | Y               |
+| Spark         | Y                | Y               |
+| Trino         | Y                | Y               |
 
 
 ## Model properties

sqlmesh/core/engine_adapter/duckdb.py

@@ -1,7 +1,7 @@
 from __future__ import annotations
 
 import typing as t
-
+from duckdb import __version__ as duckdb_version
 from sqlglot import exp
 
 from sqlmesh.core.engine_adapter.mixins import (
@@ -17,6 +17,7 @@
     SourceQuery,
     set_catalog,
 )
+from sqlmesh.utils import major_minor
 
 if t.TYPE_CHECKING:
     from sqlmesh.core._typing import SchemaName, TableName
@@ -28,8 +29,13 @@ class DuckDBEngineAdapter(LogicalMergeMixin, GetCurrentCatalogFromFunctionMixin)
     DIALECT = "duckdb"
     SUPPORTS_TRANSACTIONS = False
     CATALOG_SUPPORT = CatalogSupport.FULL_SUPPORT
-    COMMENT_CREATION_TABLE = CommentCreationTable.UNSUPPORTED
-    COMMENT_CREATION_VIEW = CommentCreationView.UNSUPPORTED
+
+    # TODO: remove once we stop supporting DuckDB 0.9
+    COMMENT_CREATION_TABLE, COMMENT_CREATION_VIEW = (
+        (CommentCreationTable.UNSUPPORTED, CommentCreationView.UNSUPPORTED)
+        if major_minor(duckdb_version) < (0, 10)
+        else (CommentCreationTable.COMMENT_COMMAND_ONLY, CommentCreationView.COMMENT_COMMAND_ONLY)
+    )
 
     def set_current_catalog(self, catalog: str) -> None:
         """Sets the catalog name of the current connection."""

tests/core/engine_adapter/test_integration.py

@@ -269,6 +269,17 @@ def get_table_comment(
                     schema_name = '{schema_name}'
                     AND table_name = '{table_name}'
             """
+        elif self.dialect == "duckdb":
+            kind = "table" if table_kind == "BASE TABLE" else "view"
+            query = f"""
+                SELECT
+                    {kind}_name,
+                    comment
+                FROM duckdb_{kind}s()
+                WHERE
+                    schema_name = '{schema_name}'
+                    AND {kind}_name = '{table_name}'
+            """
 
         result = self.engine_adapter.fetchall(query)
 
@@ -353,6 +364,16 @@ def get_column_comments(
         elif self.dialect == "trino":
             query = f"SHOW COLUMNS FROM {schema_name}.{table_name}"
             comment_index = 3
+        elif self.dialect == "duckdb":
+            query = f"""
+                SELECT
+                    column_name,
+                    comment
+                FROM duckdb_columns()
+                WHERE
+                    schema_name = '{schema_name}'
+                    AND table_name = '{table_name}'
+            """
 
         result = self.engine_adapter.fetchall(query)