Skip to content

Commit 09fa4bd

Browse files
committed
extra styling
1 parent d0494e5 commit 09fa4bd

File tree

10 files changed

+38
-46
lines changed

10 files changed

+38
-46
lines changed
Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,7 @@
1+
:root {
2+
--color-input-background: var(--color-light);
3+
--color-input-background-translucid: var(--color-neutral-5);
4+
--color-input-foreground: var(--color-prose);
5+
--color-input-placeholder: var(--color-neutral-400);
6+
--color-input-border: var(--color-neutral-300);
7+
}

web/common/src/components/Input/Input.tsx

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,8 @@ import { cn } from '@/utils'
33
import type { Size } from '@/types'
44
import { cva } from 'class-variance-authority'
55

6+
import './Input.css'
7+
68
export interface InputProps extends React.ComponentProps<'input'> {
79
inputSize?: Size
810
}
@@ -15,9 +17,9 @@ export const Input = React.forwardRef<HTMLInputElement, InputProps>(
1517
className={cn(
1618
inputVariants({ size: inputSize }),
1719
'border items-center border-input-border bg-input-background text-input-foreground transition-colors placeholder:text-input-placeholder',
18-
'file:border-0 file:h-fit file:bg-background-lucid file:rounded-sm file:flex-col file:mt-0.5',
20+
'file:border-0 file:h-fit file:bg-background-translucid file:rounded-sm file:flex-col file:mt-0.5',
1921
type === 'file' &&
20-
'bg-input-background-lucid border-[transparent] pl-1',
22+
'bg-input-background-translucid border-[transparent] pl-1',
2123
className,
2224
)}
2325
ref={ref}

web/common/src/components/Lineage/stories/Lineage.stories.tsx

Lines changed: 1 addition & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -64,14 +64,8 @@ export const LineageModel = () => {
6464
--color-lineage-model-column-icon: rgba(0, 0, 0, 1);
6565
--color-lineage-model-column-icon-active: rgba(0, 0, 0, 1);
6666
67-
68-
--color-input-background: var(--vscode-input-background)!;
69-
--color-input-foreground: var(--vscode-input-foreground)!;
70-
--color-input-placeholder: var(--vscode-input-placeholderForeground)!;
71-
--color-input-border: var(--vscode-input-border)!;
72-
7367
--color-filterable-list-counter-background: rgba(200, 0, 0, 1);
74-
--color-filterable-list-counter-foreground: rgba(200, 0, 0, 1);
68+
--color-filterable-list-counter-foreground: rgba(200, 200, 200, 1);
7569
}
7670
`}</style>
7771
<ModelLineage

web/common/src/components/Lineage/stories/ModelNode.tsx

Lines changed: 0 additions & 25 deletions
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,6 @@ import { NodeAppendix } from '../node/NodeAppendix'
1616
import { NodeBadge } from '../node/NodeBadge'
1717
import { NodeBase } from '../node/NodeBase'
1818
import { NodeContainer } from '../node/NodeContainer'
19-
import { NodeDivider } from '../node/NodeDivider'
2019
import { NodeHandleIcon } from '../node/NodeHandleIcon'
2120
import { NodeHandles } from '../node/NodeHandles'
2221
import { NodeHeader } from '../node/NodeHeader'
@@ -40,7 +39,6 @@ import {
4039
import { Tooltip } from '@/components/Tooltip/Tooltip'
4140
import type { ColumnLevelLineageAdjacencyList } from '../LineageColumnLevel/ColumnLevelLineageContext'
4241
import { ModelName } from '@/components/ModelName/ModelName'
43-
import { Metadata } from '@/components/Metadata/Metadata'
4442
import { Badge } from '@/components/Badge/Badge'
4543
import { NodePorts } from '../node/NodePorts'
4644

@@ -331,26 +329,3 @@ export const ModelNode = React.memo(function ModelNode({
331329
</NodeContainer>
332330
)
333331
})
334-
335-
export function NodeDetail({
336-
label,
337-
value,
338-
hasDivider = true,
339-
className,
340-
}: {
341-
label: string
342-
value: string
343-
hasDivider?: boolean
344-
className?: string
345-
}) {
346-
return (
347-
<>
348-
{hasDivider && <NodeDivider />}
349-
<Metadata
350-
label={label}
351-
value={value}
352-
className={cn('px-2 text-xs shrink-0 h-6', className)}
353-
/>
354-
</>
355-
)
356-
}
Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,3 @@
1+
:root {
2+
--color-message-translucid: var(--color-neutral-3);
3+
}

web/common/src/components/MessageContainer/MessageContainer.tsx

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,8 @@ import { cn } from '@/utils'
22
import { LoadingContainer } from '../LoadingContainer/LoadingContainer'
33
import { HorizontalContainer } from '../HorizontalContainer/HorizontalContainer'
44

5+
import './MessageContainer.css'
6+
57
export interface MessageContainerProps {
68
children: React.ReactNode
79
className?: string
@@ -19,7 +21,7 @@ export function MessageContainer({
1921
<HorizontalContainer
2022
data-component="MessageContainer"
2123
className={cn(
22-
'h-auto justify-center items-center p-4 bg-message-lucid rounded-2xl',
24+
'h-auto justify-center items-center p-4 bg-message-translucid rounded-2xl',
2325
className,
2426
)}
2527
>
Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,4 @@
1+
:root {
2+
--color-metadata-label: var(--color-neutral-600);
3+
--color-metadata-value: var(--color-prose);
4+
}
Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,9 @@
11
:root {
22
--color-filterable-list-counter-background: var(--color-badge-background);
33
--color-filterable-list-counter-foreground: var(--color-badge-foreground);
4+
5+
--color-filterable-list-input-background: var(--color-input-background);
6+
--color-filterable-list-input-foreground: var(--color-input-foreground);
7+
--color-filterable-list-input-placeholder: var(--color-input-placeholder);
8+
--color-filterable-list-input-border: var(--color-input-border);
49
}

web/common/src/styles/design/semantic-colors.css

Lines changed: 0 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -68,14 +68,4 @@
6868
--color-typography-tagline: var(--color-neutral-600);
6969
--color-typography-description: var(--color-neutral-500);
7070
--color-typography-info: var(--color-typography-tagline);
71-
72-
/* Message */
73-
--color-message-lucid: var(--color-neutral-3);
74-
75-
/* Input */
76-
--color-input-background: var(--color-light);
77-
--color-input-background-lucid: var(--color-neutral-5);
78-
--color-input-foreground: var(--color-prose);
79-
--color-input-placeholder: var(--color-neutral-400);
80-
--color-input-border: var(--color-neutral-300);
8171
}

web/common/tailwind.base.config.js

Lines changed: 11 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -47,7 +47,7 @@ export default {
4747
info: 'var(--color-typography-info)',
4848
},
4949
message: {
50-
lucid: 'var(--color-message-lucid)',
50+
lucid: 'var(--color-message-translucid)',
5151
},
5252
link: {
5353
underline: 'var(--color-link-underline)',
@@ -81,6 +81,12 @@ export default {
8181
background: 'var(--color-filterable-list-counter-background)',
8282
foreground: 'var(--color-filterable-list-counter-foreground)',
8383
},
84+
input: {
85+
background: 'var(--color-filterable-list-input-background)',
86+
foreground: 'var(--color-filterable-list-input-foreground)',
87+
placeholder: 'var(--color-filterable-list-input-placeholder)',
88+
border: 'var(--color-filterable-list-input-border)',
89+
},
8490
},
8591
input: {
8692
'background-lucid': 'var(--color-input-background-lucid)',
@@ -131,6 +137,10 @@ export default {
131137
background: 'var(--color-tooltip-background)',
132138
foreground: 'var(--color-tooltip-foreground)',
133139
},
140+
metadata: {
141+
label: 'var(--color-metadata-label)',
142+
value: 'var(--color-metadata-value)',
143+
},
134144
},
135145
borderRadius: {
136146
'2xs': 'var(--radius-xs)',

0 commit comments

Comments
 (0)