refactor(adms): tidy __all__ ordering and drop defensive getattr

adwitiyasushant · adwitiyasushant · commit ec9a502ed3ef · 2026-06-02T21:08:57.000+05:30
- Sort the exceptions group of __all__ alphabetically (AdmsError /
  AdmsOperationError now precede AuthError) for consistency with the
  surrounding groups.
- Replace getattr(config, "resource", None) with config.resource —
  AdmsConfig is a dataclass with a typed `resource: str | None = None`
  field, so the attribute is always present.
diff --git a/src/sap_cloud_sdk/adms/__init__.py b/src/sap_cloud_sdk/adms/__init__.py
@@ -93,11 +93,11 @@
     # config
     "AdmsConfig",
     # exceptions
+    "AdmsError",
+    "AdmsOperationError",
     "AuthError",
     "ClientCreationError",
     "ConfigError",
-    "AdmsError",
-    "AdmsOperationError",
     "DocumentNotFoundError",
     "HttpError",
     "ScanNotCleanError",
diff --git a/src/sap_cloud_sdk/adms/_auth.py b/src/sap_cloud_sdk/adms/_auth.py
@@ -59,7 +59,7 @@ def __init__(
             client_secret=config.client_secret,
             session=session,
             cache=cache,
-            resource=getattr(config, "resource", None),
+            resource=config.resource,
         )
 
     def get_token(self) -> str:

Original file line number	Diff line number	Diff line change
`@@ -59,7 +59,7 @@ def __init__(`
`59`	`59`	`client_secret=config.client_secret,`
`60`	`60`	`session=session,`
`61`	`61`	`cache=cache,`
`62`		`- resource=getattr(config, "resource", None),`
	`62`	`+ resource=config.resource,`
`63`	`63`	`)`
`64`	`64`
`65`	`65`	`def get_token(self) -> str:`