refactor(adms): drop vestigial _auth wrapper around IasTokenFetcher

Per reviewer feedback (NicoleMGomes, PR #138): after the relocation
refactor moved IasTokenFetcher into the adms package, the _auth wrapper
(config adaptation + AuthError conversion) became pure boilerplate
wrapping a sibling class. Inline the adaptation into _ias_fetcher
(constructor now takes AdmsConfig directly) and drop the duplicate
AuthError by importing from adms.exceptions. Consolidates two
overlapping test files into test_ias_fetcher.py.

Author: adwitiyasushant

src/sap_cloud_sdk/adms/_auth.py

@@ -24,7 +24,7 @@
 from requests import Response
 from requests.exceptions import RequestException
 
-from sap_cloud_sdk.adms._auth import IasTokenFetcher
+from sap_cloud_sdk.adms._ias_fetcher import IasTokenFetcher
 from sap_cloud_sdk.adms.config import AdmsConfig
 from sap_cloud_sdk.adms.exceptions import DocumentNotFoundError, HttpError
 from sap_cloud_sdk.adms._async_http import AsyncHttpClient

src/sap_cloud_sdk/adms/_http.py

@@ -1,12 +1,8 @@
-"""Generic SAP IAS (Identity Authentication Service) token fetcher.
+"""SAP IAS (Identity Authentication Service) token fetcher for ADMS.
 
 Provides:
 - :class:`IasTokenFetcher` — client_credentials + jwt-bearer token acquisition
-  against any SAP IAS tenant, with pluggable :class:`~._token_cache.TokenCache`.
-
-This module is **service-agnostic**: pass raw ``ias_url``, ``client_id``, and
-``client_secret`` directly.  Service-specific config adapters (e.g. the DMS
-module's ``IasTokenFetcher``) subclass this and adapt their own config objects.
+  against the SAP IAS tenant, with pluggable :class:`~._token_cache.TokenCache`.
 
 Token caching:
     By default tokens are cached in-process via :class:`InMemoryTokenCache`.
@@ -22,6 +18,8 @@
 import requests
 
 from sap_cloud_sdk.adms._token_cache import InMemoryTokenCache, TokenCache
+from sap_cloud_sdk.adms.config import AdmsConfig
+from sap_cloud_sdk.adms.exceptions import AuthError
 
 # Grant types (RFC 6749 / RFC 7523)
 _GRANT_CLIENT_CREDENTIALS = "client_credentials"
@@ -40,10 +38,6 @@
 _TOKEN_REQUEST_TIMEOUT_SECONDS = 10
 
 
-class AuthError(Exception):
-    """Raised when IAS token acquisition or exchange fails."""
-
-
 class IasTokenFetcher:
     """Fetches and caches OAuth2 access tokens from SAP IAS.
 
@@ -54,42 +48,43 @@ class IasTokenFetcher:
       services can enforce per-user permissions.
 
     Args:
-        ias_url: IAS tenant base URL, e.g. ``https://tenant.accounts.ondemand.com``.
-        client_id: IAS OAuth2 client ID.
-        client_secret: IAS OAuth2 client secret.
+        config: :class:`~sap_cloud_sdk.adms.config.AdmsConfig` with IAS
+            credentials (``ias_url``, ``client_id``, ``client_secret``,
+            optional ``resource``).
         session: Optional ``requests.Session`` to reuse (useful for testing).
         cache: Pluggable :class:`TokenCache`.  Defaults to
             :class:`InMemoryTokenCache`.  Pass a :class:`RedisTokenCache` for
             multi-instance deployments.
 
     Example::
 
-        from sap_cloud_sdk.adms import IasTokenFetcher
-        fetcher = IasTokenFetcher(
+        from sap_cloud_sdk.adms._ias_fetcher import IasTokenFetcher
+        from sap_cloud_sdk.adms.config import AdmsConfig
+
+        config = AdmsConfig(
+            service_url="https://adm.example.com",
             ias_url="https://tenant.accounts.ondemand.com",
             client_id="my-client",
             client_secret="my-secret",
         )
+        fetcher = IasTokenFetcher(config)
         token = fetcher.get_token()
         headers = {"Authorization": f"Bearer {token}"}
     """
 
     def __init__(
         self,
-        ias_url: str,
-        client_id: str,
-        client_secret: str,
+        config: AdmsConfig,
         session: Optional[requests.Session] = None,
         cache: Optional[TokenCache] = None,
-        resource: Optional[str] = None,
     ) -> None:
-        self._ias_url = ias_url.rstrip("/")
-        self._client_id = client_id
-        self._client_secret = client_secret
+        self._ias_url = config.ias_url.rstrip("/")
+        self._client_id = config.client_id
+        self._client_secret = config.client_secret
         self._session = session or requests.Session()
         self._token_url = self._ias_url + "/oauth2/token"
         self._cache: TokenCache = cache or InMemoryTokenCache()
-        self._resource: Optional[str] = resource
+        self._resource: Optional[str] = config.resource
 
     # ------------------------------------------------------------------
     # Public API

src/sap_cloud_sdk/adms/_ias_fetcher.py

@@ -29,7 +29,7 @@
 
 import httpx
 
-from sap_cloud_sdk.adms._auth import IasTokenFetcher
+from sap_cloud_sdk.adms._ias_fetcher import IasTokenFetcher
 from sap_cloud_sdk.adms._http import (
     AdmsHttp,
     AsyncAdmsHttp,

src/sap_cloud_sdk/adms/client.py

@@ -9,7 +9,7 @@
 import pytest
 
 from sap_cloud_sdk.adms import create_client
-from sap_cloud_sdk.adms._auth import IasTokenFetcher
+from sap_cloud_sdk.adms._ias_fetcher import IasTokenFetcher
 from sap_cloud_sdk.adms._http import AdmsHttp, AsyncAdmsHttp
 from sap_cloud_sdk.adms._models import (
     AllowedDomain,

tests/adms/unit/test_auth.py

@@ -6,7 +6,7 @@
 import pytest
 import requests
 
-from sap_cloud_sdk.adms._auth import IasTokenFetcher
+from sap_cloud_sdk.adms._ias_fetcher import IasTokenFetcher
 from sap_cloud_sdk.adms._http import AdmsHttp, quote_odata_guid_key, quote_odata_string_key
 from sap_cloud_sdk.adms.config import AdmsConfig
 from sap_cloud_sdk.adms.exceptions import DocumentNotFoundError, HttpError